From ae094ad45bf5b9f678b9a9b9e2bec61fe3a7cc8e Mon Sep 17 00:00:00 2001 From: Jayash Satolia Date: Thu, 21 Mar 2024 01:51:17 +0530 Subject: [PATCH 1/2] Fix mn-update-settings service charge --- cmd/updatenode.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/cmd/updatenode.go b/cmd/updatenode.go index 8e5ae87c..edc9c6cb 100644 --- a/cmd/updatenode.go +++ b/cmd/updatenode.go @@ -74,6 +74,14 @@ var minerscUpdateNodeSettings = &cobra.Command{ miner.Settings.NumDelegates = &numDelegates } + if flags.Changed("service_charge") { + serviceCharge, err := flags.GetFloat64("service_charge") + if err != nil { + log.Fatal(err) + } + miner.Settings.ServiceCharge = &serviceCharge + } + if flags.Changed("min_stake") { var min float64 if min, err = flags.GetFloat64("min_stake"); err != nil { @@ -139,6 +147,7 @@ func init() { minerscUpdateNodeSettings.PersistentFlags().String("id", "", "miner/sharder ID to update") minerscUpdateNodeSettings.PersistentFlags().Bool("sharder", false, "set true for sharder node") minerscUpdateNodeSettings.PersistentFlags().Int("num_delegates", 0, "max number of delegate pools") + minerscUpdateNodeSettings.PersistentFlags().Float64("service_charge", 0, "service charge") minerscUpdateNodeSettings.PersistentFlags().Float64("min_stake", 0.0, "min stake allowed") minerscUpdateNodeSettings.PersistentFlags().Float64("max_stake", 0.0, "max stake allowed") minerscUpdateNodeSettings.MarkFlagRequired("id") From 37f50a6f088fba96207a700739afda8d938fc024 Mon Sep 17 00:00:00 2001 From: Ash-KODES Date: Thu, 21 Mar 2024 11:40:57 +0530 Subject: [PATCH 2/2] Removing stake config for mn-update-settings command --- cmd/updatenode.go | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/cmd/updatenode.go b/cmd/updatenode.go index edc9c6cb..cf1b1fea 100644 --- a/cmd/updatenode.go +++ b/cmd/updatenode.go @@ -8,7 +8,6 @@ import ( "strings" "sync" - "github.com/0chain/gosdk/core/common" "github.com/0chain/gosdk/zcncore" "github.com/spf13/cobra" ) @@ -82,23 +81,6 @@ var minerscUpdateNodeSettings = &cobra.Command{ miner.Settings.ServiceCharge = &serviceCharge } - if flags.Changed("min_stake") { - var min float64 - if min, err = flags.GetFloat64("min_stake"); err != nil { - log.Fatal(err) - } - tokenBalance := common.Balance(zcncore.ConvertToValue(min)) - miner.Settings.MinStake = &tokenBalance - } - - if flags.Changed("max_stake") { - var max float64 - if max, err = flags.GetFloat64("max_stake"); err != nil { - log.Fatal(err) - } - tokenBalance := common.Balance(zcncore.ConvertToValue(max)) - miner.Settings.MaxStake = &tokenBalance - } txn, err := zcncore.NewTransaction(statusBar, getTxnFee(), nonce) if err != nil { @@ -148,7 +130,5 @@ func init() { minerscUpdateNodeSettings.PersistentFlags().Bool("sharder", false, "set true for sharder node") minerscUpdateNodeSettings.PersistentFlags().Int("num_delegates", 0, "max number of delegate pools") minerscUpdateNodeSettings.PersistentFlags().Float64("service_charge", 0, "service charge") - minerscUpdateNodeSettings.PersistentFlags().Float64("min_stake", 0.0, "min stake allowed") - minerscUpdateNodeSettings.PersistentFlags().Float64("max_stake", 0.0, "max stake allowed") minerscUpdateNodeSettings.MarkFlagRequired("id") }