Skip to content

Removing stake config for mn-update-settings command #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ash-KODES wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Removing stake config for mn-update-settings command #370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae094ad
Fix mn-update-settings service charge
Mar 20, 2024
37f50a6
Removing stake config for mn-update-settings command
Ash-KODES Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions cmd/updatenode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"strings"
"sync"

"github.com/0chain/gosdk/core/common"
"github.com/0chain/gosdk/zcncore"
"github.com/spf13/cobra"
)
Expand Down Expand Up @@ -74,23 +73,14 @@ var minerscUpdateNodeSettings = &cobra.Command{
miner.Settings.NumDelegates = &numDelegates
}

if flags.Changed("min_stake") {
var min float64
if min, err = flags.GetFloat64("min_stake"); err != nil {
if flags.Changed("service_charge") {
serviceCharge, err := flags.GetFloat64("service_charge")
if err != nil {
log.Fatal(err)
}
tokenBalance := common.Balance(zcncore.ConvertToValue(min))
miner.Settings.MinStake = &tokenBalance
miner.Settings.ServiceCharge = &serviceCharge
}

if flags.Changed("max_stake") {
var max float64
if max, err = flags.GetFloat64("max_stake"); err != nil {
log.Fatal(err)
}
tokenBalance := common.Balance(zcncore.ConvertToValue(max))
miner.Settings.MaxStake = &tokenBalance
}

txn, err := zcncore.NewTransaction(statusBar, getTxnFee(), nonce)
if err != nil {
Expand Down Expand Up @@ -139,7 +129,6 @@ func init() {
minerscUpdateNodeSettings.PersistentFlags().String("id", "", "miner/sharder ID to update")
minerscUpdateNodeSettings.PersistentFlags().Bool("sharder", false, "set true for sharder node")
minerscUpdateNodeSettings.PersistentFlags().Int("num_delegates", 0, "max number of delegate pools")
minerscUpdateNodeSettings.PersistentFlags().Float64("min_stake", 0.0, "min stake allowed")
minerscUpdateNodeSettings.PersistentFlags().Float64("max_stake", 0.0, "max stake allowed")
minerscUpdateNodeSettings.PersistentFlags().Float64("service_charge", 0, "service charge")
minerscUpdateNodeSettings.MarkFlagRequired("id")
}