-
Notifications
You must be signed in to change notification settings - Fork 109
Description
Is your enhancement related to a problem? Please describe.
There were some files missing from the most recent release of one of my plugins on wordpress.org, despite the .gitignore and .gitattributes configuration being correct. Everything with the build is fine right up to the point where the plugin gets deployed to the plugin directory.
The problem appears to be caused by an existing svn:ignore prop on the plugin directory, which I historically used to prevent files from being deployed before I switched to using this GitHub action. In the most recent release of the plugin I added files which matched the svn:ignore prop, hence when this action added the files they were actually ignored.
Here's the related portion of the script:
action-wordpress-plugin-deploy/deploy.sh
Line 125 in de0553e
| svn add . --force > /dev/null |
Describe the solution you'd like
It would be great if this action trigger a failure when some files that are present have not been added to svn, to prevent a broken release from being deployed to wordpress.org. I'm not yet sure how this could work.
Additional context
- Build where the missing files (the
vendordirectory in this case) were not added due tovendorbeing present in thesvn:ignoreprop: https://github.com/johnbillion/wp-crontrol/runs/7270118515?check_suite_focus=true#step:8:70 - Discovery of the root cause: possible solution to the problem of the vendor dir not being included in the .org plugin repo johnbillion/wp-crontrol#85
Metadata
Metadata
Assignees
Labels
Type
Projects
Status