Skip to content

Commit 520564b

Browse files
authored
Merge pull request #69 from 38degrees/revert-the-revert-ruby-3-3-5
Reverts previously reverted Ruby 3.3.5 upgrade change
2 parents bb8fe56 + 3e738a3 commit 520564b

File tree

6 files changed

+31
-54
lines changed

6 files changed

+31
-54
lines changed

.circleci/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,18 @@
44

55
version: 2.1
66
orbs:
7-
ruby: circleci/ruby@1.1.1
7+
ruby: circleci/ruby@2.2.1
88
jobs:
99
build:
1010
docker:
11-
- image: circleci/ruby:3.0.0-node-browsers
11+
- image: cimg/ruby:3.3.5-browsers
1212
environment:
1313
- RACK_ENV=test
1414
- RAILS_ENV=test
1515
- DATABASE_URL=postgres://testuser:testpass@127.0.0.1:5432/mahbucket_test
1616
- SKIP_AUTH=true
1717

18-
- image: circleci/postgres:10-alpine-ram
18+
- image: cimg/postgres:10.20
1919
environment:
2020
- POSTGRES_USER=testuser
2121
- POSTGRES_PASSWORD=testpass

Dockerfile

Lines changed: 0 additions & 20 deletions
This file was deleted.

Gemfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ruby "3.0.0"
1+
ruby "3.3.5"
22

33
source 'https://rubygems.org' do
44
gem 'rails', '~> 6.1.7'
@@ -80,6 +80,5 @@ source 'https://rubygems.org' do
8080
gem 'rspec'
8181
gem 'rspec_junit_formatter'
8282
gem 'selenium-webdriver'
83-
gem 'webdrivers', '~> 4.4'
8483
end
8584
end

Gemfile.lock

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ GEM
7272
zeitwerk (~> 2.3)
7373
acts-as-taggable-on (9.0.1)
7474
activerecord (>= 6.0, < 7.1)
75-
addressable (2.8.1)
76-
public_suffix (>= 2.0.2, < 6.0)
75+
addressable (2.8.7)
76+
public_suffix (>= 2.0.2, < 7.0)
7777
ast (2.4.2)
7878
aws-eventstream (1.2.0)
7979
aws-partitions (1.720.0)
@@ -91,16 +91,17 @@ GEM
9191
aws-sigv4 (~> 1.4)
9292
aws-sigv4 (1.5.2)
9393
aws-eventstream (~> 1, >= 1.0.2)
94+
base64 (0.2.0)
9495
brakeman (5.4.1)
9596
builder (3.2.4)
9697
bundler-audit (0.9.1)
9798
bundler (>= 1.2.0, < 3)
9899
thor (~> 1.0)
99-
capybara (3.38.0)
100+
capybara (3.40.0)
100101
addressable
101102
matrix
102103
mini_mime (>= 0.1.3)
103-
nokogiri (~> 1.8)
104+
nokogiri (~> 1.11)
104105
rack (>= 1.6.0)
105106
rack-test (>= 0.6.3)
106107
regexp_parser (>= 1.5, < 3.0)
@@ -171,6 +172,7 @@ GEM
171172
listen (3.8.0)
172173
rb-fsevent (~> 0.10, >= 0.10.3)
173174
rb-inotify (~> 0.9, >= 0.9.10)
175+
logger (1.6.1)
174176
loofah (2.21.3)
175177
crass (~> 1.0.2)
176178
nokogiri (>= 1.12.0)
@@ -185,8 +187,8 @@ GEM
185187
mime-types (3.4.1)
186188
mime-types-data (~> 3.2015)
187189
mime-types-data (3.2023.0218.1)
188-
mini_mime (1.1.2)
189-
mini_portile2 (2.8.5)
190+
mini_mime (1.1.5)
191+
mini_portile2 (2.8.8)
190192
minitest (5.18.1)
191193
multi_xml (0.6.0)
192194
net-imap (0.3.6)
@@ -200,10 +202,10 @@ GEM
200202
net-protocol
201203
newrelic_rpm (9.0.0)
202204
nio4r (2.7.3)
203-
nokogiri (1.16.2)
205+
nokogiri (1.16.7)
204206
mini_portile2 (~> 2.8.2)
205207
racc (~> 1.4)
206-
nokogiri (1.16.2-x86_64-linux)
208+
nokogiri (1.16.7-x86_64-linux)
207209
racc (~> 1.4)
208210
oauth2 (2.0.9)
209211
faraday (>= 0.17.3, < 3.0)
@@ -236,11 +238,11 @@ GEM
236238
method_source (~> 1.0)
237239
pry-rails (0.3.9)
238240
pry (>= 0.10.4)
239-
public_suffix (5.0.1)
241+
public_suffix (6.0.1)
240242
puma (5.6.9)
241243
nio4r (~> 2.0)
242-
racc (1.7.3)
243-
rack (2.2.7)
244+
racc (1.8.1)
245+
rack (2.2.10)
244246
rack-protection (3.0.5)
245247
rack
246248
rack-test (2.1.0)
@@ -283,9 +285,9 @@ GEM
283285
rb-fsevent (0.11.2)
284286
rb-inotify (0.10.1)
285287
ffi (~> 1.0)
286-
regexp_parser (2.7.0)
288+
regexp_parser (2.9.3)
287289
repost (0.4.1)
288-
rexml (3.2.5)
290+
rexml (3.3.9)
289291
rspec (3.12.0)
290292
rspec-core (~> 3.12.0)
291293
rspec-expectations (~> 3.12.0)
@@ -348,7 +350,9 @@ GEM
348350
sprockets (> 3.0)
349351
sprockets-rails
350352
tilt
351-
selenium-webdriver (4.8.1)
353+
selenium-webdriver (4.27.0)
354+
base64 (~> 0.2)
355+
logger (~> 1.4)
352356
rexml (~> 3.2, >= 3.2.5)
353357
rubyzip (>= 1.2.2, < 3.0)
354358
websocket (~> 1.0)
@@ -387,11 +391,7 @@ GEM
387391
execjs (>= 0.3.0, < 3)
388392
unicode-display_width (2.4.2)
389393
version_gem (1.1.1)
390-
webdrivers (4.7.0)
391-
nokogiri (~> 1.6)
392-
rubyzip (>= 1.3.0)
393-
selenium-webdriver (> 3.141, < 5.0)
394-
websocket (1.2.9)
394+
websocket (1.2.11)
395395
websocket-driver (0.7.5)
396396
websocket-extensions (>= 0.1.0)
397397
websocket-extensions (0.1.5)
@@ -442,10 +442,9 @@ DEPENDENCIES
442442
sentry-ruby!
443443
turbolinks!
444444
uglifier!
445-
webdrivers (~> 4.4)!
446445

447446
RUBY VERSION
448-
ruby 3.0.0p0
447+
ruby 3.3.5p100
449448

450449
BUNDLED WITH
451-
2.2.17
450+
2.5.23

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ should hopefully be useful (or at least usable) for other file types too.
1010
## Ruby and Rails versions
1111

1212
Mah Bucket was initially developed using Ruby 2.3.1 and Rails 5.0.1, and is
13-
currently using Ruby 2.7.1 and Rails 6.0.3 - so it should have a fairly wide
13+
currently using Ruby 3.3.5 and Rails ~>6.1.7 - so it should have a fairly wide
1414
compatibility range. If you find a version of either that it won't run with,
1515
please let me know.
1616

docker-compose.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: '3'
33
x-service-fragments:
44
##### Abstract services for common setup #####
55
app: &app
6-
image: ruby
6+
image: cimg/ruby:3.3.5-browsers
77
networks:
88
- default
99
volumes:
@@ -19,7 +19,7 @@ x-service-fragments:
1919
services:
2020
##### Concrete services #####
2121
postgres:
22-
image: 'postgres:9.6-alpine'
22+
image: 'cimg/postgres:10.20'
2323
environment:
2424
# The Postgres image uses these to create a db user - note the user/pass here should match that in your env file!
2525
- POSTGRES_USER=user
@@ -30,9 +30,9 @@ services:
3030

3131
web:
3232
<<: *app
33-
build:
34-
dockerfile: Dockerfile
35-
context: .
33+
volumes:
34+
- '.:/usr/src/app:cached'
35+
working_dir: /usr/src/app
3636
ports:
3737
# Use a default port of 3005, but allow it to be overriden by an env variable
3838
# E.g. `PORT=3001 docker-compose up`
@@ -49,7 +49,6 @@ services:
4949
- SKIP_AUTH=true
5050
command: sh -c 'bundle check || bundle install && rm -f /tmp/.X99-lock && bundle exec rails db:create db:environment:set db:schema:load && bundle exec rubocop && bundle exec rspec && bundle exec puma -C ./config/puma.rb'
5151

52-
5352
volumes:
5453
postgres:
5554
bundle_cache:

0 commit comments

Comments
 (0)