Skip to content

Fix ADR display order. #90

@Vercin-G

Description

@Vercin-G

This one may be a bit tricky.

In the ADR, display of users is handled according to the position ID.

https://github.com/7Cav/adr/blob/a62af527c4ffd88fc3922421f762a4cd72800b31/client/app/adr/modules/MilpacParse.jsx#L27C5-L28

For a while this display order worked nicely due to how these were implemented for primaries. For example:

Major Jeran Berg | Commander A/1-7
First Sergeant Patrick Summerfield | First Sergeant A/1-7
First Lieutenant Dylan Davis | Platoon Leader 1/A/1-7
Chief Warrant Officer 2 Lee Peterson | Platoon Sergeant 1/A/1-7
Chief Warrant Officer 2 Bradley Ratliff | Section Leader 1/1/A/1-7
Specialist Thomas Bull | Assistant Section Leader 1/1/A/1-7
Corporal Marvin Spice | Trooper 1/1/A/1-7
Specialist Gabriel Mooser | Trooper 1/1/A/1-7
Specialist Robert Holman | Trooper 1/1/A/1-7
Specialist Brandon Hudson | Trooper 1/1/A/1-7
Private First Class Aidan DeCann | Trooper 1/1/A/1-7
Private First Class Matt Walmsley | Trooper 1/1/A/1-7
Private First Class Barry Cade | Trooper 1/1/A/1-7
Private Dustin Cartel | Trooper 1/1/A/1-7
Private Rocky Wilson | Trooper 1/1/A/1-7
Recruit Tobias Foxx | Trooper 1/1/A/1-7

However in other cases, for example in sub-departments, addition of new sub-departments has altered the look of the final result to be improper:

Sergeant Major Anthony Preacher | NCOA Lead Instructor
Chief Warrant Officer 2 Bradley Ratliff | NCOA Instructor
Colonel Artyom Stetchkov | NCOA Instructor
First Lieutenant Adrian Hilberg | NCOA Instructor
Sergeant Zachary Markel | NCOA Instructor
First Lieutenant D'Angelo Guzman | NCOA Instructor
Staff Sergeant Josh Formola | NCOA Instructor
First Sergeant Duke Barr | NCOA Instructor
Captain Sostak Sven | NCOA Senior Instructor

In this case, the senior should be under the lead and above the instructors. Need to investigate methods to redo this display order with the chain of command in mind. Originally i had planned to use the position of the values in the billetbank arrays to adjust this, however if we plan on dropping billetbank, we need a new solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions