Request for info: Building on Windows (or on Github)

[Zitchas]

Thanks for your work developing this!

I am interested in learning how to run the program in order to generate a site for Endless Sky Delta; either running it locally or on Github via actions.

I am currently trying to run it locally on a Windows machine. I have boot and yarn installed (as well as node.js), but when I get to the last step of this section:

$ git clone git@github.com:7even/endless-ships.git
$ cd endless-ships
$ git submodule update --init

I get an error

Please make sure you have the correct access rights
and the repository exists.```

I tried swapping that out for zitchas/endless-ships.git to pull from my fork instead, but that didn't change anything.

[Zitchas]

That being said, given that I have a copy of endless-ships downloaded (via github desktop), is it possible to manually place the data files from endless-sky instead of doing it via the program?

edit1 : Just discovered the game data is located inside the .../endless-ships/resources/game/ folder

So that is in place, albeit old as I note it is 0.10.4, but that's alright. For the moment, this is just trying to get it to run properly locally.

[7even]

Can you please try doing git submodule set-url resources/game https://github.com/endless-sky/endless-sky.git when you're in the endless-ships directory, then try git submodule update --init once again?

[Zitchas]

At this point, while in the endless-ships folder, I tried running the boot build command

java.lang.IllegalArgumentException: Cannot open <nil> as a Reader.
        clojure.lang.ExceptionInfo: Cannot open <nil> as a Reader.
    line: 47

Yes, I can.

[Zitchas]

Can you please try doing git submodule set-url resources/game https://github.com/endless-sky/endless-sky.git when you're in the endless-ships directory

It gave this result: Synchronizing submodule url for 'resources/game'

then try git submodule update --init

And it didn't display anything after the second command, and at a glance there isn't any changes in the resource/game folder.

[7even]

Well, since the game files are already in resources/game, then the git submodule should be fine. Now you can switch to it with cd resources/game and do anything git allows you to do, like checking out a given game version with git checkout v0.10.8 (though I would avoid changing anything in there).

As for the Cannot open <nil> as a Reader error, I need to check it when I have the time.

By the way, are you sure you ran boot build when the game files were already in place at resources/game?

[Zitchas]

Yes, although I can relaunch powershell and try again.

[Zitchas]

It gave the same error message.

Full output:

                                                  Boot.main                    Boot.java:  258
                                                        ...
                                              boot.App.main                     App.java:  500
                                           boot.App.runBoot                     App.java:  407
org.projectodd.shimdandy.impl.ClojureRuntimeShimImpl.invoke  ClojureRuntimeShimImpl.java:  145
org.projectodd.shimdandy.impl.ClojureRuntimeShimImpl.invoke  ClojureRuntimeShimImpl.java:  154
                                                        ...
                                            boot.main/-main                     main.clj:  216
                                         boot.main/-main/fn                     main.clj:  216
                                   clojure.core/load-string                     core.clj: 3959
                                   clojure.core/load-reader                     core.clj: 3957
                                                        ...
                                  boot.user$eval3009.invoke                             :   11
                            boot.user$eval3009.invokeStatic                             :   11
                                                        ...
                                       clojure.core/require                     core.clj: 5796 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.core/load-libs                     core.clj: 5758
                                     clojure.core/load-libs                     core.clj: 5774
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                      clojure.core/load-lib                     core.clj: 5717
                                      clojure.core/load-lib                     core.clj: 5736
                                   clojure.core/load-lib/fn                     core.clj: 5737
                                      clojure.core/load-one                     core.clj: 5697
                                                        ...
                                          clojure.core/load                     core.clj: 5876
                                          clojure.core/load                     core.clj: 5892
                                       clojure.core/load/fn                     core.clj: 5893
                                                        ...
                                endless-ships.core/eval3269                     core.clj:    1
                endless-ships.core/eval3269/loading--auto--                     core.clj:    1
                                                        ...
                                       clojure.core/require                     core.clj: 5796 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.core/load-libs                     core.clj: 5758
                                     clojure.core/load-libs                     core.clj: 5774
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                      clojure.core/load-lib                     core.clj: 5717
                                      clojure.core/load-lib                     core.clj: 5736
                                   clojure.core/load-lib/fn                     core.clj: 5737
                                      clojure.core/load-one                     core.clj: 5697
                                                        ...
                                          clojure.core/load                     core.clj: 5876
                                          clojure.core/load                     core.clj: 5892
                                       clojure.core/load/fn                     core.clj: 5893
                                                        ...
                             endless-ships.outfits/eval3275                  outfits.clj:    1
             endless-ships.outfits/eval3275/loading--auto--                  outfits.clj:    1
                                                        ...
                                       clojure.core/require                     core.clj: 5796 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.core/load-libs                     core.clj: 5758
                                     clojure.core/load-libs                     core.clj: 5774
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                      clojure.core/load-lib                     core.clj: 5717
                                      clojure.core/load-lib                     core.clj: 5736
                                   clojure.core/load-lib/fn                     core.clj: 5737
                                      clojure.core/load-one                     core.clj: 5697
                                                        ...
                                          clojure.core/load                     core.clj: 5876
                                          clojure.core/load                     core.clj: 5892
                                       clojure.core/load/fn                     core.clj: 5893
                                                        ...
                                    endless-ships.parser/fn                   parser.clj:   49
                                                        ...
                                        clojure.core/mapcat                     core.clj: 2674 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  641
                                           clojure.core/seq                     core.clj:  137
                                                        ...
                                        clojure.core/map/fn                     core.clj: 2646
                                 endless-ships.parser/fn/fn                   parser.clj:   51
                                 endless-ships.parser/parse                   parser.clj:   40
                                                        ...
                                     instaparse.core/parser                     core.clj:  171
                                     instaparse.core/parser                     core.clj:  255
                                                        ...
                                         clojure.core/slurp                     core.clj: 6657 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.java.io/reader                       io.clj:   86
                                     clojure.java.io/reader                       io.clj:  102
                                       clojure.java.io/fn/G                       io.clj:   69
                                         clojure.java.io/fn                       io.clj:  288
java.lang.IllegalArgumentException: Cannot open <nil> as a Reader.
        clojure.lang.ExceptionInfo: Cannot open <nil> as a Reader.
    line: 47

[7even]

I'll look into it, thanks for the bug report.

[Zitchas]

Thank you!

[7even]

@Zitchas can you please try replacing / with \ in this line and launch boot build again?

[Zitchas]

Just tried doing that, and it gave me an error. I think most of the feedback isn't relevant, but there was this:

java.lang.RuntimeException: Unsupported escape character: \d
clojure.lang.ExceptionInfo: Unsupported escape character: \d
    line: 10

Full Output

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
                                                  Boot.main                    Boot.java:  258
                                                        ...
                                              boot.App.main                     App.java:  500
                                           boot.App.runBoot                     App.java:  407
org.projectodd.shimdandy.impl.ClojureRuntimeShimImpl.invoke  ClojureRuntimeShimImpl.java:  145
org.projectodd.shimdandy.impl.ClojureRuntimeShimImpl.invoke  ClojureRuntimeShimImpl.java:  154
                                                        ...
                                            boot.main/-main                     main.clj:  216
                                         boot.main/-main/fn                     main.clj:  216
                                   clojure.core/load-string                     core.clj: 3959
                                   clojure.core/load-reader                     core.clj: 3957
                                                        ...
                                  boot.user$eval3009.invoke                             :   11
                            boot.user$eval3009.invokeStatic                             :   11
                                                        ...
                                       clojure.core/require                     core.clj: 5796 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.core/load-libs                     core.clj: 5758
                                     clojure.core/load-libs                     core.clj: 5774
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                      clojure.core/load-lib                     core.clj: 5717
                                      clojure.core/load-lib                     core.clj: 5736
                                   clojure.core/load-lib/fn                     core.clj: 5737
                                      clojure.core/load-one                     core.clj: 5697
                                                        ...
                                          clojure.core/load                     core.clj: 5876
                                          clojure.core/load                     core.clj: 5892
                                       clojure.core/load/fn                     core.clj: 5893
                                                        ...
                                endless-ships.core/eval3269                     core.clj:    1
                endless-ships.core/eval3269/loading--auto--                     core.clj:    1
                                                        ...
                                       clojure.core/require                     core.clj: 5796 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.core/load-libs                     core.clj: 5758
                                     clojure.core/load-libs                     core.clj: 5774
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                      clojure.core/load-lib                     core.clj: 5717
                                      clojure.core/load-lib                     core.clj: 5736
                                   clojure.core/load-lib/fn                     core.clj: 5737
                                      clojure.core/load-one                     core.clj: 5697
                                                        ...
                                          clojure.core/load                     core.clj: 5876
                                          clojure.core/load                     core.clj: 5892
                                       clojure.core/load/fn                     core.clj: 5893
                                                        ...
                             endless-ships.outfits/eval3275                  outfits.clj:    1
             endless-ships.outfits/eval3275/loading--auto--                  outfits.clj:    1
                                                        ...
                                       clojure.core/require                     core.clj: 5796 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.core/load-libs                     core.clj: 5758
                                     clojure.core/load-libs                     core.clj: 5774
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                      clojure.core/load-lib                     core.clj: 5717
                                      clojure.core/load-lib                     core.clj: 5736
                                   clojure.core/load-lib/fn                     core.clj: 5737
                                      clojure.core/load-one                     core.clj: 5697
                                                        ...
                                          clojure.core/load                     core.clj: 5876
                                          clojure.core/load                     core.clj: 5892
                                       clojure.core/load/fn                     core.clj: 5893
                                                        ...
java.lang.RuntimeException: Unsupported escape character: \d
clojure.lang.ExceptionInfo: Unsupported escape character: \d
    line: 10

[7even]

Sorry, I forgot that backslashes need to be escaped inside strings in Clojure. Please add a second backslash, so that it's "game\\data".

[Zitchas]

OK, I added the \ to escape it. Unfortunately, it still gives an error.

java.lang.IllegalArgumentException: Cannot open <nil> as a Reader.
        clojure.lang.ExceptionInfo: Cannot open <nil> as a Reader.
    line: 47

Full Output

                                                  Boot.main                    Boot.java:  258
                                                        ...
                                              boot.App.main                     App.java:  500
                                           boot.App.runBoot                     App.java:  407
org.projectodd.shimdandy.impl.ClojureRuntimeShimImpl.invoke  ClojureRuntimeShimImpl.java:  145
org.projectodd.shimdandy.impl.ClojureRuntimeShimImpl.invoke  ClojureRuntimeShimImpl.java:  154
                                                        ...
                                            boot.main/-main                     main.clj:  216
                                         boot.main/-main/fn                     main.clj:  216
                                   clojure.core/load-string                     core.clj: 3959
                                   clojure.core/load-reader                     core.clj: 3957
                                                        ...
                                  boot.user$eval3009.invoke                             :   11
                            boot.user$eval3009.invokeStatic                             :   11
                                                        ...
                                       clojure.core/require                     core.clj: 5796 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.core/load-libs                     core.clj: 5758
                                     clojure.core/load-libs                     core.clj: 5774
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                      clojure.core/load-lib                     core.clj: 5717
                                      clojure.core/load-lib                     core.clj: 5736
                                   clojure.core/load-lib/fn                     core.clj: 5737
                                      clojure.core/load-one                     core.clj: 5697
                                                        ...
                                          clojure.core/load                     core.clj: 5876
                                          clojure.core/load                     core.clj: 5892
                                       clojure.core/load/fn                     core.clj: 5893
                                                        ...
                                endless-ships.core/eval3269                     core.clj:    1
                endless-ships.core/eval3269/loading--auto--                     core.clj:    1
                                                        ...
                                       clojure.core/require                     core.clj: 5796 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.core/load-libs                     core.clj: 5758
                                     clojure.core/load-libs                     core.clj: 5774
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                      clojure.core/load-lib                     core.clj: 5717
                                      clojure.core/load-lib                     core.clj: 5736
                                   clojure.core/load-lib/fn                     core.clj: 5737
                                      clojure.core/load-one                     core.clj: 5697
                                                        ...
                                          clojure.core/load                     core.clj: 5876
                                          clojure.core/load                     core.clj: 5892
                                       clojure.core/load/fn                     core.clj: 5893
                                                        ...
                             endless-ships.outfits/eval3275                  outfits.clj:    1
             endless-ships.outfits/eval3275/loading--auto--                  outfits.clj:    1
                                                        ...
                                       clojure.core/require                     core.clj: 5796 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.core/load-libs                     core.clj: 5758
                                     clojure.core/load-libs                     core.clj: 5774
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                      clojure.core/load-lib                     core.clj: 5717
                                      clojure.core/load-lib                     core.clj: 5736
                                   clojure.core/load-lib/fn                     core.clj: 5737
                                      clojure.core/load-one                     core.clj: 5697
                                                        ...
                                          clojure.core/load                     core.clj: 5876
                                          clojure.core/load                     core.clj: 5892
                                       clojure.core/load/fn                     core.clj: 5893
                                                        ...
                                    endless-ships.parser/fn                   parser.clj:   49
                                                        ...
                                        clojure.core/mapcat                     core.clj: 2674 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  641
                                           clojure.core/seq                     core.clj:  137
                                                        ...
                                        clojure.core/map/fn                     core.clj: 2646
                                 endless-ships.parser/fn/fn                   parser.clj:   51
                                 endless-ships.parser/parse                   parser.clj:   40
                                                        ...
                                     instaparse.core/parser                     core.clj:  171
                                     instaparse.core/parser                     core.clj:  255
                                                        ...
                                         clojure.core/slurp                     core.clj: 6657 (repeats 2 times)
                                         clojure.core/apply                     core.clj:  648
                                                        ...
                                     clojure.java.io/reader                       io.clj:   86
                                     clojure.java.io/reader                       io.clj:  102
                                       clojure.java.io/fn/G                       io.clj:   69
                                         clojure.java.io/fn                       io.clj:  288
java.lang.IllegalArgumentException: Cannot open <nil> as a Reader.
        clojure.lang.ExceptionInfo: Cannot open <nil> as a Reader.
    line: 47

[Zitchas]

A question regarding this error: Do you know what document it is referring to? Just trying to look at things to see if I can get any insight on it, but I can't even tell what file that line: 47 is in.

edit: In the build.boot file at L 47 there is a [] Should this be a location or something?

[7even]

edit: In the build.boot file at L 47 there is a [] Should this be a location or something?

No, it's just an empty parameters list for a function.

From the stack trace it seems like it cannot find the resources/parser.bnf file, can you please check if it exists on your machine? Maybe it was accidentally deleted.