Error with lombok activated on windows

[eliseucbrito]

Hello!

I am facing this error while using lombok support enabled

Language server error: jdtls

oneshot canceled
-- stderr--
Error opening zip file or JAR manifest missing : /C:\Users\Myuser\AppData\Local\Zed\extensions\work\java/lombok/lombok-1.18.36.jar

Lombok is in the same path specified in the log. I tried reinstalling it several times, but it still doesn't work.

Maybe because of the '/' at the beginning of the path?

[simuleite]

I've encountered the same problem, the difference is that I use the zed/java extension. Maybe it's not an extension-level issue.

I solved the problem by the following steps:

1. Manually download the jdtls from Eclipse.
   I downloaded an older version 1.35.0. Maybe you can use zed auto-downloaded version directly, but it occurs another error on my machine.

2. Edit your zed settings.json:

"lsp": {
  "jdtls": {
    "binary": {
      "path": "D:\\path\\to\\your\\jdtls\\bin\\jdtls.bat",
      // or Zed auto downloaded version in
      // %AppData%\\Local\\Zed\\extensions\\work\\java\\jdtls\\jdt-language-server-1.45.0-202502271238\\bin\\jdtls.bat
    }
 }
}

It works properly for me, but lombok still doesn't work.

[eliseucbrito]

I've encountered the same problem, the difference is that I use the zed/java extension. Maybe it's not an extension-level issue.

I solved the problem by the following steps:

1. Manually download the jdtls from [Eclipse](https://download.eclipse.org/jdtls/milestones/).
   I downloaded an older version `1.35.0`. Maybe you can use zed auto-downloaded version directly, but it occurs another error on my machine.

2. Edit your zed `settings.json`:

"lsp": {
"jdtls": {
"binary": {
"path": "D:\path\to\your\jdtls\bin\jdtls.bat",
// or Zed auto downloaded version in
// %AppData%\Local\Zed\extensions\work\java\jdtls\jdt-language-server-1.45.0-202502271238\bin\jdtls.bat
}
}
}

It works properly for me, but lombok still doesn't work.

When I got the error I did it this way too, but when I activate Lombok it triggers the error

I tried on Windows and Linux, same problem on both

[simuleite]

I enabled lombok by adding dirty code to jdtls.py. Now there are no more warnings in my Zed, @Data works fine.
Hope this helps you. Simply change the DEFAULT_LOMBOK_JAR to your lombok path. See more in lombok-jdtls

###############################################################################
# Copyright (c) 2022 Marc Schreiber and others.
#
# This program and the accompanying materials are made available under the
# terms of the Eclipse Public License 2.0 which is available at
# http://www.eclipse.org/legal/epl-2.0.
#
# SPDX-License-Identifier: EPL-2.0
#
# Contributors:
# Marc Schreiber - initial API and implementation
###############################################################################
import argparse
from hashlib import sha1
import os
import platform
import re
import subprocess
import sys
from pathlib import Path
import tempfile


# Lombok Path
DEFAULT_LOMBOK_JAR = r"D:\path\to\lombok\lombok-1.18.36.jar"
DEFAULT_LOMBOK_VERSION = "1.18.36"

def validate_lombok_config(lombok_jar):
    if not Path(lombok_jar).exists():
        print(f"Error: Lombok JAR not found at {lombok_jar}")
        sys.exit(1)


def get_java_executable(known_args):
	if known_args.java_executable is not None:
		java_executable = known_args.java_executable
	else:
		java_executable = 'java'

		if 'JAVA_HOME' in os.environ:
			ext = '.exe' if platform.system()  == 'Windows' else ''
			java_exec_to_test = Path(os.environ['JAVA_HOME']) / 'bin' / f'java{ext}'
			if java_exec_to_test.is_file():
				java_executable = java_exec_to_test.resolve()

	if not known_args.validate_java_version:
		return java_executable

	out = subprocess.check_output([java_executable, '-version'], stderr = subprocess.STDOUT, universal_newlines=True)

	matches = re.finditer(r"(?<=version\s\")(?P<major>\d+)(\.\d+\.\d+(_\d+)?)?", out)
	for match in matches:
		java_major_version = int(match.group("major"))

		if java_major_version < 17:
			raise Exception("jdtls requires at least Java 17")

		return java_executable

	raise Exception("Could not determine Java version")

def find_equinox_launcher(jdtls_base_directory):
	plugins_dir = jdtls_base_directory / "plugins"
	launchers = plugins_dir.glob('org.eclipse.equinox.launcher_*.jar')
	for launcher in launchers:
		return plugins_dir / launcher

	raise Exception("Cannot find equinox launcher")

def get_shared_config_path(jdtls_base_path):
	system = platform.system()

	if system in ['Linux', 'FreeBSD']:
		config_dir = 'config_linux'
	elif system == 'Darwin':
		config_dir = 'config_mac'
	elif system == 'Windows':
		config_dir = 'config_win'
	else:
		raise Exception("Unknown platform {} detected".format(system))

	return jdtls_base_path / config_dir

def main(args):
	cwd_name = os.path.basename(os.getcwd())
	jdtls_data_path = os.path.join(tempfile.gettempdir(), "jdtls-" + sha1(cwd_name.encode()).hexdigest())

	parser = argparse.ArgumentParser()

	parser.add_argument('--lombok-enabled', action='store_true', default=True, help='Enable Lombok support (default: true)')
	parser.add_argument('--lombok-jar', default=DEFAULT_LOMBOK_JAR, help=f'Path to Lombok JAR (default: {DEFAULT_LOMBOK_JAR})')
	parser.add_argument('--lombok-version', default=DEFAULT_LOMBOK_VERSION, help=f'Lombok version (default: {DEFAULT_LOMBOK_VERSION})')

	parser.add_argument('--validate-java-version', action='store_true', default=True)
	parser.add_argument('--no-validate-java-version', dest='validate_java_version', action='store_false')
	parser.add_argument("--java-executable", help="Path to java executable used to start runtime.")
	parser.add_argument("--jvm-arg", default=[], action="append", help="An additional JVM option (can be used multiple times. Note, use with equal sign. For example: --jvm-arg=-Dlog.level=ALL")
	parser.add_argument("-data", default=jdtls_data_path)
	
	known_args, args = parser.parse_known_args(args)

	validate_lombok_config(known_args.lombok_jar)
	lombok_jvm_args = [
	f"-javaagent:{known_args.lombok_jar}",
	f"-Xbootclasspath/a:{known_args.lombok_jar}",
	"-Dlog.level=ALL"
	]
	known_args.jvm_arg = lombok_jvm_args + known_args.jvm_arg

	if known_args.lombok_enabled:
		args = [
		f"--lombok-support-enabled={str(known_args.lombok_enabled).lower()}",
		f"--lombok-version={known_args.lombok_version}"
		] + args

		java_executable = get_java_executable(known_args)

		jdtls_base_path = Path(__file__).parent.parent
		shared_config_path = get_shared_config_path(jdtls_base_path)
		jar_path = find_equinox_launcher(jdtls_base_path)

		system = platform.system()
		exec_args = ["-Declipse.application=org.eclipse.jdt.ls.core.id1",
		"-Dosgi.bundles.defaultStartLevel=4",
		"-Declipse.product=org.eclipse.jdt.ls.core.product",
		"-Dosgi.checkConfiguration=true",
		"-Dosgi.sharedConfiguration.area=" + str(shared_config_path),
		"-Dosgi.sharedConfiguration.area.readOnly=true",
		"-Dosgi.configuration.cascaded=true",
		"-Xms1G",
		"--add-modules=ALL-SYSTEM",
		"--add-opens", "java.base/java.util=ALL-UNNAMED",
		"--add-opens", "java.base/java.lang=ALL-UNNAMED"] \
		+ known_args.jvm_arg \
		+ ["-jar", jar_path,
		"-data", known_args.data] \
		+ args

		if os.name == 'posix':
			os.execvp(java_executable, exec_args)
		else:
			subprocess.run([java_executable] + exec_args)

[ABckh]

Hi @eliseucbrito, sorry for such long reply, are you using jdtls downloaded by the extension itself? can you please attach your lsp config?