From dbaa1abeccf91c40b596eed9ee472ae3ef156218 Mon Sep 17 00:00:00 2001 From: Cheng Zhang Date: Fri, 28 Nov 2025 19:55:37 +0800 Subject: [PATCH 1/6] Fix typo in view_selection function call --- models/3dr1/captioner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/3dr1/captioner.py b/models/3dr1/captioner.py index 2ff93c4..0d5ced0 100644 --- a/models/3dr1/captioner.py +++ b/models/3dr1/captioner.py @@ -396,7 +396,7 @@ def _get_instruction_response(self, point_cloud_color = None if 'point_clouds_color' in inputs: point_cloud_color = inputs["point_clouds_color"][0] - selected_view_features, view_indices = self.view_selection(point_cloud, instruction_text, point_cloud_color)t) + selected_view_features, view_indices = self.view_selection(point_cloud, instruction_text, point_cloud_color) # Add view selection features to encoder hidden states # This is a simplified integration - in practice you might want more sophisticated fusion From c2ba96d1fdd0ff2172c87afcf142e37f83f32af4 Mon Sep 17 00:00:00 2001 From: Cheng Zhang Date: Fri, 28 Nov 2025 19:58:51 +0800 Subject: [PATCH 2/6] Update networkx version in README.md The old version of networkx will lead to error: ImportErrorImportError : ImportError: from fractions import gcdcannot import name 'gcd' from 'fractions' --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8fe9c79..7d4a83d 100644 --- a/README.md +++ b/README.md @@ -83,7 +83,7 @@ scipy cython plyfile 'trimesh>=2.35.39,<2.35.40' -'networkx>=2.2,<2.3' +networkx==3.2.1 'torch=2.0.1+cu118' google-generativeai peft>=0.7.0 From 5cd3e4130b5f1efc57dcd4099294ad0cd00fe852 Mon Sep 17 00:00:00 2001 From: Cheng Zhang Date: Fri, 28 Nov 2025 20:00:01 +0800 Subject: [PATCH 3/6] Add local rank argument to argument parser --- main.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/main.py b/main.py index 9a02755..91a9704 100644 --- a/main.py +++ b/main.py @@ -164,6 +164,7 @@ def make_args_parser(): ##### Distributed ##### parser.add_argument("--ngpus", default=1, type=int, help='number of gpus') parser.add_argument("--dist_url", default='tcp://localhost:12345', type=str) + parser.add_argument("--local-rank", type=int, default=0) args = parser.parse_args() args.use_height = not args.no_height @@ -421,4 +422,4 @@ def launch_distributed(args): set_start_method("spawn") except RuntimeError: pass - launch_distributed(args) \ No newline at end of file + launch_distributed(args) From de796be9fa603ed9a5d0fa4fc9ada349b85d2665 Mon Sep 17 00:00:00 2001 From: Cheng Zhang Date: Fri, 28 Nov 2025 20:00:33 +0800 Subject: [PATCH 4/6] Update train.generalist.sh --- script/train.generalist.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/script/train.generalist.sh b/script/train.generalist.sh index ed815de..cd0f862 100644 --- a/script/train.generalist.sh +++ b/script/train.generalist.sh @@ -13,7 +13,7 @@ python -m torch.distributed.launch \ --master_port=29500 \ main.py \ --checkpoint_dir ./checkpoints/fast_eval \ - --dataset scenecold \ + --dataset scenecold_dataset \ --vocab "qwen/Qwen2.5-7B" \ --qformer_vocab "bert-base-uncased" \ --captioner 3dr1 \ @@ -53,4 +53,4 @@ python -m torch.distributed.launch \ --eval_max_samples 1000 \ --eval_use_fp16 \ --eval_skip_metrics \ - --seed 42 \ No newline at end of file + --seed 42 From 1733a2ceb8944a74eb504eeea8bd2d175703b66b Mon Sep 17 00:00:00 2001 From: Cheng Zhang Date: Fri, 28 Nov 2025 20:01:16 +0800 Subject: [PATCH 5/6] Comment out use_rl_training argument Comment out the RL training flag in the function call. --- main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.py b/main.py index 91a9704..b8f83ff 100644 --- a/main.py +++ b/main.py @@ -250,7 +250,7 @@ def build_dataset(args): use_height=args.use_height, augment=True, use_additional_encoders=args.use_additional_encoders, - use_rl_training=args.use_rl_training, # Pass RL training flag + # use_rl_training=args.use_rl_training, # Pass RL training flag ) ) datasets['test'].append( From 471dd488c0a1c5f657d46bcfb3aae18d1e217f2e Mon Sep 17 00:00:00 2001 From: Cheng Zhang Date: Fri, 28 Nov 2025 20:02:38 +0800 Subject: [PATCH 6/6] Add numpy version requirement to README To avoid Error: `python cython_compile.py build_ext --inplace` --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 7d4a83d..9d5950e 100644 --- a/README.md +++ b/README.md @@ -82,6 +82,7 @@ h5py scipy cython plyfile +numpy==1.26.4 'trimesh>=2.35.39,<2.35.40' networkx==3.2.1 'torch=2.0.1+cu118'