From bbca13bc14f7e510cd8e1f196ea89d0c74e1079e Mon Sep 17 00:00:00 2001 From: Gioserden Date: Fri, 25 Aug 2017 19:16:30 -0400 Subject: [PATCH 1/3] Kata Bizz --- .../fundacionjala/coding/sergio/FizzBuzz.java | 42 +++++++++++++++++++ .../coding/sergio/FizzBuzzTest.java | 21 ++++++++++ 2 files changed, 63 insertions(+) create mode 100644 src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java create mode 100644 src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java diff --git a/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java b/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java new file mode 100644 index 0000000..4dfea0b --- /dev/null +++ b/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java @@ -0,0 +1,42 @@ +package org.fundacionjala.coding.sergio; + +/** + * Created by SergioNavarro on 8/25/2017. + */ +final class FizzBuzz { + /** + * + */ + private FizzBuzz() { + + } + + /** + * + * @param num input. + * @return return. + */ + static String[] resolve(int num) { + String[] result = new String[num]; + boolean normal = true; + for (int i = 1; i <= num; i++) { + normal = true; + if (i % 3 == 0 && i % 5 == 0) { + result[i - 1] = "FizzBuzz"; + normal = false; + } + if (i % 3 == 0) { + result[i - 1] = "Fizz"; + normal = false; + } + if (i % 5 == 0) { + result[i - 1] = "Buzz"; + normal = false; + } + if (normal) { + result[ i - 1] = Integer.toString(i); + } + } + return result; + } +} diff --git a/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java b/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java new file mode 100644 index 0000000..df01374 --- /dev/null +++ b/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java @@ -0,0 +1,21 @@ +package org.fundacionjala.coding.sergio; + +import org.junit.Test; + +import static org.junit.Assert.assertEquals; + +/** + * Created by SergioNavarro on 8/25/2017. + */ +public class FizzBuzzTest { + /** + * + */ + @Test + public void test01() { + int num = 4; + String[] input = {"1", "2", "Fizz", "4"}; + assertEquals(input, FizzBuzz.resolve(num)); + } + +} From 1c20fb64eec0d4314c341af9a93f2c02d85f4eae Mon Sep 17 00:00:00 2001 From: Gioserden Date: Wed, 30 Aug 2017 17:22:19 +0000 Subject: [PATCH 2/3] fixing code --- .../fundacionjala/coding/sergio/FizzBuzz.java | 13 +++---------- .../coding/sergio/FizzBuzzTest.java | 17 +++++++++++++++-- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java b/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java index 4dfea0b..8c0352e 100644 --- a/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java +++ b/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java @@ -3,20 +3,13 @@ /** * Created by SergioNavarro on 8/25/2017. */ -final class FizzBuzz { - /** - * - */ - private FizzBuzz() { - - } +public class FizzBuzz { /** - * * @param num input. * @return return. */ - static String[] resolve(int num) { + public String[] resolve(int num) { String[] result = new String[num]; boolean normal = true; for (int i = 1; i <= num; i++) { @@ -34,7 +27,7 @@ static String[] resolve(int num) { normal = false; } if (normal) { - result[ i - 1] = Integer.toString(i); + result[i - 1] = Integer.toString(i); } } return result; diff --git a/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java b/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java index df01374..49f7325 100644 --- a/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java +++ b/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java @@ -1,13 +1,26 @@ package org.fundacionjala.coding.sergio; +import org.junit.Before; import org.junit.Test; -import static org.junit.Assert.assertEquals; +import java.util.Arrays; + +import static junit.framework.TestCase.assertTrue; /** * Created by SergioNavarro on 8/25/2017. */ public class FizzBuzzTest { + private FizzBuzz fizzBuzz; + + /** + * Initial setup. + */ + @Before + public void setUp() { + fizzBuzz = new FizzBuzz(); + } + /** * */ @@ -15,7 +28,7 @@ public class FizzBuzzTest { public void test01() { int num = 4; String[] input = {"1", "2", "Fizz", "4"}; - assertEquals(input, FizzBuzz.resolve(num)); + assertTrue(Arrays.equals(input, fizzBuzz.resolve(num))); } } From 851bcc7859166c5e79a65e53bf232ab8eeb60c56 Mon Sep 17 00:00:00 2001 From: Gioserden Date: Wed, 30 Aug 2017 18:29:44 +0000 Subject: [PATCH 3/3] Adding Test Coverage --- src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java | 4 ++-- .../java/org/fundacionjala/coding/sergio/FizzBuzzTest.java | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java b/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java index 8c0352e..5a9c7cb 100644 --- a/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java +++ b/src/main/java/org/fundacionjala/coding/sergio/FizzBuzz.java @@ -18,11 +18,11 @@ public String[] resolve(int num) { result[i - 1] = "FizzBuzz"; normal = false; } - if (i % 3 == 0) { + if (i % 3 == 0 && normal) { result[i - 1] = "Fizz"; normal = false; } - if (i % 5 == 0) { + if (i % 5 == 0 && normal) { result[i - 1] = "Buzz"; normal = false; } diff --git a/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java b/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java index 49f7325..710f872 100644 --- a/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java +++ b/src/test/java/org/fundacionjala/coding/sergio/FizzBuzzTest.java @@ -26,8 +26,9 @@ public void setUp() { */ @Test public void test01() { - int num = 4; - String[] input = {"1", "2", "Fizz", "4"}; + int num = 15; + String[] input = {"1", "2", "Fizz", "4", "Buzz", "Fizz", "7", "8", "Fizz", "Buzz", "11", "Fizz", "13", "14", + "FizzBuzz"}; assertTrue(Arrays.equals(input, fizzBuzz.resolve(num))); }