From 80bd27dac109efe56eb765a4e41e949820188222 Mon Sep 17 00:00:00 2001 From: Rinostar Date: Sat, 16 May 2020 22:33:59 -0700 Subject: [PATCH 1/3] newman_conway --- lib/newman_conway.rb | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/lib/newman_conway.rb b/lib/newman_conway.rb index 4c985cd..9ca731f 100644 --- a/lib/newman_conway.rb +++ b/lib/newman_conway.rb @@ -1,7 +1,18 @@ +# Time complexity: O(n) +# Space Complexity: O(n) - -# Time complexity: ? -# Space Complexity: ? def newman_conway(num) - raise NotImplementedError, "newman_conway isn't implemented" -end \ No newline at end of file + raise ArgumentError if num < 1 + return "1" if num == 1 + return "1 1" if num == 2 + + s = [0, 1, 1] + result = "1 1" + + for i in 3..num + s[i] = s[s[i - 1]] + s[i - s[i - 1]] + result << " #{s[i]}" + end + + return result +end From baf8cee01f67d0ad876be38bf65695aae843ac86 Mon Sep 17 00:00:00 2001 From: Rinostar Date: Sat, 16 May 2020 23:27:09 -0700 Subject: [PATCH 2/3] max_subarray --- lib/max_subarray.rb | 23 +++++++++++++++++++++-- test/max_sub_array_test.rb | 2 +- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/lib/max_subarray.rb b/lib/max_subarray.rb index 5204edb..13055b1 100644 --- a/lib/max_subarray.rb +++ b/lib/max_subarray.rb @@ -1,8 +1,27 @@ - # Time Complexity: ? # Space Complexity: ? + def max_sub_array(nums) return 0 if nums == nil + return nil if nums == [] - raise NotImplementedError, "Method not implemented yet!" + curr_max = nums[0] + max_so_far = nums[0] + + i = 1 + until i == nums.length + if curr_max + nums[i] < nums[i] + curr_max = nums[i] + else + curr_max += nums[i] + end + + if curr_max > max_so_far + max_so_far = curr_max + end + + i += 1 + end + + return max_so_far end diff --git a/test/max_sub_array_test.rb b/test/max_sub_array_test.rb index 3253cdf..e27e1ca 100644 --- a/test/max_sub_array_test.rb +++ b/test/max_sub_array_test.rb @@ -1,6 +1,6 @@ require_relative "test_helper" -xdescribe "max subarray" do +describe "max subarray" do it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do # Arrange input = [-2,1,-3,4,-1,2,1,-5,4] From 24f92577102795b4074e48814db71cd347c9b4ea Mon Sep 17 00:00:00 2001 From: Rinostar Date: Sat, 16 May 2020 23:29:15 -0700 Subject: [PATCH 3/3] add runtime --- lib/max_subarray.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/max_subarray.rb b/lib/max_subarray.rb index 13055b1..eb31396 100644 --- a/lib/max_subarray.rb +++ b/lib/max_subarray.rb @@ -1,5 +1,5 @@ -# Time Complexity: ? -# Space Complexity: ? +# Time Complexity: O(n) +# Space Complexity: O(1) def max_sub_array(nums) return 0 if nums == nil