Zombies left behind

[ppietikainen]

Using a script.sh (so a window manager is started so fullscreen works) script.sh zombies get left behind. subprocess.call() or Popen().communicate() does the right thing i.e.

--- a/default.py
+++ b/default.py
@@ -148,10 +148,10 @@ def showSite(url, stopPlayback, kiosk, userAgent):
path = "/usr/bin/google-chrome"
if useCustomPath and os.path.exists(customPath):
fullUrl = getFullPath(customPath, url, kiosk, userAgent)

•        subprocess.Popen(fullUrl, shell=True)
  

•        subprocess.Popen(fullUrl, shell=True).communicate()
   elif os.path.exists(path):
       fullUrl = getFullPath(path, url, kiosk, userAgent)
  

•        subprocess.Popen(fullUrl, shell=True)
  

•        subprocess.Popen(fullUrl, shell=True).communicate()
   else:
  

probably wouldn't hurt the other platforms either...

[ppietikainen]

And even better, use a list not a string as argument and shell=False, current approach would probably do nasty things if you had ;rm -rf / as your url :)

[ppietikainen]

Mostly working refactored version at https://github.com/ppietikainen/plugin.program.chrome.launcher . Untested on non-linux, and a bit uncertain about the proper use of the xbmc api.