diff --git a/Framework/include/QualityControl/CheckInterface.h b/Framework/include/QualityControl/CheckInterface.h index ce19d1ff97..7d78fd4bc3 100644 --- a/Framework/include/QualityControl/CheckInterface.h +++ b/Framework/include/QualityControl/CheckInterface.h @@ -69,17 +69,6 @@ class CheckInterface : public core::UserCodeInterface /// then this should be reset here. virtual void reset(); // not fully abstract because we don't want to change all the existing subclasses - /// \brief Returns the name of the class that can be treated by this check. - /// - /// The name of the class returned by this method will be checked against the MonitorObject's encapsulated - /// object's class. If it is the same or a parent then the check will be applied. Therefore, this method - /// must return the highest class in the hierarchy that this check can use. - /// If the class does not override it, we return "TObject". - virtual std::string getAcceptedType(); - - bool isObjectCheckable(const std::shared_ptr mo); - bool isObjectCheckable(const core::MonitorObject* mo); - virtual void startOfActivity(const core::Activity& activity); // not fully abstract because we don't want to change all the existing subclasses virtual void endOfActivity(const core::Activity& activity); // not fully abstract because we don't want to change all the existing subclasses diff --git a/Framework/include/QualityControl/MonitorObject.h b/Framework/include/QualityControl/MonitorObject.h index f4bbc7e36d..c4663b7a60 100644 --- a/Framework/include/QualityControl/MonitorObject.h +++ b/Framework/include/QualityControl/MonitorObject.h @@ -117,6 +117,11 @@ class MonitorObject : public TObject /// \brief Get metadata value of given key, returns std::nullopt if none exists; std::optional getMetadata(const std::string& key); + /// \brief Check if the encapsulated object inherits from the given class name + /// \param className Name of the class to check inheritance from + /// \return true if the encapsulated object inherits from the given class, false otherwise + bool encapsulatedInheritsFrom(std::string_view className) const; + void Draw(Option_t* option) override; TObject* DrawClone(Option_t* option) const override; @@ -149,7 +154,7 @@ class MonitorObject : public TObject void releaseObject(); void cloneAndSetObject(const MonitorObject&); - ClassDefOverride(MonitorObject, 14); + ClassDefOverride(MonitorObject, 15); }; } // namespace o2::quality_control::core diff --git a/Framework/src/CheckInterface.cxx b/Framework/src/CheckInterface.cxx index 445d51e609..36d01d6a2f 100644 --- a/Framework/src/CheckInterface.cxx +++ b/Framework/src/CheckInterface.cxx @@ -18,28 +18,12 @@ #include "QualityControl/ReferenceUtils.h" #include "QualityControl/MonitorObject.h" -#include - using namespace std; using namespace o2::quality_control::core; namespace o2::quality_control::checker { -std::string CheckInterface::getAcceptedType() { return "TObject"; } - -bool CheckInterface::isObjectCheckable(const std::shared_ptr mo) -{ - return isObjectCheckable(mo.get()); -} - -bool CheckInterface::isObjectCheckable(const MonitorObject* mo) -{ - TObject* encapsulated = mo->getObject(); - - return encapsulated->IsA()->InheritsFrom(getAcceptedType().c_str()); -} - void CheckInterface::configure() { // noop, override it if you want. diff --git a/Framework/src/MonitorObject.cxx b/Framework/src/MonitorObject.cxx index 077b7f7807..bbc7b5c194 100644 --- a/Framework/src/MonitorObject.cxx +++ b/Framework/src/MonitorObject.cxx @@ -16,6 +16,7 @@ #include "QualityControl/MonitorObject.h" #include +#include #include "QualityControl/RepoPathUtils.h" #include "QualityControl/QcInfoLogger.h" @@ -162,6 +163,14 @@ std::optional MonitorObject::getMetadata(const std::string& key) return std::nullopt; } +bool MonitorObject::encapsulatedInheritsFrom(std::string_view className) const +{ + if (!mObject) { + return false; + } + return mObject->IsA()->InheritsFrom(className.data()); +} + std::string MonitorObject::getPath() const { return RepoPathUtils::getMoPath(this); diff --git a/Framework/test/testCheckInterface.cxx b/Framework/test/testCheckInterface.cxx index 61994da0f2..901e074423 100644 --- a/Framework/test/testCheckInterface.cxx +++ b/Framework/test/testCheckInterface.cxx @@ -62,11 +62,6 @@ class TestCheck : public checker::CheckInterface str->String().Append(" is beautiful now"); } - std::string getAcceptedType() override - { - return "TObjString"; - } - string mValidString; }; @@ -90,6 +85,4 @@ TEST_CASE("test_invoke_all_interface_methods") testCheck.beautify(mo); CHECK(reinterpret_cast(mo->getObject())->String() == "A string is beautiful now"); - - CHECK(testCheck.getAcceptedType() == "TObjString"); } diff --git a/Modules/Benchmark/include/Benchmark/AlwaysGoodCheck.h b/Modules/Benchmark/include/Benchmark/AlwaysGoodCheck.h index b181650751..82b061533c 100644 --- a/Modules/Benchmark/include/Benchmark/AlwaysGoodCheck.h +++ b/Modules/Benchmark/include/Benchmark/AlwaysGoodCheck.h @@ -37,8 +37,6 @@ class AlwaysGoodCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(AlwaysGoodCheck, 2); }; diff --git a/Modules/Benchmark/src/AlwaysGoodCheck.cxx b/Modules/Benchmark/src/AlwaysGoodCheck.cxx index 2207745440..ec70974d48 100644 --- a/Modules/Benchmark/src/AlwaysGoodCheck.cxx +++ b/Modules/Benchmark/src/AlwaysGoodCheck.cxx @@ -33,8 +33,6 @@ Quality AlwaysGoodCheck::check(std::map, Quality) { } diff --git a/Modules/CPV/include/CPV/PedestalCheck.h b/Modules/CPV/include/CPV/PedestalCheck.h index d25b70f8e6..fe36aa6111 100644 --- a/Modules/CPV/include/CPV/PedestalCheck.h +++ b/Modules/CPV/include/CPV/PedestalCheck.h @@ -37,7 +37,6 @@ class PedestalCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: int getRunNumberFromMO(std::shared_ptr mo); diff --git a/Modules/CPV/include/CPV/PhysicsCheck.h b/Modules/CPV/include/CPV/PhysicsCheck.h index 9cf2cb603e..b40a2bdb29 100644 --- a/Modules/CPV/include/CPV/PhysicsCheck.h +++ b/Modules/CPV/include/CPV/PhysicsCheck.h @@ -37,7 +37,6 @@ class PhysicsCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override { return "TH1"; } private: int getRunNumberFromMO(std::shared_ptr mo); diff --git a/Modules/CPV/src/PedestalCheck.cxx b/Modules/CPV/src/PedestalCheck.cxx index 8e02c4c38d..6a436013c4 100644 --- a/Modules/CPV/src/PedestalCheck.cxx +++ b/Modules/CPV/src/PedestalCheck.cxx @@ -279,9 +279,6 @@ Quality PedestalCheck::check(std::map mo, Quality checkResult) { return; // do noting for the time being. Maybe in the future we will do something sofisticated diff --git a/Modules/CTP/include/CTP/RawDataReaderCheck.h b/Modules/CTP/include/CTP/RawDataReaderCheck.h index b7a1fa1673..bcbf37f985 100644 --- a/Modules/CTP/include/CTP/RawDataReaderCheck.h +++ b/Modules/CTP/include/CTP/RawDataReaderCheck.h @@ -42,7 +42,6 @@ class RawDataReaderCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; void startOfActivity(const Activity& activity) override; const double_t nofOrbitsPerTF = o2::base::GRPGeomHelper::instance().getNHBFPerTF(); const double_t TimeTF = nofOrbitsPerTF * o2::constants::lhc::LHCOrbitMUS / 1e6; // in seconds diff --git a/Modules/CTP/src/RawDataReaderCheck.cxx b/Modules/CTP/src/RawDataReaderCheck.cxx index 83094a67a4..ea3353dbe4 100644 --- a/Modules/CTP/src/RawDataReaderCheck.cxx +++ b/Modules/CTP/src/RawDataReaderCheck.cxx @@ -201,8 +201,6 @@ float RawDataReaderCheck::setTextPosition(float iPos, std::shared_ptr ms return MessagePos; } -std::string RawDataReaderCheck::getAcceptedType() { return "TH1"; } - void RawDataReaderCheck::beautify(std::shared_ptr mo, Quality checkResult) { std::shared_ptr msg; diff --git a/Modules/Common/include/Common/CcdbInspectorCheck.h b/Modules/Common/include/Common/CcdbInspectorCheck.h index b6c4b15d81..0db9ac96ec 100644 --- a/Modules/Common/include/Common/CcdbInspectorCheck.h +++ b/Modules/Common/include/Common/CcdbInspectorCheck.h @@ -37,7 +37,6 @@ class CcdbInspectorCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; void reset() override; void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; diff --git a/Modules/Common/include/Common/EverIncreasingGraph.h b/Modules/Common/include/Common/EverIncreasingGraph.h index d8526e0f9e..985408ed1f 100644 --- a/Modules/Common/include/Common/EverIncreasingGraph.h +++ b/Modules/Common/include/Common/EverIncreasingGraph.h @@ -35,7 +35,6 @@ class EverIncreasingGraph : public o2::quality_control::checker::CheckInterface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override; private: ClassDefOverride(EverIncreasingGraph, 2); diff --git a/Modules/Common/include/Common/IncreasingEntries.h b/Modules/Common/include/Common/IncreasingEntries.h index 44ac51c6b2..63ea546dbd 100644 --- a/Modules/Common/include/Common/IncreasingEntries.h +++ b/Modules/Common/include/Common/IncreasingEntries.h @@ -39,7 +39,6 @@ class IncreasingEntries : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: std::map mLastEntries; // moName -> number of entries diff --git a/Modules/Common/include/Common/MeanIsAbove.h b/Modules/Common/include/Common/MeanIsAbove.h index 09ec66243c..cc1704ab3d 100644 --- a/Modules/Common/include/Common/MeanIsAbove.h +++ b/Modules/Common/include/Common/MeanIsAbove.h @@ -38,7 +38,6 @@ class MeanIsAbove : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override; private: float mThreshold = 0.0f; diff --git a/Modules/Common/include/Common/NonEmpty.h b/Modules/Common/include/Common/NonEmpty.h index 2e72e6810c..40b2d51190 100644 --- a/Modules/Common/include/Common/NonEmpty.h +++ b/Modules/Common/include/Common/NonEmpty.h @@ -35,8 +35,6 @@ class NonEmpty : public o2::quality_control::checker::CheckInterface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override; - ClassDefOverride(NonEmpty, 2); }; diff --git a/Modules/Common/include/Common/ReferenceComparatorCheck.h b/Modules/Common/include/Common/ReferenceComparatorCheck.h index f251b33c17..070e97e69f 100644 --- a/Modules/Common/include/Common/ReferenceComparatorCheck.h +++ b/Modules/Common/include/Common/ReferenceComparatorCheck.h @@ -45,8 +45,6 @@ class ReferenceComparatorCheck : public o2::quality_control::checker::CheckInter Quality check(std::map>* moMap) override; void reset() override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; diff --git a/Modules/Common/include/Common/TrendCheck.h b/Modules/Common/include/Common/TrendCheck.h index f52c1bad17..8edf62a622 100644 --- a/Modules/Common/include/Common/TrendCheck.h +++ b/Modules/Common/include/Common/TrendCheck.h @@ -48,8 +48,6 @@ class TrendCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; diff --git a/Modules/Common/src/CcdbInspectorCheck.cxx b/Modules/Common/src/CcdbInspectorCheck.cxx index 90f3fb25b9..4ceafd568f 100644 --- a/Modules/Common/src/CcdbInspectorCheck.cxx +++ b/Modules/Common/src/CcdbInspectorCheck.cxx @@ -71,8 +71,6 @@ Quality CcdbInspectorCheck::check(std::map mo, Quality checkResult) { } diff --git a/Modules/Common/src/EverIncreasingGraph.cxx b/Modules/Common/src/EverIncreasingGraph.cxx index 20b7ca9e1e..e08759b3fd 100644 --- a/Modules/Common/src/EverIncreasingGraph.cxx +++ b/Modules/Common/src/EverIncreasingGraph.cxx @@ -55,8 +55,6 @@ Quality EverIncreasingGraph::check(std::map mo, Quality checkResult) { ILOG(Info, Support) << "EverIncreasingGraph::Beautify" << ENDM; diff --git a/Modules/Common/src/IncreasingEntries.cxx b/Modules/Common/src/IncreasingEntries.cxx index 2bcd9eb220..c76167b8f0 100644 --- a/Modules/Common/src/IncreasingEntries.cxx +++ b/Modules/Common/src/IncreasingEntries.cxx @@ -93,8 +93,6 @@ Quality IncreasingEntries::check(std::map mo, Quality checkResult) { // only add the pavetext on the faulty plots diff --git a/Modules/Common/src/MeanIsAbove.cxx b/Modules/Common/src/MeanIsAbove.cxx index fe8922bf84..c59be784dc 100644 --- a/Modules/Common/src/MeanIsAbove.cxx +++ b/Modules/Common/src/MeanIsAbove.cxx @@ -38,8 +38,6 @@ void MeanIsAbove::configure() mThreshold = stof(mCustomParameters.at("meanThreshold")); } -std::string MeanIsAbove::getAcceptedType() { return "TH1"; } - Quality MeanIsAbove::check(std::map>* moMap) { auto mo = moMap->begin()->second; @@ -59,7 +57,7 @@ void MeanIsAbove::beautify(std::shared_ptr mo, Quality checkResul // A line is drawn at the level of the threshold. // Its colour depends on the quality. - if (!this->isObjectCheckable(mo)) { + if (!mo->encapsulatedInheritsFrom("TH1")) { ILOG(Error, Support) << "object not checkable" << ENDM; return; } diff --git a/Modules/Common/src/NonEmpty.cxx b/Modules/Common/src/NonEmpty.cxx index a8b0093afe..9e6bef0319 100644 --- a/Modules/Common/src/NonEmpty.cxx +++ b/Modules/Common/src/NonEmpty.cxx @@ -46,8 +46,6 @@ ClassImp(o2::quality_control_modules::common::NonEmpty) return result; } - std::string NonEmpty::getAcceptedType() { return "TH1"; } - void NonEmpty::beautify(std::shared_ptr /*mo*/, Quality /*checkResult*/) { // NOOP diff --git a/Modules/Common/src/ReferenceComparatorCheck.cxx b/Modules/Common/src/ReferenceComparatorCheck.cxx index c3eea7b6a4..d582403c44 100644 --- a/Modules/Common/src/ReferenceComparatorCheck.cxx +++ b/Modules/Common/src/ReferenceComparatorCheck.cxx @@ -211,8 +211,6 @@ void ReferenceComparatorCheck::reset() mQualityFlags.clear(); } -std::string ReferenceComparatorCheck::getAcceptedType() { return "TH1"; } - // return the ROOT color index associated to a give quality level static int getQualityColor(const Quality& q) { diff --git a/Modules/Common/src/TrendCheck.cxx b/Modules/Common/src/TrendCheck.cxx index 18af651995..68f30fe0fc 100644 --- a/Modules/Common/src/TrendCheck.cxx +++ b/Modules/Common/src/TrendCheck.cxx @@ -356,8 +356,6 @@ Quality TrendCheck::check(std::map>* return result; } -std::string TrendCheck::getAcceptedType() { return "TObject"; } - static void drawThresholds(TGraph* graph, const std::vector>>& thresholds, int lineColor, int lineStyle) { if (thresholds.empty()) { diff --git a/Modules/Common/test/testMeanIsAbove.cxx b/Modules/Common/test/testMeanIsAbove.cxx index fe4a5964e9..89c856fb28 100644 --- a/Modules/Common/test/testMeanIsAbove.cxx +++ b/Modules/Common/test/testMeanIsAbove.cxx @@ -71,7 +71,6 @@ BOOST_AUTO_TEST_CASE(test_types) std::map> moMap = { { "test", mo } }; MeanIsAbove check; - BOOST_TEST(!check.isObjectCheckable(mo)); Quality quality = check.check(&moMap); BOOST_CHECK_EQUAL(quality, Quality::Null); diff --git a/Modules/Common/test/testNonEmpty.cxx b/Modules/Common/test/testNonEmpty.cxx index c280ab52a8..ba2fdf5847 100644 --- a/Modules/Common/test/testNonEmpty.cxx +++ b/Modules/Common/test/testNonEmpty.cxx @@ -33,13 +33,6 @@ BOOST_AUTO_TEST_CASE(checkable) MonitorObject monitorObject(&histo, "task", "testClass", "TST"); monitorObject.setIsOwner(false); NonEmpty myCheck; - - BOOST_CHECK_EQUAL(myCheck.getAcceptedType(), "TH1"); - BOOST_CHECK_EQUAL(myCheck.isObjectCheckable(&monitorObject), true); - - TObject obj; - monitorObject.setObject(&obj); - BOOST_CHECK_EQUAL(myCheck.isObjectCheckable(&monitorObject), false); } BOOST_AUTO_TEST_CASE(beautify) diff --git a/Modules/EMCAL/include/EMCAL/CalibCheck.h b/Modules/EMCAL/include/EMCAL/CalibCheck.h index d3287f67e5..5c48fa091c 100644 --- a/Modules/EMCAL/include/EMCAL/CalibCheck.h +++ b/Modules/EMCAL/include/EMCAL/CalibCheck.h @@ -37,7 +37,6 @@ class CalibCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: /************************************************ diff --git a/Modules/EMCAL/include/EMCAL/CellAmpCheck.h b/Modules/EMCAL/include/EMCAL/CellAmpCheck.h index 38ab341676..e46acf4b29 100644 --- a/Modules/EMCAL/include/EMCAL/CellAmpCheck.h +++ b/Modules/EMCAL/include/EMCAL/CellAmpCheck.h @@ -41,7 +41,6 @@ class CellAmpCheck : public o2::quality_control::checker::CheckInterface check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: // /************************************************ diff --git a/Modules/EMCAL/include/EMCAL/CellCheck.h b/Modules/EMCAL/include/EMCAL/CellCheck.h index 0f9a2301dc..1463a538e7 100644 --- a/Modules/EMCAL/include/EMCAL/CellCheck.h +++ b/Modules/EMCAL/include/EMCAL/CellCheck.h @@ -36,8 +36,6 @@ class CellCheck : public o2::quality_control::checker::CheckInterface // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(CellCheck, 1); }; diff --git a/Modules/EMCAL/include/EMCAL/CellTimeCalibCheck.h b/Modules/EMCAL/include/EMCAL/CellTimeCalibCheck.h index ca567d3bb0..5a4eb91363 100644 --- a/Modules/EMCAL/include/EMCAL/CellTimeCalibCheck.h +++ b/Modules/EMCAL/include/EMCAL/CellTimeCalibCheck.h @@ -37,7 +37,6 @@ class CellTimeCalibCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: /************************************************ diff --git a/Modules/EMCAL/include/EMCAL/DigitCheck.h b/Modules/EMCAL/include/EMCAL/DigitCheck.h index 427482c4e7..9ff210e8c5 100644 --- a/Modules/EMCAL/include/EMCAL/DigitCheck.h +++ b/Modules/EMCAL/include/EMCAL/DigitCheck.h @@ -33,8 +33,6 @@ class DigitCheck : public o2::quality_control::checker::CheckInterface // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(DigitCheck, 2); }; diff --git a/Modules/EMCAL/include/EMCAL/NumPatchesPerFastORCheck.h b/Modules/EMCAL/include/EMCAL/NumPatchesPerFastORCheck.h index 02decc0ea1..6b71830b6d 100644 --- a/Modules/EMCAL/include/EMCAL/NumPatchesPerFastORCheck.h +++ b/Modules/EMCAL/include/EMCAL/NumPatchesPerFastORCheck.h @@ -41,8 +41,6 @@ class NumPatchesPerFastORCheck : public o2::quality_control::checker::CheckInter void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - struct FastORNoiseInfo { int mCounts; int mTRUIndex; diff --git a/Modules/EMCAL/include/EMCAL/NumPhysTriggCheck.h b/Modules/EMCAL/include/EMCAL/NumPhysTriggCheck.h index bec6093ea4..03b44abda8 100644 --- a/Modules/EMCAL/include/EMCAL/NumPhysTriggCheck.h +++ b/Modules/EMCAL/include/EMCAL/NumPhysTriggCheck.h @@ -46,10 +46,6 @@ class NumPhysTriggCheck : public o2::quality_control::checker::CheckInterface /// \param checkResult Quality status of this checker void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - /// \brief Accept only TH1 histograms as input - /// \return Name of the accepted object: TH1 - std::string getAcceptedType() override; - ClassDefOverride(NumPhysTriggCheck, 1); private: diff --git a/Modules/EMCAL/include/EMCAL/PayloadPerEventDDLCheck.h b/Modules/EMCAL/include/EMCAL/PayloadPerEventDDLCheck.h index 394f980738..79325018d1 100644 --- a/Modules/EMCAL/include/EMCAL/PayloadPerEventDDLCheck.h +++ b/Modules/EMCAL/include/EMCAL/PayloadPerEventDDLCheck.h @@ -38,7 +38,6 @@ class PayloadPerEventDDLCheck : public o2::quality_control::checker::CheckInterf void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: // /************************************************ diff --git a/Modules/EMCAL/include/EMCAL/PedestalChannelCheck.h b/Modules/EMCAL/include/EMCAL/PedestalChannelCheck.h index c62feb0333..89abfa1f33 100644 --- a/Modules/EMCAL/include/EMCAL/PedestalChannelCheck.h +++ b/Modules/EMCAL/include/EMCAL/PedestalChannelCheck.h @@ -37,7 +37,6 @@ class PedestalChannelCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: /************************************************ diff --git a/Modules/EMCAL/include/EMCAL/RawCheck.h b/Modules/EMCAL/include/EMCAL/RawCheck.h index 90e3366474..1d24d5ca29 100644 --- a/Modules/EMCAL/include/EMCAL/RawCheck.h +++ b/Modules/EMCAL/include/EMCAL/RawCheck.h @@ -42,7 +42,6 @@ class RawCheck final : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: Quality runPedestalCheck1D(TH1* adcdist, double minentries, double signalfraction) const; diff --git a/Modules/EMCAL/include/EMCAL/RawErrorCheck.h b/Modules/EMCAL/include/EMCAL/RawErrorCheck.h index 581e637257..7417cffb6e 100644 --- a/Modules/EMCAL/include/EMCAL/RawErrorCheck.h +++ b/Modules/EMCAL/include/EMCAL/RawErrorCheck.h @@ -56,10 +56,6 @@ class RawErrorCheck : public o2::quality_control::checker::CheckInterface /// \param checkResult Quality status of this checker void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - /// \brief Accept only TH2 histograms as input - /// \return Name of the accepted object: TH2 - std::string getAcceptedType() override; - ClassDefOverride(RawErrorCheck, 2); private: diff --git a/Modules/EMCAL/include/EMCAL/RawErrorCheckAll.h b/Modules/EMCAL/include/EMCAL/RawErrorCheckAll.h index ee789432fc..89283a7314 100644 --- a/Modules/EMCAL/include/EMCAL/RawErrorCheckAll.h +++ b/Modules/EMCAL/include/EMCAL/RawErrorCheckAll.h @@ -37,7 +37,6 @@ class RawErrorCheckAll : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: /************************************************ diff --git a/Modules/EMCAL/include/EMCAL/TrendGraphCheck.h b/Modules/EMCAL/include/EMCAL/TrendGraphCheck.h index c61a103bed..39e9f91ccf 100644 --- a/Modules/EMCAL/include/EMCAL/TrendGraphCheck.h +++ b/Modules/EMCAL/include/EMCAL/TrendGraphCheck.h @@ -39,7 +39,6 @@ class TrendGraphCheck : public o2::quality_control::checker::CheckInterface check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: /************************************************ diff --git a/Modules/EMCAL/src/CalibCheck.cxx b/Modules/EMCAL/src/CalibCheck.cxx index e2933ca952..c59708c402 100644 --- a/Modules/EMCAL/src/CalibCheck.cxx +++ b/Modules/EMCAL/src/CalibCheck.cxx @@ -372,8 +372,6 @@ Quality CalibCheck::check(std::map>* return result; } -std::string CalibCheck::getAcceptedType() { return "TH1"; } - void CalibCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName() == "MaskStatsAllHisto" || mo->getName() == "MaskStatsEMCALHisto" || mo->getName() == "MaskStatsDCALHisto") { diff --git a/Modules/EMCAL/src/CellAmpCheck.cxx b/Modules/EMCAL/src/CellAmpCheck.cxx index cc8a74d620..7bdef5ce1a 100644 --- a/Modules/EMCAL/src/CellAmpCheck.cxx +++ b/Modules/EMCAL/src/CellAmpCheck.cxx @@ -77,8 +77,6 @@ Quality CellAmpCheck::check( return result; } -std::string CellAmpCheck::getAcceptedType() { return "TH1"; } - void CellAmpCheck::beautify(std::shared_ptr mo, Quality checkResult) { diff --git a/Modules/EMCAL/src/CellCheck.cxx b/Modules/EMCAL/src/CellCheck.cxx index 12b6673ff3..241f4ea977 100644 --- a/Modules/EMCAL/src/CellCheck.cxx +++ b/Modules/EMCAL/src/CellCheck.cxx @@ -97,8 +97,6 @@ Quality CellCheck::check(std::map>* return result; } -std::string CellCheck::getAcceptedType() { return "TH1"; } - void CellCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName().find("Time") != std::string::npos) { diff --git a/Modules/EMCAL/src/CellTimeCalibCheck.cxx b/Modules/EMCAL/src/CellTimeCalibCheck.cxx index 5f07173e11..a2d5041cc1 100644 --- a/Modules/EMCAL/src/CellTimeCalibCheck.cxx +++ b/Modules/EMCAL/src/CellTimeCalibCheck.cxx @@ -76,8 +76,6 @@ Quality CellTimeCalibCheck::check(std::map mo, Quality checkResult) { if (mo->getName() == "cellTimeCalib_PHYS") { diff --git a/Modules/EMCAL/src/DigitCheck.cxx b/Modules/EMCAL/src/DigitCheck.cxx index 55e7aef7e3..b770dab03d 100644 --- a/Modules/EMCAL/src/DigitCheck.cxx +++ b/Modules/EMCAL/src/DigitCheck.cxx @@ -94,8 +94,6 @@ Quality DigitCheck::check(std::map>* return result; } -std::string DigitCheck::getAcceptedType() { return "TH1"; } - void DigitCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName().find("Time") != std::string::npos) { diff --git a/Modules/EMCAL/src/NumPatchesPerFastORCheck.cxx b/Modules/EMCAL/src/NumPatchesPerFastORCheck.cxx index 26b3f7f9fc..86f9a8a690 100644 --- a/Modules/EMCAL/src/NumPatchesPerFastORCheck.cxx +++ b/Modules/EMCAL/src/NumPatchesPerFastORCheck.cxx @@ -236,8 +236,6 @@ Quality NumPatchesPerFastORCheck::check(std::map mo, Quality checkResult) { if (mo->getName() == "NumberOfPatchesWithFastOR") { diff --git a/Modules/EMCAL/src/NumPhysTriggCheck.cxx b/Modules/EMCAL/src/NumPhysTriggCheck.cxx index 84022e088b..428001f544 100644 --- a/Modules/EMCAL/src/NumPhysTriggCheck.cxx +++ b/Modules/EMCAL/src/NumPhysTriggCheck.cxx @@ -81,8 +81,6 @@ Quality NumPhysTriggCheck::check(std::map mo, Quality checkResult) { if (mo->getName().find("NPhysTriggersTFSlice") != std::string::npos) { diff --git a/Modules/EMCAL/src/PayloadPerEventDDLCheck.cxx b/Modules/EMCAL/src/PayloadPerEventDDLCheck.cxx index 8f0efeb4ea..853d6bdf15 100644 --- a/Modules/EMCAL/src/PayloadPerEventDDLCheck.cxx +++ b/Modules/EMCAL/src/PayloadPerEventDDLCheck.cxx @@ -77,8 +77,6 @@ Quality PayloadPerEventDDLCheck::check(std::map mo, Quality checkResult) { if (mo->getName() == "PayloadSizePerDDL") { diff --git a/Modules/EMCAL/src/PedestalChannelCheck.cxx b/Modules/EMCAL/src/PedestalChannelCheck.cxx index 83e350e351..a9c96be80a 100644 --- a/Modules/EMCAL/src/PedestalChannelCheck.cxx +++ b/Modules/EMCAL/src/PedestalChannelCheck.cxx @@ -164,8 +164,6 @@ Quality PedestalChannelCheck::check(std::map mo, Quality checkResult) { std::array channelHists = { { "mPedestalChannelFECHG", "mPedestalChannelFECLG", "mPedestalChannelLEDMONHG", "mPedestalChannelLEDMONLG" } }; diff --git a/Modules/EMCAL/src/RawCheck.cxx b/Modules/EMCAL/src/RawCheck.cxx index b872db814a..809762685a 100644 --- a/Modules/EMCAL/src/RawCheck.cxx +++ b/Modules/EMCAL/src/RawCheck.cxx @@ -226,8 +226,6 @@ Quality RawCheck::check(std::map>* m return result; } -std::string RawCheck::getAcceptedType() { return "TH1"; } - void RawCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName().find("Error") != std::string::npos) { diff --git a/Modules/EMCAL/src/RawErrorCheck.cxx b/Modules/EMCAL/src/RawErrorCheck.cxx index af70213cf6..25910aad31 100644 --- a/Modules/EMCAL/src/RawErrorCheck.cxx +++ b/Modules/EMCAL/src/RawErrorCheck.cxx @@ -355,8 +355,6 @@ Quality RawErrorCheck::check(std::map mo, Quality checkResult) { auto* h = dynamic_cast(mo->getObject()); diff --git a/Modules/EMCAL/src/RawErrorCheckAll.cxx b/Modules/EMCAL/src/RawErrorCheckAll.cxx index 704ba41b7b..7367a8fe29 100644 --- a/Modules/EMCAL/src/RawErrorCheckAll.cxx +++ b/Modules/EMCAL/src/RawErrorCheckAll.cxx @@ -90,8 +90,6 @@ Quality RawErrorCheckAll::check(std::map mo, Quality checkResult) { if (mo->getName() == "TrendRawDataError") { diff --git a/Modules/EMCAL/src/TrendGraphCheck.cxx b/Modules/EMCAL/src/TrendGraphCheck.cxx index 263f49f161..302e88c1d1 100644 --- a/Modules/EMCAL/src/TrendGraphCheck.cxx +++ b/Modules/EMCAL/src/TrendGraphCheck.cxx @@ -117,8 +117,6 @@ Quality TrendGraphCheck::check( return result; } -std::string TrendGraphCheck::getAcceptedType() { return "TGraph"; } - void TrendGraphCheck::beautify(std::shared_ptr mo, Quality checkResult) { diff --git a/Modules/Example/include/Example/FakeCheck.h b/Modules/Example/include/Example/FakeCheck.h index f812573938..28c1fd9c73 100644 --- a/Modules/Example/include/Example/FakeCheck.h +++ b/Modules/Example/include/Example/FakeCheck.h @@ -36,8 +36,6 @@ class FakeCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(FakeCheck, 1); }; diff --git a/Modules/Example/src/FakeCheck.cxx b/Modules/Example/src/FakeCheck.cxx index e764045f5f..9bd5bbe34b 100644 --- a/Modules/Example/src/FakeCheck.cxx +++ b/Modules/Example/src/FakeCheck.cxx @@ -34,8 +34,6 @@ ClassImp(o2::quality_control_modules::example::FakeCheck) return result; } - std::string FakeCheck::getAcceptedType() { return "TH1"; } - void FakeCheck::beautify(std::shared_ptr /*mo*/, Quality /*checkResult*/) { // NOOP diff --git a/Modules/FIT/FDD/include/FDD/CFDEffCheck.h b/Modules/FIT/FDD/include/FDD/CFDEffCheck.h index e00e7c71d1..de84e59dd1 100644 --- a/Modules/FIT/FDD/include/FDD/CFDEffCheck.h +++ b/Modules/FIT/FDD/include/FDD/CFDEffCheck.h @@ -40,8 +40,6 @@ class CFDEffCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(CFDEffCheck, 2); private: diff --git a/Modules/FIT/FDD/include/FDD/GenericCheck.h b/Modules/FIT/FDD/include/FDD/GenericCheck.h index 871de7d928..c60f9e638e 100644 --- a/Modules/FIT/FDD/include/FDD/GenericCheck.h +++ b/Modules/FIT/FDD/include/FDD/GenericCheck.h @@ -124,8 +124,6 @@ class GenericCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(GenericCheck, 2); private: diff --git a/Modules/FIT/FDD/include/FDD/OutOfBunchCollCheck.h b/Modules/FIT/FDD/include/FDD/OutOfBunchCollCheck.h index 3f932ffac2..6550ee45c1 100644 --- a/Modules/FIT/FDD/include/FDD/OutOfBunchCollCheck.h +++ b/Modules/FIT/FDD/include/FDD/OutOfBunchCollCheck.h @@ -37,8 +37,6 @@ class OutOfBunchCollCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - constexpr static std::size_t sBCperOrbit = o2::constants::lhc::LHCMaxBunches; ClassDefOverride(OutOfBunchCollCheck, 2); diff --git a/Modules/FIT/FDD/include/FDD/OutOfBunchCollFeeModulesCheck.h b/Modules/FIT/FDD/include/FDD/OutOfBunchCollFeeModulesCheck.h index 7f5b5f04bd..8a66d1bcba 100644 --- a/Modules/FIT/FDD/include/FDD/OutOfBunchCollFeeModulesCheck.h +++ b/Modules/FIT/FDD/include/FDD/OutOfBunchCollFeeModulesCheck.h @@ -31,8 +31,6 @@ class OutOfBunchCollFeeModulesCheck : public o2::quality_control::checker::Check void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(OutOfBunchCollFeeModulesCheck, 1); private: diff --git a/Modules/FIT/FDD/include/FDD/TriggersSwVsTcmCheck.h b/Modules/FIT/FDD/include/FDD/TriggersSwVsTcmCheck.h index 2808bdcb41..1f8b59e3c6 100644 --- a/Modules/FIT/FDD/include/FDD/TriggersSwVsTcmCheck.h +++ b/Modules/FIT/FDD/include/FDD/TriggersSwVsTcmCheck.h @@ -31,8 +31,6 @@ class TriggersSwVsTcmCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(TriggersSwVsTcmCheck, 2); private: diff --git a/Modules/FIT/FDD/src/CFDEffCheck.cxx b/Modules/FIT/FDD/src/CFDEffCheck.cxx index 666916d769..9b74665f1e 100644 --- a/Modules/FIT/FDD/src/CFDEffCheck.cxx +++ b/Modules/FIT/FDD/src/CFDEffCheck.cxx @@ -146,8 +146,6 @@ Quality CFDEffCheck::check(std::map> return result; } -std::string CFDEffCheck::getAcceptedType() { return "TH1"; } - void CFDEffCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName() == "CFD_efficiency") { diff --git a/Modules/FIT/FDD/src/GenericCheck.cxx b/Modules/FIT/FDD/src/GenericCheck.cxx index 4717095fe4..26d67bc695 100644 --- a/Modules/FIT/FDD/src/GenericCheck.cxx +++ b/Modules/FIT/FDD/src/GenericCheck.cxx @@ -262,8 +262,6 @@ Quality GenericCheck::check(std::map return result; } -std::string GenericCheck::getAcceptedType() { return "TObject"; } - void GenericCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (!mo) { diff --git a/Modules/FIT/FDD/src/OutOfBunchCollCheck.cxx b/Modules/FIT/FDD/src/OutOfBunchCollCheck.cxx index 111acfc9bb..9b377f2f97 100644 --- a/Modules/FIT/FDD/src/OutOfBunchCollCheck.cxx +++ b/Modules/FIT/FDD/src/OutOfBunchCollCheck.cxx @@ -128,8 +128,6 @@ Quality OutOfBunchCollCheck::check(std::map mo, Quality checkResult) { auto* h = dynamic_cast(mo->getObject()); diff --git a/Modules/FIT/FDD/src/OutOfBunchCollFeeModulesCheck.cxx b/Modules/FIT/FDD/src/OutOfBunchCollFeeModulesCheck.cxx index 84f998d355..4e924f6e31 100644 --- a/Modules/FIT/FDD/src/OutOfBunchCollFeeModulesCheck.cxx +++ b/Modules/FIT/FDD/src/OutOfBunchCollFeeModulesCheck.cxx @@ -120,8 +120,6 @@ Quality OutOfBunchCollFeeModulesCheck::check(std::map mo, Quality checkResult) { if (mo->getName().find("OutOfBunchColl_BCvsFeeModules") != std::string::npos) { diff --git a/Modules/FIT/FDD/src/TriggersSwVsTcmCheck.cxx b/Modules/FIT/FDD/src/TriggersSwVsTcmCheck.cxx index 4fcb589fe3..da8b9045a5 100644 --- a/Modules/FIT/FDD/src/TriggersSwVsTcmCheck.cxx +++ b/Modules/FIT/FDD/src/TriggersSwVsTcmCheck.cxx @@ -103,8 +103,6 @@ Quality TriggersSwVsTcmCheck::check(std::map mo, Quality checkResult) { if (!mo) { diff --git a/Modules/FIT/FIT/include/FIT/LevelCheck.h b/Modules/FIT/FIT/include/FIT/LevelCheck.h index 92d18e4261..423efd8edf 100644 --- a/Modules/FIT/FIT/include/FIT/LevelCheck.h +++ b/Modules/FIT/FIT/include/FIT/LevelCheck.h @@ -35,7 +35,6 @@ class LevelCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; void startOfActivity(const Activity& activity) override; private: diff --git a/Modules/FIT/FIT/include/FIT/MIPCheck.h b/Modules/FIT/FIT/include/FIT/MIPCheck.h index de2e4950d6..b5f5a99c23 100644 --- a/Modules/FIT/FIT/include/FIT/MIPCheck.h +++ b/Modules/FIT/FIT/include/FIT/MIPCheck.h @@ -34,7 +34,6 @@ class MIPCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; void startOfActivity(const Activity& activity) override; private: diff --git a/Modules/FIT/FIT/src/LevelCheck.cxx b/Modules/FIT/FIT/src/LevelCheck.cxx index e92206c276..469b0deaa1 100644 --- a/Modules/FIT/FIT/src/LevelCheck.cxx +++ b/Modules/FIT/FIT/src/LevelCheck.cxx @@ -204,8 +204,6 @@ Quality LevelCheck::check(std::map>* return result; } -std::string LevelCheck::getAcceptedType() { return "TH1"; } - void LevelCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName() == mNameObjectToCheck) { diff --git a/Modules/FIT/FIT/src/MIPCheck.cxx b/Modules/FIT/FIT/src/MIPCheck.cxx index 240d8563d0..5983b97dd1 100644 --- a/Modules/FIT/FIT/src/MIPCheck.cxx +++ b/Modules/FIT/FIT/src/MIPCheck.cxx @@ -242,12 +242,6 @@ Quality MIPCheck::check(std::map>* m return result; } -std::string MIPCheck::getAcceptedType() -{ - // This method is a remnant of early interface prototype and will be removed in the scope of ticket QC-373 - return "TH1"; -} - void MIPCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName() == mNameObjectToCheck) { diff --git a/Modules/FIT/FT0/include/FT0/CFDEffCheck.h b/Modules/FIT/FT0/include/FT0/CFDEffCheck.h index 87e9a1bac2..ab92c0caa1 100644 --- a/Modules/FIT/FT0/include/FT0/CFDEffCheck.h +++ b/Modules/FIT/FT0/include/FT0/CFDEffCheck.h @@ -39,8 +39,6 @@ class CFDEffCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(CFDEffCheck, 2); private: diff --git a/Modules/FIT/FT0/include/FT0/FractionCheck.h b/Modules/FIT/FT0/include/FT0/FractionCheck.h index 66a04c6ec2..71608b088a 100644 --- a/Modules/FIT/FT0/include/FT0/FractionCheck.h +++ b/Modules/FIT/FT0/include/FT0/FractionCheck.h @@ -40,7 +40,6 @@ class FractionCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: template >* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(GenericCheck, 2); private: diff --git a/Modules/FIT/FT0/include/FT0/MergedTreeCheck.h b/Modules/FIT/FT0/include/FT0/MergedTreeCheck.h index 118f8b33e3..ecae98349e 100644 --- a/Modules/FIT/FT0/include/FT0/MergedTreeCheck.h +++ b/Modules/FIT/FT0/include/FT0/MergedTreeCheck.h @@ -34,8 +34,6 @@ class MergedTreeCheck : public o2::quality_control::checker::CheckInterface // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(MergedTreeCheck, 2); }; diff --git a/Modules/FIT/FT0/include/FT0/OutOfBunchCollCheck.h b/Modules/FIT/FT0/include/FT0/OutOfBunchCollCheck.h index 459dd6c03b..4feae605c3 100644 --- a/Modules/FIT/FT0/include/FT0/OutOfBunchCollCheck.h +++ b/Modules/FIT/FT0/include/FT0/OutOfBunchCollCheck.h @@ -37,8 +37,6 @@ class OutOfBunchCollCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - constexpr static std::size_t sBCperOrbit = o2::constants::lhc::LHCMaxBunches; ClassDefOverride(OutOfBunchCollCheck, 2); diff --git a/Modules/FIT/FT0/src/CFDEffCheck.cxx b/Modules/FIT/FT0/src/CFDEffCheck.cxx index be178837df..dbafb7bfda 100644 --- a/Modules/FIT/FT0/src/CFDEffCheck.cxx +++ b/Modules/FIT/FT0/src/CFDEffCheck.cxx @@ -150,8 +150,6 @@ Quality CFDEffCheck::check(std::map> return result; } -std::string CFDEffCheck::getAcceptedType() { return "TH1"; } - void CFDEffCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName() == "CFD_efficiency") { diff --git a/Modules/FIT/FT0/src/FractionCheck.cxx b/Modules/FIT/FT0/src/FractionCheck.cxx index 9f1e129951..61c47088c0 100644 --- a/Modules/FIT/FT0/src/FractionCheck.cxx +++ b/Modules/FIT/FT0/src/FractionCheck.cxx @@ -117,8 +117,6 @@ Quality FractionCheck::check(std::map mo, Quality checkResult) { if (mo->getName() == mNameObjectToCheck) { diff --git a/Modules/FIT/FT0/src/GenericCheck.cxx b/Modules/FIT/FT0/src/GenericCheck.cxx index 4688dc0e27..15b60482c0 100644 --- a/Modules/FIT/FT0/src/GenericCheck.cxx +++ b/Modules/FIT/FT0/src/GenericCheck.cxx @@ -187,8 +187,6 @@ Quality GenericCheck::check(std::map return result; } -std::string GenericCheck::getAcceptedType() { return "TObject"; } - void GenericCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (!mo) { diff --git a/Modules/FIT/FT0/src/MergedTreeCheck.cxx b/Modules/FIT/FT0/src/MergedTreeCheck.cxx index f7d1f132e5..55834f7e10 100644 --- a/Modules/FIT/FT0/src/MergedTreeCheck.cxx +++ b/Modules/FIT/FT0/src/MergedTreeCheck.cxx @@ -56,8 +56,6 @@ Quality MergedTreeCheck::check(std::map, Quality) { } diff --git a/Modules/FIT/FT0/src/OutOfBunchCollCheck.cxx b/Modules/FIT/FT0/src/OutOfBunchCollCheck.cxx index 0ba6af50ec..6aeacb8958 100644 --- a/Modules/FIT/FT0/src/OutOfBunchCollCheck.cxx +++ b/Modules/FIT/FT0/src/OutOfBunchCollCheck.cxx @@ -128,8 +128,6 @@ Quality OutOfBunchCollCheck::check(std::map mo, Quality checkResult) { auto* h = dynamic_cast(mo->getObject()); diff --git a/Modules/FIT/FV0/include/FV0/CFDEffCheck.h b/Modules/FIT/FV0/include/FV0/CFDEffCheck.h index 470e90a3eb..b7a794a9d7 100644 --- a/Modules/FIT/FV0/include/FV0/CFDEffCheck.h +++ b/Modules/FIT/FV0/include/FV0/CFDEffCheck.h @@ -39,8 +39,6 @@ class CFDEffCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(CFDEffCheck, 2); private: diff --git a/Modules/FIT/FV0/include/FV0/GenericCheck.h b/Modules/FIT/FV0/include/FV0/GenericCheck.h index ea265cc25b..00e3a131e0 100644 --- a/Modules/FIT/FV0/include/FV0/GenericCheck.h +++ b/Modules/FIT/FV0/include/FV0/GenericCheck.h @@ -128,8 +128,6 @@ class GenericCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(GenericCheck, 2); private: diff --git a/Modules/FIT/FV0/include/FV0/OutOfBunchCollCheck.h b/Modules/FIT/FV0/include/FV0/OutOfBunchCollCheck.h index 853d05a5e6..46787b2985 100644 --- a/Modules/FIT/FV0/include/FV0/OutOfBunchCollCheck.h +++ b/Modules/FIT/FV0/include/FV0/OutOfBunchCollCheck.h @@ -37,8 +37,6 @@ class OutOfBunchCollCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - constexpr static std::size_t sBCperOrbit = o2::constants::lhc::LHCMaxBunches; ClassDefOverride(OutOfBunchCollCheck, 2); diff --git a/Modules/FIT/FV0/include/FV0/OutOfBunchCollFeeModulesCheck.h b/Modules/FIT/FV0/include/FV0/OutOfBunchCollFeeModulesCheck.h index 3d35dd3150..e2c1c4eba8 100644 --- a/Modules/FIT/FV0/include/FV0/OutOfBunchCollFeeModulesCheck.h +++ b/Modules/FIT/FV0/include/FV0/OutOfBunchCollFeeModulesCheck.h @@ -36,8 +36,6 @@ class OutOfBunchCollFeeModulesCheck : public o2::quality_control::checker::Check void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(OutOfBunchCollFeeModulesCheck, 2); private: diff --git a/Modules/FIT/FV0/include/FV0/TriggersSwVsTcmCheck.h b/Modules/FIT/FV0/include/FV0/TriggersSwVsTcmCheck.h index beba45d950..4ceb0a70bd 100644 --- a/Modules/FIT/FV0/include/FV0/TriggersSwVsTcmCheck.h +++ b/Modules/FIT/FV0/include/FV0/TriggersSwVsTcmCheck.h @@ -35,8 +35,6 @@ class TriggersSwVsTcmCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(TriggersSwVsTcmCheck, 2); private: diff --git a/Modules/FIT/FV0/src/CFDEffCheck.cxx b/Modules/FIT/FV0/src/CFDEffCheck.cxx index 020f148c22..04a986d3b0 100644 --- a/Modules/FIT/FV0/src/CFDEffCheck.cxx +++ b/Modules/FIT/FV0/src/CFDEffCheck.cxx @@ -145,8 +145,6 @@ Quality CFDEffCheck::check(std::map> return result; } -std::string CFDEffCheck::getAcceptedType() { return "TH1"; } - void CFDEffCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName() == "CFD_efficiency") { diff --git a/Modules/FIT/FV0/src/GenericCheck.cxx b/Modules/FIT/FV0/src/GenericCheck.cxx index ce9109cd8e..596771c446 100644 --- a/Modules/FIT/FV0/src/GenericCheck.cxx +++ b/Modules/FIT/FV0/src/GenericCheck.cxx @@ -265,8 +265,6 @@ Quality GenericCheck::check(std::map return result; } -std::string GenericCheck::getAcceptedType() { return "TObject"; } - void GenericCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (!mo) { diff --git a/Modules/FIT/FV0/src/OutOfBunchCollCheck.cxx b/Modules/FIT/FV0/src/OutOfBunchCollCheck.cxx index 1e0ee594bb..d0e439858e 100644 --- a/Modules/FIT/FV0/src/OutOfBunchCollCheck.cxx +++ b/Modules/FIT/FV0/src/OutOfBunchCollCheck.cxx @@ -130,8 +130,6 @@ Quality OutOfBunchCollCheck::check(std::map mo, Quality checkResult) { auto* h = dynamic_cast(mo->getObject()); diff --git a/Modules/FIT/FV0/src/OutOfBunchCollFeeModulesCheck.cxx b/Modules/FIT/FV0/src/OutOfBunchCollFeeModulesCheck.cxx index 72a80f1be8..9db128ace4 100644 --- a/Modules/FIT/FV0/src/OutOfBunchCollFeeModulesCheck.cxx +++ b/Modules/FIT/FV0/src/OutOfBunchCollFeeModulesCheck.cxx @@ -125,8 +125,6 @@ Quality OutOfBunchCollFeeModulesCheck::check(std::map mo, Quality checkResult) { if (mo->getName().find("OutOfBunchColl_BCvsFeeModules") != std::string::npos) { diff --git a/Modules/FIT/FV0/src/TriggersSwVsTcmCheck.cxx b/Modules/FIT/FV0/src/TriggersSwVsTcmCheck.cxx index 3ba476d320..fb5e5f14b8 100644 --- a/Modules/FIT/FV0/src/TriggersSwVsTcmCheck.cxx +++ b/Modules/FIT/FV0/src/TriggersSwVsTcmCheck.cxx @@ -103,8 +103,6 @@ Quality TriggersSwVsTcmCheck::check(std::map mo, Quality checkResult) { if (!mo) { diff --git a/Modules/GLO/include/GLO/MeanVertexCheck.h b/Modules/GLO/include/GLO/MeanVertexCheck.h index 9e337a8aa5..d8d955207b 100644 --- a/Modules/GLO/include/GLO/MeanVertexCheck.h +++ b/Modules/GLO/include/GLO/MeanVertexCheck.h @@ -41,8 +41,6 @@ class MeanVertexCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; diff --git a/Modules/GLO/src/MeanVertexCheck.cxx b/Modules/GLO/src/MeanVertexCheck.cxx index 913d1c7c42..7742d3928e 100644 --- a/Modules/GLO/src/MeanVertexCheck.cxx +++ b/Modules/GLO/src/MeanVertexCheck.cxx @@ -166,8 +166,6 @@ Quality MeanVertexCheck::check(std::map mo, Quality checkResult) { auto moName = mo->getName(); diff --git a/Modules/HMPID/include/HMPID/HmpidRawChecks.h b/Modules/HMPID/include/HMPID/HmpidRawChecks.h index c318714c8e..7883662c18 100644 --- a/Modules/HMPID/include/HMPID/HmpidRawChecks.h +++ b/Modules/HMPID/include/HMPID/HmpidRawChecks.h @@ -48,7 +48,6 @@ class HmpidRawChecks : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - // std::string getAcceptedType() override; private: std::array check_hHmpBigMap(TProfile2D* h); // <-- Dimensione da chiarire diff --git a/Modules/ITS/include/ITS/ITSClusterCheck.h b/Modules/ITS/include/ITS/ITSClusterCheck.h index 15767b6a88..ea06e6f779 100644 --- a/Modules/ITS/include/ITS/ITSClusterCheck.h +++ b/Modules/ITS/include/ITS/ITSClusterCheck.h @@ -42,7 +42,6 @@ class ITSClusterCheck : public o2::quality_control::checker::CheckInterface // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: ClassDefOverride(ITSClusterCheck, 2); diff --git a/Modules/ITS/include/ITS/ITSFeeCheck.h b/Modules/ITS/include/ITS/ITSFeeCheck.h index 35b46a95ab..b6b676719a 100644 --- a/Modules/ITS/include/ITS/ITSFeeCheck.h +++ b/Modules/ITS/include/ITS/ITSFeeCheck.h @@ -40,8 +40,6 @@ class ITSFeeCheck : public o2::quality_control::checker::CheckInterface // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - bool checkReason(Quality checkResult, TString text); private: diff --git a/Modules/ITS/include/ITS/ITSFhrCheck.h b/Modules/ITS/include/ITS/ITSFhrCheck.h index 38b7f70250..903cd0a13a 100644 --- a/Modules/ITS/include/ITS/ITSFhrCheck.h +++ b/Modules/ITS/include/ITS/ITSFhrCheck.h @@ -39,7 +39,6 @@ class ITSFhrCheck : public o2::quality_control::checker::CheckInterface // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; bool checkReason(Quality checkResult, TString text); private: diff --git a/Modules/ITS/include/ITS/ITSThresholdCalibrationCheck.h b/Modules/ITS/include/ITS/ITSThresholdCalibrationCheck.h index 1bd97e027d..771bb3a018 100644 --- a/Modules/ITS/include/ITS/ITSThresholdCalibrationCheck.h +++ b/Modules/ITS/include/ITS/ITSThresholdCalibrationCheck.h @@ -36,7 +36,6 @@ class ITSThresholdCalibrationCheck : public o2::quality_control::checker::CheckI // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: ClassDefOverride(ITSThresholdCalibrationCheck, 2); diff --git a/Modules/ITS/include/ITS/ITSTrackCheck.h b/Modules/ITS/include/ITS/ITSTrackCheck.h index 6cf781ea99..377bc40ce8 100644 --- a/Modules/ITS/include/ITS/ITSTrackCheck.h +++ b/Modules/ITS/include/ITS/ITSTrackCheck.h @@ -39,7 +39,6 @@ class ITSTrackCheck : public o2::quality_control::checker::CheckInterface // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; int getDigit(int number, int digit); private: diff --git a/Modules/ITS/src/ITSClusterCheck.cxx b/Modules/ITS/src/ITSClusterCheck.cxx index c5d943eb97..bd50c2daa1 100644 --- a/Modules/ITS/src/ITSClusterCheck.cxx +++ b/Modules/ITS/src/ITSClusterCheck.cxx @@ -136,8 +136,6 @@ Quality ITSClusterCheck::check(std::map mo, Quality checkResult) { std::vector vPlotWithTextMessage = convertToArray(o2::quality_control_modules::common::getFromConfig(mCustomParameters, "plotWithTextMessage", "")); diff --git a/Modules/ITS/src/ITSFeeCheck.cxx b/Modules/ITS/src/ITSFeeCheck.cxx index 53a1816b5e..7b48d56627 100644 --- a/Modules/ITS/src/ITSFeeCheck.cxx +++ b/Modules/ITS/src/ITSFeeCheck.cxx @@ -272,8 +272,6 @@ Quality ITSFeeCheck::check(std::map> return result; } // end check -std::string ITSFeeCheck::getAcceptedType() { return "TH2I, TH2Poly"; } - void ITSFeeCheck::beautify(std::shared_ptr mo, Quality checkResult) { std::vector vPlotWithTextMessage = convertToArray(o2::quality_control_modules::common::getFromConfig(mCustomParameters, "plotWithTextMessage", "")); diff --git a/Modules/ITS/src/ITSFhrCheck.cxx b/Modules/ITS/src/ITSFhrCheck.cxx index 612c3c76bc..1b8a0e5577 100644 --- a/Modules/ITS/src/ITSFhrCheck.cxx +++ b/Modules/ITS/src/ITSFhrCheck.cxx @@ -169,8 +169,6 @@ Quality ITSFhrCheck::check(std::map> return result; } -std::string ITSFhrCheck::getAcceptedType() { return "TH1"; } - void ITSFhrCheck::beautify(std::shared_ptr mo, Quality checkResult) { std::vector vPlotWithTextMessage = convertToArray(o2::quality_control_modules::common::getFromConfig(mCustomParameters, "plotWithTextMessage", "")); diff --git a/Modules/ITS/src/ITSThresholdCalibrationCheck.cxx b/Modules/ITS/src/ITSThresholdCalibrationCheck.cxx index b1bf57db0c..8c03bffa08 100644 --- a/Modules/ITS/src/ITSThresholdCalibrationCheck.cxx +++ b/Modules/ITS/src/ITSThresholdCalibrationCheck.cxx @@ -31,8 +31,6 @@ Quality ITSThresholdCalibrationCheck::check(std::map mo, Quality checkResult) { } diff --git a/Modules/ITS/src/ITSTrackCheck.cxx b/Modules/ITS/src/ITSTrackCheck.cxx index 7676face98..da71918c9c 100644 --- a/Modules/ITS/src/ITSTrackCheck.cxx +++ b/Modules/ITS/src/ITSTrackCheck.cxx @@ -196,8 +196,6 @@ Quality ITSTrackCheck::check(std::map mo, Quality checkResult) { std::vector vPlotWithTextMessage = convertToArray(o2::quality_control_modules::common::getFromConfig(mCustomParameters, "plotWithTextMessage", "")); diff --git a/Modules/MFT/include/MFT/QcMFTClusterCheck.h b/Modules/MFT/include/MFT/QcMFTClusterCheck.h index 429428e1a8..01abc719a6 100644 --- a/Modules/MFT/include/MFT/QcMFTClusterCheck.h +++ b/Modules/MFT/include/MFT/QcMFTClusterCheck.h @@ -40,7 +40,6 @@ class QcMFTClusterCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: int mLadderThresholdMedium; diff --git a/Modules/MFT/include/MFT/QcMFTDigitCheck.h b/Modules/MFT/include/MFT/QcMFTDigitCheck.h index 2dbaeebfd8..e799719816 100644 --- a/Modules/MFT/include/MFT/QcMFTDigitCheck.h +++ b/Modules/MFT/include/MFT/QcMFTDigitCheck.h @@ -39,7 +39,6 @@ class QcMFTDigitCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: int mLadderThresholdMedium; diff --git a/Modules/MFT/include/MFT/QcMFTReadoutCheck.h b/Modules/MFT/include/MFT/QcMFTReadoutCheck.h index 8f2c08c15d..42209a056a 100644 --- a/Modules/MFT/include/MFT/QcMFTReadoutCheck.h +++ b/Modules/MFT/include/MFT/QcMFTReadoutCheck.h @@ -42,7 +42,6 @@ class QcMFTReadoutCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: int mWarningThresholdMedium; diff --git a/Modules/MFT/include/MFT/QcMFTTrackCheck.h b/Modules/MFT/include/MFT/QcMFTTrackCheck.h index 15ee597a8a..739ea54b72 100644 --- a/Modules/MFT/include/MFT/QcMFTTrackCheck.h +++ b/Modules/MFT/include/MFT/QcMFTTrackCheck.h @@ -40,7 +40,6 @@ class QcMFTTrackCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: // ROF check diff --git a/Modules/MFT/src/QcMFTClusterCheck.cxx b/Modules/MFT/src/QcMFTClusterCheck.cxx index 15c53a00e9..8d3878dbc6 100644 --- a/Modules/MFT/src/QcMFTClusterCheck.cxx +++ b/Modules/MFT/src/QcMFTClusterCheck.cxx @@ -217,8 +217,6 @@ Quality QcMFTClusterCheck::check(std::map mo) { long timestamp = mo->getValidity().getMin(); diff --git a/Modules/MFT/src/QcMFTDigitCheck.cxx b/Modules/MFT/src/QcMFTDigitCheck.cxx index e22a153112..a3a371c479 100644 --- a/Modules/MFT/src/QcMFTDigitCheck.cxx +++ b/Modules/MFT/src/QcMFTDigitCheck.cxx @@ -270,7 +270,6 @@ Quality QcMFTDigitCheck::check(std::map mo) { diff --git a/Modules/MFT/src/QcMFTReadoutCheck.cxx b/Modules/MFT/src/QcMFTReadoutCheck.cxx index dc71613b34..c0e0cf474d 100644 --- a/Modules/MFT/src/QcMFTReadoutCheck.cxx +++ b/Modules/MFT/src/QcMFTReadoutCheck.cxx @@ -210,8 +210,6 @@ Quality QcMFTReadoutCheck::check(std::map mo, Quality checkResult) { if (mo->getName() == "mSummaryChipFault") { diff --git a/Modules/MFT/src/QcMFTTrackCheck.cxx b/Modules/MFT/src/QcMFTTrackCheck.cxx index 1f1cfa903c..fb065e51a1 100644 --- a/Modules/MFT/src/QcMFTTrackCheck.cxx +++ b/Modules/MFT/src/QcMFTTrackCheck.cxx @@ -68,8 +68,6 @@ Quality QcMFTTrackCheck::check(std::map mo) { mROF = 0; diff --git a/Modules/MUON/Common/include/MUONCommon/MatchingEfficiencyCheck.h b/Modules/MUON/Common/include/MUONCommon/MatchingEfficiencyCheck.h index 38158470f9..ecdf355d9b 100644 --- a/Modules/MUON/Common/include/MUONCommon/MatchingEfficiencyCheck.h +++ b/Modules/MUON/Common/include/MUONCommon/MatchingEfficiencyCheck.h @@ -38,8 +38,6 @@ class MatchingEfficiencyCheck : public o2::quality_control::checker::CheckInterf void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; diff --git a/Modules/MUON/Common/include/MUONCommon/TracksCheck.h b/Modules/MUON/Common/include/MUONCommon/TracksCheck.h index 3bd0f98ad1..49d9553588 100644 --- a/Modules/MUON/Common/include/MUONCommon/TracksCheck.h +++ b/Modules/MUON/Common/include/MUONCommon/TracksCheck.h @@ -39,7 +39,6 @@ class TracksCheck : public o2::quality_control::checker::CheckInterface void endOfActivity(const Activity& activity) override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: std::unordered_map mQualities; diff --git a/Modules/MUON/Common/src/MatchingEfficiencyCheck.cxx b/Modules/MUON/Common/src/MatchingEfficiencyCheck.cxx index 7df4bb2f69..810a414db8 100644 --- a/Modules/MUON/Common/src/MatchingEfficiencyCheck.cxx +++ b/Modules/MUON/Common/src/MatchingEfficiencyCheck.cxx @@ -166,8 +166,6 @@ Quality MatchingEfficiencyCheck::check(std::map mo, Quality checkResult) { TH1* hist = dynamic_cast(mo->getObject()); diff --git a/Modules/MUON/Common/src/TracksCheck.cxx b/Modules/MUON/Common/src/TracksCheck.cxx index d63d96c446..64dab85719 100644 --- a/Modules/MUON/Common/src/TracksCheck.cxx +++ b/Modules/MUON/Common/src/TracksCheck.cxx @@ -161,8 +161,6 @@ Quality TracksCheck::check(std::map> return result; } -std::string TracksCheck::getAcceptedType() { return "TH1"; } - static void updateTitle(TH1* hist, std::string suffix) { if (!hist) { diff --git a/Modules/MUON/MCH/include/MCH/ClustersCheck.h b/Modules/MUON/MCH/include/MCH/ClustersCheck.h index 83a8f4a720..045a7764c2 100644 --- a/Modules/MUON/MCH/include/MCH/ClustersCheck.h +++ b/Modules/MUON/MCH/include/MCH/ClustersCheck.h @@ -45,7 +45,6 @@ class ClustersCheck : public o2::quality_control::checker::CheckInterface void startOfActivity(const Activity& activity) override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: /// quality flag associated to each input plot diff --git a/Modules/MUON/MCH/include/MCH/DecodingCheck.h b/Modules/MUON/MCH/include/MCH/DecodingCheck.h index c317743189..ce49749769 100644 --- a/Modules/MUON/MCH/include/MCH/DecodingCheck.h +++ b/Modules/MUON/MCH/include/MCH/DecodingCheck.h @@ -44,7 +44,6 @@ class DecodingCheck : public o2::quality_control::checker::CheckInterface void startOfActivity(const Activity& activity) override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: std::string mGoodFracHistName{ "DecodingErrors/GoodBoardsFractionPerDE" }; diff --git a/Modules/MUON/MCH/include/MCH/DigitsCheck.h b/Modules/MUON/MCH/include/MCH/DigitsCheck.h index 4fbad5487b..fe0a48b296 100644 --- a/Modules/MUON/MCH/include/MCH/DigitsCheck.h +++ b/Modules/MUON/MCH/include/MCH/DigitsCheck.h @@ -47,7 +47,6 @@ class DigitsCheck : public o2::quality_control::checker::CheckInterface void startOfActivity(const Activity& activity) override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: std::array checkMeanRates(TH1* h); diff --git a/Modules/MUON/MCH/include/MCH/PedestalsCheck.h b/Modules/MUON/MCH/include/MCH/PedestalsCheck.h index def73d8a73..5a7ea8fc70 100644 --- a/Modules/MUON/MCH/include/MCH/PedestalsCheck.h +++ b/Modules/MUON/MCH/include/MCH/PedestalsCheck.h @@ -36,7 +36,6 @@ class PedestalsCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: /// Maximum number of bad detection elements for "good" quality status diff --git a/Modules/MUON/MCH/include/MCH/PreclustersCheck.h b/Modules/MUON/MCH/include/MCH/PreclustersCheck.h index 401e58e871..fb3085bc27 100644 --- a/Modules/MUON/MCH/include/MCH/PreclustersCheck.h +++ b/Modules/MUON/MCH/include/MCH/PreclustersCheck.h @@ -45,7 +45,6 @@ class PreclustersCheck : public o2::quality_control::checker::CheckInterface void startOfActivity(const Activity& activity) override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: std::array checkMeanEfficiencies(TH1* h); diff --git a/Modules/MUON/MCH/src/ClustersCheck.cxx b/Modules/MUON/MCH/src/ClustersCheck.cxx index ea698c7eb7..851df5102d 100644 --- a/Modules/MUON/MCH/src/ClustersCheck.cxx +++ b/Modules/MUON/MCH/src/ClustersCheck.cxx @@ -130,8 +130,6 @@ Quality ClustersCheck::check(std::map mo, Quality checkResult) { if ((mo->getName().find("RefComp/") != std::string::npos)) { diff --git a/Modules/MUON/MCH/src/DigitsCheck.cxx b/Modules/MUON/MCH/src/DigitsCheck.cxx index e1a0f3b646..2c9322ed9b 100644 --- a/Modules/MUON/MCH/src/DigitsCheck.cxx +++ b/Modules/MUON/MCH/src/DigitsCheck.cxx @@ -322,8 +322,6 @@ Quality DigitsCheck::check(std::map> return mQualityChecker.getQuality(); } -std::string DigitsCheck::getAcceptedType() { return "TH1"; } - static void updateTitle(TH1* hist, std::string suffix) { if (!hist) { diff --git a/Modules/MUON/MCH/src/PedestalsCheck.cxx b/Modules/MUON/MCH/src/PedestalsCheck.cxx index 7d50ac6c9c..c6e69d5f2f 100644 --- a/Modules/MUON/MCH/src/PedestalsCheck.cxx +++ b/Modules/MUON/MCH/src/PedestalsCheck.cxx @@ -223,8 +223,6 @@ Quality PedestalsCheck::check(std::map mo, Quality checkResult) { if ((mo->getName().find("RefComp/") != std::string::npos)) { diff --git a/Modules/MUON/MID/include/MID/CalibMQcCheck.h b/Modules/MUON/MID/include/MID/CalibMQcCheck.h index 1806733258..e41fcd262f 100644 --- a/Modules/MUON/MID/include/MID/CalibMQcCheck.h +++ b/Modules/MUON/MID/include/MID/CalibMQcCheck.h @@ -35,7 +35,6 @@ class CalibMQcCheck : public o2::quality_control::checker::CheckInterface // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: HistoHelper mHistoHelper; ///! Histogram helper diff --git a/Modules/MUON/MID/include/MID/CalibQcCheck.h b/Modules/MUON/MID/include/MID/CalibQcCheck.h index ea8322fa99..a31ba7de86 100644 --- a/Modules/MUON/MID/include/MID/CalibQcCheck.h +++ b/Modules/MUON/MID/include/MID/CalibQcCheck.h @@ -36,7 +36,6 @@ class CalibQcCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: float mDeadRof = 0; diff --git a/Modules/MUON/MID/include/MID/ClustQcCheck.h b/Modules/MUON/MID/include/MID/ClustQcCheck.h index 527d8e737a..172a905e19 100644 --- a/Modules/MUON/MID/include/MID/ClustQcCheck.h +++ b/Modules/MUON/MID/include/MID/ClustQcCheck.h @@ -34,7 +34,6 @@ class ClustQcCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: float mClusterTF = 0; diff --git a/Modules/MUON/MID/include/MID/DigitsQcCheck.h b/Modules/MUON/MID/include/MID/DigitsQcCheck.h index 631b441e8a..946e905fe2 100644 --- a/Modules/MUON/MID/include/MID/DigitsQcCheck.h +++ b/Modules/MUON/MID/include/MID/DigitsQcCheck.h @@ -40,7 +40,6 @@ class DigitsQcCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: double mMeanMultThreshold = 10.; ///! Upper threshold on mean multiplicity diff --git a/Modules/MUON/MID/include/MID/RawQcCheck.h b/Modules/MUON/MID/include/MID/RawQcCheck.h index 897f9cd1de..8203c50d59 100644 --- a/Modules/MUON/MID/include/MID/RawQcCheck.h +++ b/Modules/MUON/MID/include/MID/RawQcCheck.h @@ -35,8 +35,6 @@ class RawQcCheck : public o2::quality_control::checker::CheckInterface // Override interface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(RawQcCheck, 2); }; diff --git a/Modules/MUON/MID/include/MID/TracksQcCheck.h b/Modules/MUON/MID/include/MID/TracksQcCheck.h index 61fd21cd83..a7b435775e 100644 --- a/Modules/MUON/MID/include/MID/TracksQcCheck.h +++ b/Modules/MUON/MID/include/MID/TracksQcCheck.h @@ -36,7 +36,6 @@ class TracksQcCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: double mRatio44Threshold; diff --git a/Modules/MUON/MID/src/CalibMQcCheck.cxx b/Modules/MUON/MID/src/CalibMQcCheck.cxx index 3f7200d185..f0530133fa 100644 --- a/Modules/MUON/MID/src/CalibMQcCheck.cxx +++ b/Modules/MUON/MID/src/CalibMQcCheck.cxx @@ -45,8 +45,6 @@ Quality CalibMQcCheck::check(std::map mo, Quality checkResult) { diff --git a/Modules/MUON/MID/src/CalibQcCheck.cxx b/Modules/MUON/MID/src/CalibQcCheck.cxx index 459fb4cc2b..69f9db1207 100644 --- a/Modules/MUON/MID/src/CalibQcCheck.cxx +++ b/Modules/MUON/MID/src/CalibQcCheck.cxx @@ -56,8 +56,6 @@ Quality CalibQcCheck::check(std::map return result; } -std::string CalibQcCheck::getAcceptedType() { return "TH1"; } - void CalibQcCheck::beautify(std::shared_ptr mo, Quality checkResult) { auto currentTime = mHistoHelper.getCurrentTime(); diff --git a/Modules/MUON/MID/src/ClustQcCheck.cxx b/Modules/MUON/MID/src/ClustQcCheck.cxx index e6b5449413..9978086583 100644 --- a/Modules/MUON/MID/src/ClustQcCheck.cxx +++ b/Modules/MUON/MID/src/ClustQcCheck.cxx @@ -79,8 +79,6 @@ Quality ClustQcCheck::check(std::map return result; } -std::string ClustQcCheck::getAcceptedType() { return "TH1"; } - static void updateTitle(TH1* hist, std::string suffix) { if (!hist) { diff --git a/Modules/MUON/MID/src/DigitsQcCheck.cxx b/Modules/MUON/MID/src/DigitsQcCheck.cxx index 577da2b873..43bf5a44f4 100644 --- a/Modules/MUON/MID/src/DigitsQcCheck.cxx +++ b/Modules/MUON/MID/src/DigitsQcCheck.cxx @@ -220,8 +220,6 @@ Quality DigitsQcCheck::check(std::map mo, Quality checkResult) { gStyle->SetPalette(kRainBow); diff --git a/Modules/MUON/MID/src/RawQcCheck.cxx b/Modules/MUON/MID/src/RawQcCheck.cxx index 03a01a733d..9b715d25fd 100644 --- a/Modules/MUON/MID/src/RawQcCheck.cxx +++ b/Modules/MUON/MID/src/RawQcCheck.cxx @@ -72,8 +72,6 @@ Quality RawQcCheck::check(std::map>* return result; } -std::string RawQcCheck::getAcceptedType() { return "TH1"; } - void RawQcCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName() == "mDetElemID") { diff --git a/Modules/MUON/MID/src/TracksQcCheck.cxx b/Modules/MUON/MID/src/TracksQcCheck.cxx index baee8bbb2f..1a004aea50 100644 --- a/Modules/MUON/MID/src/TracksQcCheck.cxx +++ b/Modules/MUON/MID/src/TracksQcCheck.cxx @@ -105,8 +105,6 @@ Quality TracksQcCheck::check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; protected: int mDeadThreshold[5] = { 10, 10, 10, 10, 10 }; /// Number of new dead channels per module to decalre bad diff --git a/Modules/PHOS/include/PHOS/RawCheck.h b/Modules/PHOS/include/PHOS/RawCheck.h index 57f265c98f..4f8fb19780 100644 --- a/Modules/PHOS/include/PHOS/RawCheck.h +++ b/Modules/PHOS/include/PHOS/RawCheck.h @@ -42,7 +42,6 @@ class RawCheck final : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override {} - std::string getAcceptedType() override; protected: bool checkErrHistograms(MonitorObject* mo); diff --git a/Modules/PHOS/src/ClusterCheck.cxx b/Modules/PHOS/src/ClusterCheck.cxx index 96d4739727..55b9f8f592 100644 --- a/Modules/PHOS/src/ClusterCheck.cxx +++ b/Modules/PHOS/src/ClusterCheck.cxx @@ -257,8 +257,6 @@ Quality ClusterCheck::check(std::map return result; } // namespace o2::quality_control_modules::phos -std::string ClusterCheck::getAcceptedType() { return "TH1"; } - void ClusterCheck::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName().find("ClusterOccupancyM") != std::string::npos) { diff --git a/Modules/PHOS/src/RawCheck.cxx b/Modules/PHOS/src/RawCheck.cxx index 8082596cad..b15eeeb556 100644 --- a/Modules/PHOS/src/RawCheck.cxx +++ b/Modules/PHOS/src/RawCheck.cxx @@ -146,8 +146,6 @@ Quality RawCheck::check(std::map>* m return mCheckResult; } -std::string RawCheck::getAcceptedType() { return "TH1"; } - bool RawCheck::checkErrHistograms(MonitorObject* mo) { // Return true if mo found and handled diff --git a/Modules/Skeleton/include/Skeleton/SkeletonCheck.h b/Modules/Skeleton/include/Skeleton/SkeletonCheck.h index 691b82776d..660984d72c 100644 --- a/Modules/Skeleton/include/Skeleton/SkeletonCheck.h +++ b/Modules/Skeleton/include/Skeleton/SkeletonCheck.h @@ -36,7 +36,6 @@ class SkeletonCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; void reset() override; void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; diff --git a/Modules/Skeleton/src/SkeletonCheck.cxx b/Modules/Skeleton/src/SkeletonCheck.cxx index 8f1f1cbf99..f5deb755ca 100644 --- a/Modules/Skeleton/src/SkeletonCheck.cxx +++ b/Modules/Skeleton/src/SkeletonCheck.cxx @@ -81,12 +81,6 @@ Quality SkeletonCheck::check(std::map mo, Quality checkResult) { // THUS FUNCTION BODY IS AN EXAMPLE. PLEASE REMOVE EVERYTHING YOU DO NOT NEED. diff --git a/Modules/TOF/include/TOF/CheckCompressedData.h b/Modules/TOF/include/TOF/CheckCompressedData.h index 9a40d51d8e..00c2f0ea16 100644 --- a/Modules/TOF/include/TOF/CheckCompressedData.h +++ b/Modules/TOF/include/TOF/CheckCompressedData.h @@ -39,7 +39,6 @@ class CheckCompressedData : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override; private: float mDiagnosticThresholdPerSlot = 0; diff --git a/Modules/TOF/include/TOF/CheckDRMDiagnostics.h b/Modules/TOF/include/TOF/CheckDRMDiagnostics.h index 01da723100..76ffa4a42a 100644 --- a/Modules/TOF/include/TOF/CheckDRMDiagnostics.h +++ b/Modules/TOF/include/TOF/CheckDRMDiagnostics.h @@ -39,7 +39,6 @@ class CheckDRMDiagnostics : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override; private: /// Messages to print on the output PAD diff --git a/Modules/TOF/include/TOF/CheckDiagnostics.h b/Modules/TOF/include/TOF/CheckDiagnostics.h index 7f1acf9ab2..55b856e36e 100644 --- a/Modules/TOF/include/TOF/CheckDiagnostics.h +++ b/Modules/TOF/include/TOF/CheckDiagnostics.h @@ -39,7 +39,6 @@ class CheckDiagnostics : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override; private: /// Messages to print on the output PAD diff --git a/Modules/TOF/include/TOF/CheckHitMap.h b/Modules/TOF/include/TOF/CheckHitMap.h index ce7273b7d9..5cc94c3b77 100644 --- a/Modules/TOF/include/TOF/CheckHitMap.h +++ b/Modules/TOF/include/TOF/CheckHitMap.h @@ -37,7 +37,6 @@ class CheckHitMap : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override { return "TH2F"; } private: /// Reference hit map taken from the CCDB and translated into QC binning @@ -61,6 +60,8 @@ class CheckHitMap : public o2::quality_control::checker::CheckInterface int mMaxHitMoreThanRef = 2; /// Maximum number of Hits more than Ref that is accepted int mMaxRefMoreThanHit = 317; /// Maximum number of Refs more than Hits that is accepted (usual 5%of enabled channels) bool mEnablePadPerMismatch = false; /// Flag to enable showing where the mismatch happens in the plot with TPads + /// Accepted type for this check + static constexpr char mAcceptedType[] = "TH2F"; ClassDefOverride(CheckHitMap, 2); }; diff --git a/Modules/TOF/include/TOF/CheckLostOrbits.h b/Modules/TOF/include/TOF/CheckLostOrbits.h index 26122caaeb..f8b4def582 100644 --- a/Modules/TOF/include/TOF/CheckLostOrbits.h +++ b/Modules/TOF/include/TOF/CheckLostOrbits.h @@ -36,7 +36,6 @@ class CheckLostOrbits : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override; private: MessagePad mShifterMessages{ "", 0.15, 0.65, 0.4, 0.85 }; diff --git a/Modules/TOF/include/TOF/CheckNoise.h b/Modules/TOF/include/TOF/CheckNoise.h index b1326a3f1b..3f031f510b 100644 --- a/Modules/TOF/include/TOF/CheckNoise.h +++ b/Modules/TOF/include/TOF/CheckNoise.h @@ -37,13 +37,14 @@ class CheckNoise : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override { return "TH1F"; } private: /// Messages to print on the output PAD MessagePad mShifterMessages; /// Name of the accepted MO static constexpr char mAcceptedName[] = "hIndexEOHitRate"; + /// Accepted type for this check + static constexpr char mAcceptedType[] = "TH1F"; /// Maximum rate allowed before declaring a channel noisy float mMaxNoiseRate = 50.f; // Hz diff --git a/Modules/TOF/include/TOF/CheckRaw.h b/Modules/TOF/include/TOF/CheckRaw.h index 0471b84577..0ced914eb2 100644 --- a/Modules/TOF/include/TOF/CheckRaw.h +++ b/Modules/TOF/include/TOF/CheckRaw.h @@ -39,7 +39,6 @@ class CheckRaw : public o2::quality_control::checker::CheckInterface void configure(std::string name) override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override; private: float mDiagnosticThresholdPerSlot = 0; diff --git a/Modules/TOF/include/TOF/CheckRawMultiplicity.h b/Modules/TOF/include/TOF/CheckRawMultiplicity.h index 02ad71d1f9..3a11590aed 100644 --- a/Modules/TOF/include/TOF/CheckRawMultiplicity.h +++ b/Modules/TOF/include/TOF/CheckRawMultiplicity.h @@ -36,7 +36,6 @@ class CheckRawMultiplicity : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override { return "TH1I"; } /// Running modes available static constexpr int kModeCollisions = 0; /// Standard running mode with collisions @@ -60,6 +59,8 @@ class CheckRawMultiplicity : public o2::quality_control::checker::CheckInterface // User variables /// Messages to print on the output PAD MessagePad mShifterMessages; + /// Accepted type for this check + static constexpr char mAcceptedType[] = "TH1I"; ClassDefOverride(CheckRawMultiplicity, 2); }; diff --git a/Modules/TOF/include/TOF/CheckRawTime.h b/Modules/TOF/include/TOF/CheckRawTime.h index a08b4c48d4..63749d5b21 100644 --- a/Modules/TOF/include/TOF/CheckRawTime.h +++ b/Modules/TOF/include/TOF/CheckRawTime.h @@ -36,7 +36,6 @@ class CheckRawTime : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override { return "TH1F"; } private: // Running configurable parameters @@ -59,6 +58,8 @@ class CheckRawTime : public o2::quality_control::checker::CheckInterface /// Messages to print on the output PAD MessagePad mShifterMessages; + /// Accepted type for this check + static constexpr char mAcceptedType[] = "TH1F"; ClassDefOverride(CheckRawTime, 2); }; diff --git a/Modules/TOF/include/TOF/CheckRawToT.h b/Modules/TOF/include/TOF/CheckRawToT.h index cf566ea795..6ab2d57bba 100644 --- a/Modules/TOF/include/TOF/CheckRawToT.h +++ b/Modules/TOF/include/TOF/CheckRawToT.h @@ -36,7 +36,6 @@ class CheckRawToT : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override { return "TH1F"; } private: // Running configurable parameters @@ -50,6 +49,8 @@ class CheckRawToT : public o2::quality_control::checker::CheckInterface // User variables /// Messages to print on the output PAD MessagePad mShifterMessages; + /// Accepted type for this check + static constexpr char mAcceptedType[] = "TH1F"; ClassDefOverride(CheckRawToT, 2); }; diff --git a/Modules/TOF/include/TOF/CheckSlotPartMask.h b/Modules/TOF/include/TOF/CheckSlotPartMask.h index 4ec05dc58d..ec819dc421 100644 --- a/Modules/TOF/include/TOF/CheckSlotPartMask.h +++ b/Modules/TOF/include/TOF/CheckSlotPartMask.h @@ -36,7 +36,6 @@ class CheckSlotPartMask : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult) override; - std::string getAcceptedType() override; private: // Threshold number of crates missing diff --git a/Modules/TOF/src/CheckCompressedData.cxx b/Modules/TOF/src/CheckCompressedData.cxx index 0a372e74c4..cbb2eb3946 100644 --- a/Modules/TOF/src/CheckCompressedData.cxx +++ b/Modules/TOF/src/CheckCompressedData.cxx @@ -60,8 +60,6 @@ Quality CheckCompressedData::check(std::map mo, Quality checkResult) { if (mo->getName() == "hDiagnostic") { diff --git a/Modules/TOF/src/CheckDRMDiagnostics.cxx b/Modules/TOF/src/CheckDRMDiagnostics.cxx index 26df9fed00..9403313a4b 100644 --- a/Modules/TOF/src/CheckDRMDiagnostics.cxx +++ b/Modules/TOF/src/CheckDRMDiagnostics.cxx @@ -62,8 +62,6 @@ Quality CheckDRMDiagnostics::check(std::map mo, Quality checkResult) { if (mo->getName() == "DRMCounter") { diff --git a/Modules/TOF/src/CheckDiagnostics.cxx b/Modules/TOF/src/CheckDiagnostics.cxx index 92671e6d5b..199fe8aae2 100644 --- a/Modules/TOF/src/CheckDiagnostics.cxx +++ b/Modules/TOF/src/CheckDiagnostics.cxx @@ -50,8 +50,6 @@ Quality CheckDiagnostics::check(std::map mo, Quality checkResult) { if (mo->getName() == "RDHCounter") { diff --git a/Modules/TOF/src/CheckHitMap.cxx b/Modules/TOF/src/CheckHitMap.cxx index ee3feaac35..523f75a22c 100644 --- a/Modules/TOF/src/CheckHitMap.cxx +++ b/Modules/TOF/src/CheckHitMap.cxx @@ -49,8 +49,8 @@ Quality CheckHitMap::check(std::map> Quality result = Quality::Null; for (auto& [moName, mo] : *moMap) { - if (!isObjectCheckable(mo)) { - ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type " << mAcceptedType << ENDM; continue; } ILOG(Debug, Devel) << "Checking " << mo->getName() << ENDM; @@ -132,8 +132,8 @@ Quality CheckHitMap::check(std::map> void CheckHitMap::beautify(std::shared_ptr mo, Quality checkResult) { ILOG(Debug, Devel) << "Beautifying " << mo->getName() << ENDM; - if (!isObjectCheckable(mo)) { - ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << mAcceptedType << ENDM; return; } if (1) { diff --git a/Modules/TOF/src/CheckLostOrbits.cxx b/Modules/TOF/src/CheckLostOrbits.cxx index bb730cc9ed..eafc4e88e8 100644 --- a/Modules/TOF/src/CheckLostOrbits.cxx +++ b/Modules/TOF/src/CheckLostOrbits.cxx @@ -55,8 +55,6 @@ Quality CheckLostOrbits::check(std::map mo, Quality checkResult) { if (mo->getName() == "OrbitsInTFEfficiency") { diff --git a/Modules/TOF/src/CheckNoise.cxx b/Modules/TOF/src/CheckNoise.cxx index 7dd7405354..e4d73ed6e2 100644 --- a/Modules/TOF/src/CheckNoise.cxx +++ b/Modules/TOF/src/CheckNoise.cxx @@ -36,8 +36,8 @@ Quality CheckNoise::check(std::map>* Quality result = Quality::Null; for (auto& [moName, mo] : *moMap) { - if (!isObjectCheckable(mo)) { - ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type " << mAcceptedType << ENDM; continue; } if (mo->getName() != mAcceptedName) { @@ -65,12 +65,12 @@ Quality CheckNoise::check(std::map>* void CheckNoise::beautify(std::shared_ptr mo, Quality checkResult) { ILOG(Debug, Devel) << "Beautifying " << mo->getName() << ENDM; - if (!isObjectCheckable(mo)) { - ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << mAcceptedType << ENDM; return; } if (mo->getName() == mAcceptedName) { - auto* h = static_cast(mo->getObject()); + auto* h = static_cast(mo->getObject()); auto msg = mShifterMessages.MakeMessagePad(h, checkResult); if (!msg) { return; diff --git a/Modules/TOF/src/CheckRaw.cxx b/Modules/TOF/src/CheckRaw.cxx index 16c988da10..85192f10b5 100644 --- a/Modules/TOF/src/CheckRaw.cxx +++ b/Modules/TOF/src/CheckRaw.cxx @@ -73,8 +73,6 @@ Quality CheckRaw::check(std::map>* m return result; } -std::string CheckRaw::getAcceptedType() { return "TH2F"; } - void CheckRaw::beautify(std::shared_ptr mo, Quality checkResult) { if (mo->getName() == "hDiagnostic") { diff --git a/Modules/TOF/src/CheckRawMultiplicity.cxx b/Modules/TOF/src/CheckRawMultiplicity.cxx index 26858016fc..cf99b6b185 100644 --- a/Modules/TOF/src/CheckRawMultiplicity.cxx +++ b/Modules/TOF/src/CheckRawMultiplicity.cxx @@ -67,8 +67,8 @@ Quality CheckRawMultiplicity::check(std::mapgetName() << " " << moName << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type " << mAcceptedType << ENDM; continue; } ILOG(Debug, Devel) << "Checking " << mo->getName() << ENDM; @@ -155,8 +155,8 @@ Quality CheckRawMultiplicity::check(std::map mo, Quality checkResult) { ILOG(Debug, Devel) << "Beautifying " << mo->getName() << ENDM; - if (!isObjectCheckable(mo)) { - ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << mAcceptedType << ENDM; return; } if (mo->getName() == "Multiplicity/Integrated") { diff --git a/Modules/TOF/src/CheckRawTime.cxx b/Modules/TOF/src/CheckRawTime.cxx index b96e9a8cd0..95fbea806d 100644 --- a/Modules/TOF/src/CheckRawTime.cxx +++ b/Modules/TOF/src/CheckRawTime.cxx @@ -44,8 +44,8 @@ Quality CheckRawTime::check(std::map Quality result = Quality::Null; for (auto& [moName, mo] : *moMap) { - if (!isObjectCheckable(mo)) { - ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type " << mAcceptedType << ENDM; continue; } ILOG(Debug, Devel) << "Checking " << mo->getName() << ENDM; @@ -86,8 +86,8 @@ Quality CheckRawTime::check(std::map void CheckRawTime::beautify(std::shared_ptr mo, Quality checkResult) { ILOG(Debug, Devel) << "Beautifying " << mo->getName() << ENDM; - if (!isObjectCheckable(mo)) { - ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << mAcceptedType << ENDM; return; } if (mo->getName().find("Time/") != std::string::npos) { diff --git a/Modules/TOF/src/CheckRawToT.cxx b/Modules/TOF/src/CheckRawToT.cxx index 5a57ca1579..932674d726 100644 --- a/Modules/TOF/src/CheckRawToT.cxx +++ b/Modules/TOF/src/CheckRawToT.cxx @@ -51,8 +51,8 @@ Quality CheckRawToT::check(std::map> float ToTIntegral = 0.f; for (auto& [moName, mo] : *moMap) { - if (!isObjectCheckable(mo)) { - ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type " << mAcceptedType << ENDM; continue; } ILOG(Debug, Devel) << "Checking " << mo->getName() << ENDM; @@ -96,8 +96,8 @@ Quality CheckRawToT::check(std::map> void CheckRawToT::beautify(std::shared_ptr mo, Quality checkResult) { ILOG(Debug, Devel) << "Beautifying " << mo->getName() << ENDM; - if (!isObjectCheckable(mo)) { - ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << getAcceptedType() << ENDM; + if (!mo->encapsulatedInheritsFrom(mAcceptedType)) { + ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type " << mAcceptedType << ENDM; return; } if (mo->getName().find("ToT/") != std::string::npos) { diff --git a/Modules/TOF/src/CheckSlotPartMask.cxx b/Modules/TOF/src/CheckSlotPartMask.cxx index ba8aa325fc..4ef54cce53 100644 --- a/Modules/TOF/src/CheckSlotPartMask.cxx +++ b/Modules/TOF/src/CheckSlotPartMask.cxx @@ -89,7 +89,6 @@ Quality CheckSlotPartMask::check(std::map mo, Quality checkResult) { diff --git a/Modules/TPC/include/TPC/CheckForEmptyPads.h b/Modules/TPC/include/TPC/CheckForEmptyPads.h index a52b4eeb57..99d7ab9534 100644 --- a/Modules/TPC/include/TPC/CheckForEmptyPads.h +++ b/Modules/TPC/include/TPC/CheckForEmptyPads.h @@ -37,7 +37,6 @@ class CheckForEmptyPads : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: ClassDefOverride(CheckForEmptyPads, 1); diff --git a/Modules/TPC/include/TPC/CheckOfPads.h b/Modules/TPC/include/TPC/CheckOfPads.h index 2457485e07..452dc82043 100644 --- a/Modules/TPC/include/TPC/CheckOfPads.h +++ b/Modules/TPC/include/TPC/CheckOfPads.h @@ -37,7 +37,6 @@ class CheckOfPads : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: ClassDefOverride(CheckOfPads, 1); diff --git a/Modules/TPC/include/TPC/CheckOfSlices.h b/Modules/TPC/include/TPC/CheckOfSlices.h index ab16896c08..138df05a60 100644 --- a/Modules/TPC/include/TPC/CheckOfSlices.h +++ b/Modules/TPC/include/TPC/CheckOfSlices.h @@ -41,7 +41,6 @@ class CheckOfSlices : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override { return "TCanvas"; } private: ClassDefOverride(CheckOfSlices, 3); diff --git a/Modules/TPC/include/TPC/CheckOfTrendings.h b/Modules/TPC/include/TPC/CheckOfTrendings.h index c38d4427ad..8fca751011 100644 --- a/Modules/TPC/include/TPC/CheckOfTrendings.h +++ b/Modules/TPC/include/TPC/CheckOfTrendings.h @@ -42,7 +42,6 @@ class CheckOfTrendings : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: ClassDefOverride(CheckOfTrendings, 2); diff --git a/Modules/TPC/include/TPC/GenericHistogramCheck.h b/Modules/TPC/include/TPC/GenericHistogramCheck.h index 697ced05f8..2999480bad 100644 --- a/Modules/TPC/include/TPC/GenericHistogramCheck.h +++ b/Modules/TPC/include/TPC/GenericHistogramCheck.h @@ -36,7 +36,6 @@ class GenericHistogramCheck : public o2::quality_control::checker::CheckInterfac void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: ClassDefOverride(GenericHistogramCheck, 2); diff --git a/Modules/TPC/include/TPC/PadCalibrationCheck.h b/Modules/TPC/include/TPC/PadCalibrationCheck.h index 8254f4efd8..685482aa45 100644 --- a/Modules/TPC/include/TPC/PadCalibrationCheck.h +++ b/Modules/TPC/include/TPC/PadCalibrationCheck.h @@ -37,7 +37,6 @@ class PadCalibrationCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; private: ClassDefOverride(PadCalibrationCheck, 2); diff --git a/Modules/TPC/src/CheckForEmptyPads.cxx b/Modules/TPC/src/CheckForEmptyPads.cxx index d8fb001ce7..44220062dd 100644 --- a/Modules/TPC/src/CheckForEmptyPads.cxx +++ b/Modules/TPC/src/CheckForEmptyPads.cxx @@ -219,13 +219,6 @@ std::string CheckForEmptyPads::summarizeMetaData(Quality quality) return sumMetaData; } -//______________________________________________________________________________ -std::string CheckForEmptyPads::getAcceptedType() -{ - return "TCanvas"; -} - -//______________________________________________________________________________ void CheckForEmptyPads::beautify(std::shared_ptr mo, Quality) { std::string checkMessage; diff --git a/Modules/TPC/src/CheckOfPads.cxx b/Modules/TPC/src/CheckOfPads.cxx index 75d41d2320..2379612459 100644 --- a/Modules/TPC/src/CheckOfPads.cxx +++ b/Modules/TPC/src/CheckOfPads.cxx @@ -254,7 +254,6 @@ Quality CheckOfPads::check(std::map> } // end of loop over moMap //______________________________________________________________________________ -std::string CheckOfPads::getAcceptedType() { return "TCanvas"; } //______________________________________________________________________________ void CheckOfPads::beautify(std::shared_ptr mo, Quality) diff --git a/Modules/TPC/src/CheckOfTrendings.cxx b/Modules/TPC/src/CheckOfTrendings.cxx index 6cb6e4c6f2..c60642ea0b 100644 --- a/Modules/TPC/src/CheckOfTrendings.cxx +++ b/Modules/TPC/src/CheckOfTrendings.cxx @@ -379,8 +379,6 @@ Quality CheckOfTrendings::check(std::map mo, Quality checkResult) { auto* canv = dynamic_cast(mo->getObject()); diff --git a/Modules/TPC/src/GenericHistogramCheck.cxx b/Modules/TPC/src/GenericHistogramCheck.cxx index ce8bdcaea7..702e988162 100644 --- a/Modules/TPC/src/GenericHistogramCheck.cxx +++ b/Modules/TPC/src/GenericHistogramCheck.cxx @@ -238,8 +238,6 @@ Quality GenericHistogramCheck::check(std::map mo, Quality checkResult) { TPaveText* msg = new TPaveText(0.11, 0.85, 0.9, 0.95, "NDC"); diff --git a/Modules/TPC/src/PadCalibrationCheck.cxx b/Modules/TPC/src/PadCalibrationCheck.cxx index cad34a9059..875e77cc58 100644 --- a/Modules/TPC/src/PadCalibrationCheck.cxx +++ b/Modules/TPC/src/PadCalibrationCheck.cxx @@ -121,10 +121,6 @@ Quality PadCalibrationCheck::check(std::map mo, Quality) { auto moName = mo->getName(); diff --git a/Modules/TRD/include/TRD/PulseHeightCheck.h b/Modules/TRD/include/TRD/PulseHeightCheck.h index d2b2ecc2f9..88612da0c4 100644 --- a/Modules/TRD/include/TRD/PulseHeightCheck.h +++ b/Modules/TRD/include/TRD/PulseHeightCheck.h @@ -37,7 +37,6 @@ class PulseHeightCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; std::pair mDriftRegion; std::pair mPulseHeightPeakRegion; unsigned int mPulseHeightMinSum; diff --git a/Modules/TRD/include/TRD/PulsePositionCheck.h b/Modules/TRD/include/TRD/PulsePositionCheck.h index 2d4aa189cf..bd3cbd84b6 100644 --- a/Modules/TRD/include/TRD/PulsePositionCheck.h +++ b/Modules/TRD/include/TRD/PulsePositionCheck.h @@ -36,7 +36,6 @@ class PulsePositionCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; std::pair mPulseHeightPeakRegion; double chi2byNDF_threshold; double FitParam0; diff --git a/Modules/TRD/include/TRD/RawDataCheck.h b/Modules/TRD/include/TRD/RawDataCheck.h index 448b095f0a..ef5f7054ec 100644 --- a/Modules/TRD/include/TRD/RawDataCheck.h +++ b/Modules/TRD/include/TRD/RawDataCheck.h @@ -38,7 +38,6 @@ class RawDataCheckStats : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; void reset() override; void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; @@ -66,7 +65,6 @@ class RawDataCheckSizes : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; void reset() override; void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; diff --git a/Modules/TRD/include/TRD/TrackletCountCheck.h b/Modules/TRD/include/TRD/TrackletCountCheck.h index d483de51db..2685d7962b 100644 --- a/Modules/TRD/include/TRD/TrackletCountCheck.h +++ b/Modules/TRD/include/TRD/TrackletCountCheck.h @@ -35,7 +35,6 @@ class TrackletCountCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; void reset() override; void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; diff --git a/Modules/TRD/src/PulseHeightCheck.cxx b/Modules/TRD/src/PulseHeightCheck.cxx index 8d95d95c9e..421388d43d 100644 --- a/Modules/TRD/src/PulseHeightCheck.cxx +++ b/Modules/TRD/src/PulseHeightCheck.cxx @@ -145,8 +145,6 @@ Quality PulseHeightCheck::check(std::map mo, Quality checkResult) { if ((mo->getName() == "PulseHeight/mPulseHeight") || (mo->getName() == "PulseHeight/mPulseHeightpro")) { diff --git a/Modules/TRD/src/PulsePositionCheck.cxx b/Modules/TRD/src/PulsePositionCheck.cxx index 4787d1276d..e8cf93ca98 100644 --- a/Modules/TRD/src/PulsePositionCheck.cxx +++ b/Modules/TRD/src/PulsePositionCheck.cxx @@ -207,8 +207,6 @@ Quality PulsePositionCheck::check(std::map mo, Quality checkResult) { diff --git a/Modules/TRD/src/RawDataCheck.cxx b/Modules/TRD/src/RawDataCheck.cxx index f818456530..2bffd33a39 100644 --- a/Modules/TRD/src/RawDataCheck.cxx +++ b/Modules/TRD/src/RawDataCheck.cxx @@ -130,11 +130,6 @@ void RawDataCheckStats::beautify(std::shared_ptr mo, Quality chec } } -std::string RawDataCheckStats::getAcceptedType() -{ - return "TH1"; -} - void RawDataCheckStats::reset() { ILOG(Debug, Devel) << "RawDataCheckStats::reset" << ENDM; @@ -209,11 +204,6 @@ void RawDataCheckSizes::beautify(std::shared_ptr mo, Quality chec } } -std::string RawDataCheckSizes::getAcceptedType() -{ - return "TH2"; -} - void RawDataCheckSizes::reset() { ILOG(Debug, Devel) << "RawDataCheckSizes::reset" << ENDM; diff --git a/Modules/TRD/src/TrackletCountCheck.cxx b/Modules/TRD/src/TrackletCountCheck.cxx index 4359eec9b2..19a216faa2 100644 --- a/Modules/TRD/src/TrackletCountCheck.cxx +++ b/Modules/TRD/src/TrackletCountCheck.cxx @@ -151,8 +151,6 @@ Quality TrackletCountCheck::check(std::map mo, Quality checkResult) { if (mo->getName() == "trackletsperevent") { diff --git a/Modules/ZDC/include/ZDC/ZDCRawDataCheck.h b/Modules/ZDC/include/ZDC/ZDCRawDataCheck.h index d416c2fa5c..fc50ec39d9 100644 --- a/Modules/ZDC/include/ZDC/ZDCRawDataCheck.h +++ b/Modules/ZDC/include/ZDC/ZDCRawDataCheck.h @@ -36,8 +36,6 @@ class ZDCRawDataCheck : public o2::quality_control::checker::CheckInterface Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(ZDCRawDataCheck, 2); struct sCheck { std::string ch; diff --git a/Modules/ZDC/include/ZDC/ZDCRecBeautifyPlots.h b/Modules/ZDC/include/ZDC/ZDCRecBeautifyPlots.h index cc4483ad8c..4dd4f47ae9 100644 --- a/Modules/ZDC/include/ZDC/ZDCRecBeautifyPlots.h +++ b/Modules/ZDC/include/ZDC/ZDCRecBeautifyPlots.h @@ -36,7 +36,6 @@ class ZDCRecBeautifyPlots : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; void reset() override; void startOfActivity(const Activity& activity) override; void endOfActivity(const Activity& activity) override; diff --git a/Modules/ZDC/include/ZDC/ZDCRecDataCheck.h b/Modules/ZDC/include/ZDC/ZDCRecDataCheck.h index 7d9e964633..94c0390422 100644 --- a/Modules/ZDC/include/ZDC/ZDCRecDataCheck.h +++ b/Modules/ZDC/include/ZDC/ZDCRecDataCheck.h @@ -36,8 +36,6 @@ class ZDCRecDataCheck : public o2::quality_control::checker::CheckInterface void configure() override; Quality check(std::map>* moMap) override; void beautify(std::shared_ptr mo, Quality checkResult = Quality::Null) override; - std::string getAcceptedType() override; - ClassDefOverride(ZDCRecDataCheck, 2); struct sCheck { diff --git a/Modules/ZDC/src/ZDCRawDataCheck.cxx b/Modules/ZDC/src/ZDCRawDataCheck.cxx index db3cc36fb1..5239a82f5e 100644 --- a/Modules/ZDC/src/ZDCRawDataCheck.cxx +++ b/Modules/ZDC/src/ZDCRawDataCheck.cxx @@ -222,8 +222,6 @@ Quality ZDCRawDataCheck::check(std::map mo, Quality checkResult) { for (int ih = 0; ih < (int)mVectHistoCheck.size(); ih++) { diff --git a/Modules/ZDC/src/ZDCRecBeautifyPlots.cxx b/Modules/ZDC/src/ZDCRecBeautifyPlots.cxx index 01905d791f..3f9117515c 100644 --- a/Modules/ZDC/src/ZDCRecBeautifyPlots.cxx +++ b/Modules/ZDC/src/ZDCRecBeautifyPlots.cxx @@ -48,12 +48,6 @@ Quality ZDCRecBeautifyPlots::check(std::map mo, Quality checkResult) { if (mo->getName() == "h_CENTR_ZNA" || mo->getName() == "h_CENTR_ZNC" || mo->getName() == "h_CENTR_ZNA_cut_ZEM" || mo->getName() == "h_CENTR_ZNC_cut_ZEM") { diff --git a/Modules/ZDC/src/ZDCRecDataCheck.cxx b/Modules/ZDC/src/ZDCRecDataCheck.cxx index ac21faa4a3..f83bebb9ea 100644 --- a/Modules/ZDC/src/ZDCRecDataCheck.cxx +++ b/Modules/ZDC/src/ZDCRecDataCheck.cxx @@ -305,8 +305,6 @@ Quality ZDCRecDataCheck::check(std::map mo, Quality checkResult) { if (mo->getName() == "h_summary_ADC") {