From 6722f21161b856cdf1c16e73041b7c8fec6ce15c Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 13:43:04 +0800 Subject: [PATCH 01/11] Create CopilotReview --- .github/workflows/CopilotReview | 34 +++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 .github/workflows/CopilotReview diff --git a/.github/workflows/CopilotReview b/.github/workflows/CopilotReview new file mode 100644 index 00000000000..864aba738c1 --- /dev/null +++ b/.github/workflows/CopilotReview @@ -0,0 +1,34 @@ +name: Copilot Review + +on: + pull_request_target: + types: [opened, synchronize, labeled, unlabeled] + branches: + - main + +permissions: {} + +jobs: + copilot-code-review: + if: ${{ !contains(github.event.pull_request.labels.*.name, 'copilot-code-review') }} + runs-on: ubuntu-latest + permissions: + pull-requests: write + contents: read + steps: + - name: Check Init Event + env: + action: ${{ toJSON(github.event.action) }} + label: ${{ toJSON(github.event.label) }} + run: | + echo start review module + - name: Copilot PR Review + uses: AllyW/copilot-pr-review@v0.1.21 + with: + APIKEY: ${{ secrets.APIKEY }} + ENDPOINT: ${{ secrets.ENDPOINT }} + AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + PR_EVENT: ${{ toJSON(github.event) }} + code_suggest: True + pr_summary: True + pr_reset: True From 8ffc2252960219c3d37406d0664a5d7987352fa1 Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 15:28:50 +0800 Subject: [PATCH 02/11] Update and rename CopilotReview to CopilotReview.yml --- .github/workflows/{CopilotReview => CopilotReview.yml} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename .github/workflows/{CopilotReview => CopilotReview.yml} (90%) diff --git a/.github/workflows/CopilotReview b/.github/workflows/CopilotReview.yml similarity index 90% rename from .github/workflows/CopilotReview rename to .github/workflows/CopilotReview.yml index 864aba738c1..e9aa2aa7676 100644 --- a/.github/workflows/CopilotReview +++ b/.github/workflows/CopilotReview.yml @@ -10,7 +10,7 @@ permissions: {} jobs: copilot-code-review: - if: ${{ !contains(github.event.pull_request.labels.*.name, 'copilot-code-review') }} + if: ${{ contains(github.event.pull_request.labels.*.name, 'copilot-code-review') }} runs-on: ubuntu-latest permissions: pull-requests: write From 76bf1cc9627891c629f87e4f0c58484cfe15714e Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 15:34:11 +0800 Subject: [PATCH 03/11] Update CopilotReview.yml --- .github/workflows/CopilotReview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CopilotReview.yml b/.github/workflows/CopilotReview.yml index e9aa2aa7676..427b99ea1a3 100644 --- a/.github/workflows/CopilotReview.yml +++ b/.github/workflows/CopilotReview.yml @@ -23,7 +23,7 @@ jobs: run: | echo start review module - name: Copilot PR Review - uses: AllyW/copilot-pr-review@v0.1.21 + uses: AllyW/copilot-pr-review@v0.1.22 with: APIKEY: ${{ secrets.APIKEY }} ENDPOINT: ${{ secrets.ENDPOINT }} From 45e1aa49b9a7f44a7c69664895f67228c76b0f5d Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 15:49:02 +0800 Subject: [PATCH 04/11] Update CopilotReview.yml --- .github/workflows/CopilotReview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CopilotReview.yml b/.github/workflows/CopilotReview.yml index 427b99ea1a3..404288b6254 100644 --- a/.github/workflows/CopilotReview.yml +++ b/.github/workflows/CopilotReview.yml @@ -23,7 +23,7 @@ jobs: run: | echo start review module - name: Copilot PR Review - uses: AllyW/copilot-pr-review@v0.1.22 + uses: AllyW/copilot-pr-review@v0.1.23 with: APIKEY: ${{ secrets.APIKEY }} ENDPOINT: ${{ secrets.ENDPOINT }} From 35b0492a0740aab570ebfcee2be737e02934a900 Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 15:59:48 +0800 Subject: [PATCH 05/11] Update CopilotReview.yml --- .github/workflows/CopilotReview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CopilotReview.yml b/.github/workflows/CopilotReview.yml index 404288b6254..94596228fe1 100644 --- a/.github/workflows/CopilotReview.yml +++ b/.github/workflows/CopilotReview.yml @@ -23,7 +23,7 @@ jobs: run: | echo start review module - name: Copilot PR Review - uses: AllyW/copilot-pr-review@v0.1.23 + uses: AllyW/copilot-pr-review@v0.1.24 with: APIKEY: ${{ secrets.APIKEY }} ENDPOINT: ${{ secrets.ENDPOINT }} From edefdbfd7257a8b61e32bb3aaccc7dd904fbd663 Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 16:19:57 +0800 Subject: [PATCH 06/11] Update CopilotReview.yml --- .github/workflows/CopilotReview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CopilotReview.yml b/.github/workflows/CopilotReview.yml index 94596228fe1..34465368024 100644 --- a/.github/workflows/CopilotReview.yml +++ b/.github/workflows/CopilotReview.yml @@ -23,7 +23,7 @@ jobs: run: | echo start review module - name: Copilot PR Review - uses: AllyW/copilot-pr-review@v0.1.24 + uses: AllyW/copilot-pr-review@v0.1.25 with: APIKEY: ${{ secrets.APIKEY }} ENDPOINT: ${{ secrets.ENDPOINT }} From 8199ad1b1d0185394a00dde52c8cd7b3d6a4f858 Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 16:29:02 +0800 Subject: [PATCH 07/11] Update CopilotReview.yml --- .github/workflows/CopilotReview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CopilotReview.yml b/.github/workflows/CopilotReview.yml index 34465368024..0f69e793756 100644 --- a/.github/workflows/CopilotReview.yml +++ b/.github/workflows/CopilotReview.yml @@ -23,7 +23,7 @@ jobs: run: | echo start review module - name: Copilot PR Review - uses: AllyW/copilot-pr-review@v0.1.25 + uses: AllyW/copilot-pr-review@v0.1.26 with: APIKEY: ${{ secrets.APIKEY }} ENDPOINT: ${{ secrets.ENDPOINT }} From bd9588ce2ba437c5201183417aa10a61423047a5 Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 16:33:32 +0800 Subject: [PATCH 08/11] Update CopilotReview.yml --- .github/workflows/CopilotReview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CopilotReview.yml b/.github/workflows/CopilotReview.yml index 0f69e793756..993fe8de3a1 100644 --- a/.github/workflows/CopilotReview.yml +++ b/.github/workflows/CopilotReview.yml @@ -23,7 +23,7 @@ jobs: run: | echo start review module - name: Copilot PR Review - uses: AllyW/copilot-pr-review@v0.1.26 + uses: AllyW/copilot-pr-review@v0.1.27 with: APIKEY: ${{ secrets.APIKEY }} ENDPOINT: ${{ secrets.ENDPOINT }} From 7d53ce1fcbf6813d8e937915dedd39751cff48ad Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 16:49:25 +0800 Subject: [PATCH 09/11] Update CopilotReview.yml --- .github/workflows/CopilotReview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CopilotReview.yml b/.github/workflows/CopilotReview.yml index 993fe8de3a1..6b2e4832210 100644 --- a/.github/workflows/CopilotReview.yml +++ b/.github/workflows/CopilotReview.yml @@ -23,7 +23,7 @@ jobs: run: | echo start review module - name: Copilot PR Review - uses: AllyW/copilot-pr-review@v0.1.27 + uses: AllyW/copilot-pr-review@v0.1.28 with: APIKEY: ${{ secrets.APIKEY }} ENDPOINT: ${{ secrets.ENDPOINT }} From d1295683f17a92328dae71fd0f224ad3599ecad4 Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 17:58:48 +0800 Subject: [PATCH 10/11] Update CopilotReview.yml --- .github/workflows/CopilotReview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CopilotReview.yml b/.github/workflows/CopilotReview.yml index 6b2e4832210..d8f850db52b 100644 --- a/.github/workflows/CopilotReview.yml +++ b/.github/workflows/CopilotReview.yml @@ -23,7 +23,7 @@ jobs: run: | echo start review module - name: Copilot PR Review - uses: AllyW/copilot-pr-review@v0.1.28 + uses: AllyW/copilot-pr-review@v0.1.29 with: APIKEY: ${{ secrets.APIKEY }} ENDPOINT: ${{ secrets.ENDPOINT }} From b207c87fd0289293de1def050cd2f97a90ff577e Mon Sep 17 00:00:00 2001 From: AllyW Date: Tue, 17 Sep 2024 18:31:51 +0800 Subject: [PATCH 11/11] adjust help message --- src/monitor-control-service/HISTORY.rst | 4 ++++ src/monitor-control-service/azext_amcs/_params.py | 4 ++-- src/monitor-control-service/setup.py | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/monitor-control-service/HISTORY.rst b/src/monitor-control-service/HISTORY.rst index 0fc3a4dc4a4..7ea5f2ec98f 100644 --- a/src/monitor-control-service/HISTORY.rst +++ b/src/monitor-control-service/HISTORY.rst @@ -2,6 +2,10 @@ Release History =============== +1.2.1 +++++++ +* Update help messages + 1.2.0 ++++++ * Update api-version to `2023-03-11` for sub cmds of `az monitor data-collection rule` diff --git a/src/monitor-control-service/azext_amcs/_params.py b/src/monitor-control-service/azext_amcs/_params.py index eb838f36c4e..44074a08609 100644 --- a/src/monitor-control-service/azext_amcs/_params.py +++ b/src/monitor-control-service/azext_amcs/_params.py @@ -22,9 +22,9 @@ def load_arguments(self, _): # pylint: disable=unused-argument c.argument('resource_uri', options_list=['--resource', '--resource-uri'], help='The identifier of the resource.') c.argument('association_name', options_list=['--name', '-n'], help='The name of the association.') - c.argument('description', help='Description of the association.') + c.argument('description', help='Description of the association.For more message, please check: https:learn.microsoft.com/en-us/cli/azure/monitor/data-collection/endpoint/association?view=azure-cli-latest#az-monitor-data-collection-endpoint-association-list') c.argument('rule_id', help='The resource ID of the data collection rule that is to be associated.') - c.argument('endpoint_id', help='The resource ID of the data collection endpoint that is to be associated.', + c.argument('endpoint_id', help='The resource ID of the data collection endpoint that is to be associated. Format like ', validator=validate_association_name_with_endpoint) c.argument('data_collection_rule_name', options_list=['--rule-name', '--data-collection-rule-name']) diff --git a/src/monitor-control-service/setup.py b/src/monitor-control-service/setup.py index cb6a0c5b1e9..3ada5c08d8d 100644 --- a/src/monitor-control-service/setup.py +++ b/src/monitor-control-service/setup.py @@ -10,7 +10,7 @@ from setuptools import setup, find_packages # HISTORY.rst entry. -VERSION = '1.2.0' +VERSION = '1.2.1' # The full list of classifiers is available at # https://pypi.python.org/pypi?%3Aaction=list_classifiers