Skip to content

force_console_behavior does not modify behavior #103

@codewithcheese

Description

@codewithcheese

Hi there, I am confused about the force_console_behavior function, it does not force any behavior itself, it simply returns the console master and progress bars. I can't tell if it is misnamed or this is a regression.

fastai ProgressCallback uses the master_bar imported from fastprogress, so to force console the master_bar and progress_bar variables should be updated.

The current implementation is:

#export
def force_console_behavior():
    "Return the console progress bars"
    return ConsoleMasterBar, ConsoleProgressBar

I would expect this instead:

#export
def force_console_behavior():
    master_bar = ConsoleMasterBar
    progress_bar = ConsoleProgressBar

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions