Skip to content

link text styling #48

@connectdotz

Description

@connectdotz

hi, I was able to use the styles={{text: {color:xxx}} to change all text colors, which is very cool, however there is a problem for link, the color of link got override by the text styles above. Looking at the code textContentRenderer, it seems that you did try to provide some override with the "styleName2", however for link, a nested renderer, it renders the actual link text with the default textContentRenderer and thus lost the link's style...

To make a long story short, I see couple of issues here and wanted to check with you before submitting PR to address them:

  1. the "text" style should be added to styles.js so people know they can use it to pass text style.
  2. allow nested renderers such as the link to pass its style info to the child renderer (maybe through state?). So the link renderer can set styleName2='link', or something like that, in the state, and the text renderer can then use it to provider correct override

is this something you will consider accepting?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions