PDC_LOG missing/removed?

[GitMensch]

When inspecting #172 I've recognized that this repo uses it much less than @wmcbrine's repo (which also don't use it in all methods).

Is there a reason for this?
Should all functions start with it?

[Bill-Gray]

I've used it on rare occasion. It's nice to have the capability there, for investigating particular bugs. I've added a PDC_LOG on an as-needed basis.

But for most debugging, I've used gdb. (Note that this fails with the Windows and DOS ports... at least, I've not managed to get Windows programs running under Wine to use gdb, though I gather it's possible.)

I would be willing to pull changes that involved adding PDC_LOG more widely. Such a change should be harmless and potentially helpful. But adding it is not on my list of priorities.

[GitMensch]

at least, I've not managed to get Windows programs running under Wine to use gdb, though I gather it's possible

Yes, use the gdb from mingw inside wine and you're good to go.

I would be willing to pull changes that involved adding PDC_LOG more widely.

As the initial question was about the ones that are already available upstream this is a valid answer. If they were "lost", then it wasn't done by purpose.

Ee leave this issue as "anybody pulls that in, please?"

[gvanem]

I would be willing to pull changes that involved adding PDC_LOG more widely

Why cannot PDC_LOG() be rewritten into a variadic macro? Or is pre-C99 compilers still assumed to exist?

[GitMensch]

So far PDCursesMod compiles fine also with GCC 4 and MSVC 2005.
This can be changed if its authors see enough benefit for a switch, but so far that doesn't seem to be the case.

Note that for some ports the dependency to a specific compiler feature may be reasonable, but PDC_LOG is a global thing.