node_set rules population selection

[ferdonline]

We don't seem to have a way to properly filter nodes according to the nodeset population selector..
The nodeset entries cannot be inspected to know which node population to open, and the Nodeset rule
is basically a no-op, which either return the same set if the provided node population matches, otherwise returns an empty set. We are left with the workaround of opening all the populations and run materialize against them all

libsonata/src/node_sets.cpp

Line 145 in 4795217

if (std::find(values_.begin(), values_.end(), np.name()) != values_.end()) {

A possibility could be to have a somewhat high level API, where we could have NodeSet objects, inspect them, and (why not) having a NodeStorage doing filtering on entries directly from them.

Some extras:
I see constructors copying values passed by rvalue-ref, which is not very idiomatic. Either copy from const-ref of move the rvalue-ref.. (Unless you want to force passing only rvalues?)

libsonata/src/node_sets.cpp

Line 140 in 4795217

explicit NodeSetBasicPopulation(std::vector<std::string>&& values)

Or even moving copies, instead of initializing from a const-ref

libsonata/src/node_sets.cpp

Line 304 in 4795217

NodeSetCompoundRule(std::string name, CompoundTargets targets)

[mgeplf]

For the first point, that could be added - it's not something that we've run into, so feel free to open a PR.

With respect to 'Some Extras', if you see things that can be improved, I would put those in another ticket, and, even better, in PR, so we can see the changes.

[mgeplf]

@ferdonline: Any update on this? Are you planning on adding the functionality you need?