-
Notifications
You must be signed in to change notification settings - Fork 40
Open
Description
Now that I'm looking more in-depth into the C# code, there are quite a few issues with it:
- Inconsistent Url encoding; sometimes with custom method, sometimes with HttpUtility.UrlEncode, and sometimes not at all
- Custom-handling of failed connections, instead of using HttpClient with Polly to handle faults
- Token generation is not cryptographically safe
- Response values are not Url decoded
- Ugly and inefficient response parsing
- Lots of public methods that should be private
- if the computer has multiple IP addresses, it may return the wrong one
- Exceptions are completely ignored!!
I've rewritten the class using .NET Core 3.1 using Nullables and standard code conventions. What would be the best way to submit the updated version? It does depend on a few other utility classes so it will need to be edited a bit for a sample, and HttpClient needs to be configured with Polly separately.
Metadata
Metadata
Assignees
Labels
No labels