Skip to content

Commit a37a3ba

Browse files
author
mdovgialo
committed
Merge branch 'dev/1_fixing_default_scale_and_scale_ticks' into 'development-fuw'
#1 better EEG scale default and ticks See merge request fuw_software/svarog2!1
2 parents 00cb09c + 9cc920e commit a37a3ba

File tree

4 files changed

+36
-9
lines changed

4 files changed

+36
-9
lines changed

svarog/src/main/java/org/signalml/app/model/components/ChannelsPlotOptionsModel.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ public ChannelsPlotOptionsModel(SignalPlot p) {
4242
public void reset(int numOfChannels) {
4343
channelsOptions = new ChannelPlotOptionsModel[numOfChannels];
4444
for (int i = 0; i < channelsOptions.length; i++) {
45-
channelsOptions[i] = new ChannelPlotOptionsModel(this, this.plot
46-
.getValueScaleRangeModel().getRealValue());
45+
double scale_value = this.plot.getValueScaleRangeModel().getRealValue();
46+
channelsOptions[i] = new ChannelPlotOptionsModel(this, scale_value);
4747
}
4848
}
4949

@@ -133,7 +133,10 @@ public int getVisibleChannelsCount() {
133133
public void stateChanged(ChangeEvent e) {
134134
Object source = e.getSource();
135135
if (source == plot.getValueScaleRangeModel())
136-
this.globalScaleChanged(plot.getValueScaleRangeModel().getRealValue());
136+
{
137+
double scale_value = plot.getValueScaleRangeModel().getRealValue();
138+
this.globalScaleChanged(scale_value);
139+
}
137140

138141
}
139142

svarog/src/main/java/org/signalml/app/view/signal/SignalPlot.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,8 +350,7 @@ public SourceChannel getSourceChannelFor(int index) {
350350

351351
public void initialize() throws SignalMLException {
352352

353-
calculateParameters();
354-
353+
calculateParameters();
355354
if (masterPlot == null) {
356355

357356
calculateVoltageZoomFactorRatio();
@@ -374,6 +373,7 @@ public void initialize() throws SignalMLException {
374373
}
375374
this.channelsPlotOptionsModel.reset(channelCount);
376375
calculateParameters();
376+
377377
}
378378

379379
/**
@@ -390,7 +390,7 @@ public double getVoltageZoomFactorRatioFor(int index) {
390390
v = ChannelFunction.EEG.getMaxValue(); //global voltage scale is for EEG by default
391391
else
392392
v = this.getSourceChannelFor(index).getFunction().getMaxValue();
393-
return ((1.0 / (condMaxValue(v) * 2)) * 0.95) / 100;
393+
return ((1.0 / (condMaxValue(v) * 2)) * 0.44) / 100;
394394
}
395395

396396
/**

svarog/src/main/java/org/signalml/app/view/signal/SignalPlotRowHeader.java

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public class SignalPlotRowHeader extends JComponent {
5959
/*
6060
* distance (in pixels) from value scale to its label
6161
*/
62-
private static final int LABEL_LINE_DISTANCE = 5;
62+
private static final int LABEL_LINE_DISTANCE = 10;
6363

6464
private boolean calculated = false;
6565

@@ -206,7 +206,7 @@ private void calculate(Graphics2D g) {
206206
sb.append("000...");
207207
} else {
208208

209-
while (pixelPerRowUnit <= 5) {
209+
while (pixelPerRowUnit <= 20) {
210210
pixelPerRowUnit *= 10;
211211
sb.append("0");
212212
}
@@ -255,11 +255,26 @@ protected void paintComponent(Graphics gOrig) {
255255
g.drawLine(size.width-SCALE_HORIZONTAL_LINE_WIDTH, viewportPoint.y,
256256
size.width-SCALE_HORIZONTAL_LINE_WIDTH, viewportPoint.y + viewportSize.height);
257257
int tickCnt = 1 + ((int)(((float)(viewportSize.height+1)) / pixelPerRowUnit));
258-
for (i=0; i<tickCnt; i++) {
258+
259+
for (i=0; i<tickCnt; i++) {
259260
y = viewportPoint.y + ((int)(i*pixelPerRowUnit));
260261
g.drawLine(size.width-SCALE_HORIZONTAL_LINE_WIDTH+1, y, size.width-1, y);
261262
}
262263
this.drawChannelsValueTicks(g, size);
264+
265+
266+
for (i=0; i<tickCnt; i++) {
267+
if (i%2 == 0)
268+
{
269+
g.setColor(Color.LIGHT_GRAY);
270+
}
271+
else
272+
{
273+
g.setColor(Color.BLACK);
274+
}
275+
y = viewportPoint.y + ((int)(i*pixelPerRowUnit));
276+
g.fillRect(size.width-2*SCALE_HORIZONTAL_LINE_WIDTH+1, y, SCALE_HORIZONTAL_LINE_WIDTH, (int)(pixelPerRowUnit));
277+
}
263278

264279

265280

svarog/src/main/java/org/signalml/app/view/signal/SignalView.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,10 @@ public void actionPerformed(ActionEvent e) {
503503
if (videoFrame != null) {
504504
videoFrame.addListener(new VideoFrameListener());
505505
}
506+
507+
//
508+
this.setSnapToPageMode(true);
509+
506510
}
507511

508512
private SignalPlot createSignalPlot(SignalPlot masterPlot) throws SignalMLException {
@@ -1091,6 +1095,10 @@ public void stateChanged(ChangeEvent e) {
10911095
JToggleButton snapToPageButton = new JToggleButton(getSnapToPageAction());
10921096
snapToPageButton.setHideActionText(true);
10931097
mainToolBar.add(snapToPageButton);
1098+
1099+
snapToPageButton.setSelected(true);
1100+
1101+
10941102
JToggleButton displayClockTimeButton = new JToggleButton(getDisplayClockTimeAction());
10951103
displayClockTimeButton.setHideActionText(true);
10961104
mainToolBar.add(displayClockTimeButton);
@@ -1112,6 +1120,7 @@ public void stateChanged(ChangeEvent e) {
11121120
filterSwitchButton.setSelectedIcon(IconUtils.loadClassPathIcon("org/signalml/app/icon/filteron.png"));
11131121
filterSwitchButton.setSelected(document.getMontage().isFiltered());
11141122
mainToolBar.add(filterSwitchButton);
1123+
11151124

11161125
}
11171126

0 commit comments

Comments
 (0)