Question for settings.php

[robertjensen]

Anybody remember the intended purpose of this line?

cinfdata/sym-files2/graphsettings.php

Line 80 in 91eb29f

$settings[$s_key] = str_replace('{'.$p_key.'}', $p_value, $settings[$s_key]);

[KennethNielsen]

No, and the git blame isn't particularly useful: "Initial commit"

https://github.com/CINF/cinfdata/blame/91eb29f8959df03499ff322a9af94fc63ea672bc/sym-files2/graphsettings.php#L80

It looks like some sort of transformation

[KennethNielsen]

Searching for uses yield this: https://github.com/CINF/cinfdata/search?q=plot_settings

where we can see that e.g. one of the callers is passing in a "xscale" as the second argument, which gets turned into $params

[KennethNielsen]

which is being generated by the line above, via date_xscale which is here:

cinfdata/common_functions_v2.php

Line 63 in 91eb29f

function date_xscale($from="",$to="",$defaulthours=24){

... ahhhh yes, now I remember.

This is the line that does the trick of formatting user provided parameters into the settings to make it possible to write {param_name} type variables in the settings XML file. It's probably a huge security whole BTW, but 🤷🏻

so, if params is an array, like it is is there is a date_scale, the the array has from and to values and you then replace all occurrences in {from} and {to} in the settings XML file with those values.

Wow that was a trip down memory lane. I remember being very proud when I implemented that, and apparently a little too arrogant to include a comment. Better if I was the only one who knew 🙄