From d0d14a55a416540d8282b7ad5f76e276272d51a4 Mon Sep 17 00:00:00 2001 From: Rahul Gurujala Date: Fri, 14 Oct 2022 18:22:22 +0530 Subject: [PATCH] # Optimisation * Replace unneeded comprehension with generator * Replace mutable default arguments with None --- validator/rule_pipe_validator.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/validator/rule_pipe_validator.py b/validator/rule_pipe_validator.py index 9530a96..c9b00fa 100644 --- a/validator/rule_pipe_validator.py +++ b/validator/rule_pipe_validator.py @@ -1,5 +1,7 @@ class RulePipeValidator: - def __init__(self, data, rules, rw=[]): + def __init__(self, data, rules, rw=None): + if rw is None: + rw = [] # data to validate self.data = data @@ -23,4 +25,4 @@ def get_errors(self): return self.errors_on_key def __contains__(self, item): - return any([type(rule) == item for rule in self.rules]) + return any(type(rule) == item for rule in self.rules)