How to upload files from memorystream?

[sezonis]

I am downloading images and uploading them to catbox from the stream themselves, I do not write to disk so everything is done in memory.

When I download the stream from (in this scenario) Telegram, and then put it in my wrapped class of catbox

public async Task<string?> UploadImageAsync(Stream memoryStream, string fileName) {
           return await CatBoxClient.UploadImage(new CatBox.NET.Requests.StreamUploadRequest() {
               Stream = memoryStream,
               FileName = fileName,
               UserHash = UserHash,
           });
       }
       

all is well until It is executed. I then get an error

   Failed to upload to catbox.moe. Reason: System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.IO.IOException: The response ended prematurely. at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) --- End of inner exception stack trace --- at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) at Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.<SendAsync>g__Core|5_0(HttpRequestMessage request, CancellationToken cancellationToken) at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.<SendAsync>g__Core|5_0(HttpRequestMessage request, CancellationToken cancellationToken) at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken) at CatBox.NET.Client.CatBoxClient.UploadImage(StreamUploadRequest fileUploadRequest, CancellationToken ct) at Http.WrappedCatboxClient.UploadImageAsync(MemoryStream memoryStream, String fileName) in the program`

I have no idea why this happens because when I save the stream to a file the picture is perfect and is exactly what I downloaded. If I upload a file from stream using OpenRead, it works sometimes but not always, but never works well with the image I just saved using the stream. I know that nothing is wrong with how I'm saving the image because if I drag the same file over manually to catbox it uploads it just fine.

Uploading through url also works flawlessly, just not when trying to use a memory stream directly, I always run into the System.IO.IOException: The response ended prematurely. exception.

Everything is executed as follows

using var stream = new MemoryStream();
var storage = await client.DownloadFileAsync(photo, stream);
var fileName = "";
//some code here that gets the extension of the file
try {
                        fileName = $"{photo.id}.{extenstion}";
                        var imageUpload =await Program.WrappedCatboxClient.UploadImage(stream,fileName);
                        if (imageUpload != null) {
                            Log.Debug($"Catbox response: {imageUpload}");
                            if (imageUpload != null) {
                                var resp = imageUpload; //stuff done here but redacted cause too long
                            }
                        }
                    } catch (Exception ex) {
                        Log.Error($"Failed to upload to catbox.moe. Reason: {ex.ToString()} with filename {fileName}");
                    }

The telegram client I am using is WTelegramClient Telegram. But I know it has nothing to do with the telegram client itself, but rather something else (you can prove me wrong if you like, I'd love to know the exact thing I'm doing wrong).

This just confuses me hard. The images are of type jpg.

[Kuinox]

You forgot to reset the position of the memory stream :p.

[sezonis]

Unfortunately even with resetting it back to 0 the same error happens

memoryStream.Seek(0, SeekOrigin.Begin); or memoryStream.Position = 0;

Which I find very weird

[Kuinox]

Can you post the code when you reset the position to 0 ?

[sezonis]

  public async Task<string?> UploadImageAsync(Stream memoryStream, string fileName) {
            memoryStream.Seek(0, SeekOrigin.Begin);
            return await CatBoxClient.UploadImage(new CatBox.NET.Requests.StreamUploadRequest() {
                Stream = memoryStream,
                FileName = fileName,
                UserHash = UserHash,
            });
        }

Tried both .Position and Seek, also tried instantiating a new memorystream beforehand incase the parameter was making the copy and not persisting on passing it. I must be doing it wrong for sure lol. I have also tried doing it before calling this instead of from within. But console says position is 0 all the time, before calling UploadImageAsync

[sezonis]

@Kuinox

After digging deeper and losing my mind for a bit, I have finally figured it out. Yes, my code was functional it had nothing to do with the code. Catbox.moe requires you to have a user agent set otherwise it closes the connection. Perhaps it was a recent addition. I solved this by injecting a user agent into the http client. I think the library should be updated to include a user agent by default. I am not sure if it accepts any user agent so you can give it a unique UA, or if it only accepts known ones like chrome, edge, firefox... etc.

But yea, that's how to fix the problem.

[ChaseDRedmon]

I'll look into this soon. If that's the case, maybe it's been a recent addition or change to their API because I haven't seen anything related to setting a user agent in the documentation they have.