Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Further simplify command classes? #17

@ffflick-gh

Description

@ffflick-gh

The current BaseCommand and SubCommand classes are basically the same with very small differences. Would it be better to just combine them into one Command class? It would simplify a lot of logic....

For getParent and getBase, they would simply return undefined for base commands. They could also be turned into getters/setters to make it simpler.

Try and see if the chip property for BaseCommands can somehow be handled behind-the-scenes instead of having to specify it for every base command, because that would be great.

Other than that, everything is identical for BaseCommand and SubCommand.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions