-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Description
Expand on file documentation in the wiki (https://github.com/Cockatrice/Magic-Token/wiki#documentation) and create and curate a new page.
Also include info about structure, layout and sorting.
The example card comment is also probably better off in the wiki next to its explanation and further details, and only have a link to all doc resource in the token file instead:
https://github.com/Cockatrice/Magic-Token/blob/master/tokens.xml#L15-L32
Place a link in the readme.
Helpful infos and hints for potential guidelines:
- Sorting (a3838d9, 7a0f46f, 26ff452)
relatedbeforereverse-related, sorting (67a2d6c(#108))countbeforeexclude(543b96c(#108))spaces>tabsindentation (fb31047(#108))relatedvs.reverse-related
(AFR (and most of AFC) Tokens #108 (comment), Remove all <related> for <reverse-related> #119, --> 67b20ab)- Should there be a separate entry for single token creation in an X range?
If a card has several occurrences, there probably needs to be exclude tags?
When (or after all) to usecount="x=1"?
(MIC and MID Tokens #114 (comment), CLB Tokens #147 (review)) - Use
count="x=0"at all? (Trim token file down on not needed extra entries #102 + Remove x=0 values #101) - Alphabetical sorting detail (VOW Tokens #125 (comment))
- Chronological sorting for pictures for one token (newest at the top, MTGSON has a SetList file with metadata)
- Allow token without art? How to list them?
<set>SETCODE</set>vs.<set picURL="">SETCODE</set>?
(Kamigawa Tokens #134 --> remove misspellings of picURL #150, CLB Tokens #147 (comment)) - How to use placeholder for missing art? (VOW Tokens #125 (comment)), Do not use placeholder elements at all?
- Make e.g. sorting and reordering stuff of unrelated elements their own PRs, generally place unrealted changes in seperate PRs as noted in AFR (and most of AFC) Tokens #108
- List helpful search queries to find new token creators and relations: CLB Tokens #147 (comment), Streets of New Capenna tokens #141 (comment)
- Special characters needs to be escaped, e.g.
&, see CLB Tokens #147 (comment) - Order and structure in file for human friendliness: Move cmc element for 2/2 shapeshifter #153 (comment)
- more sorting cfb9ba9
- various checks and clean ups remove unused token relations #160
- card and set sorting sort sets and cards #165 (first draft and test for setup in ci: https://github.com/Cockatrice/Magic-Token/tree/tooomm-ci_sorting)
- Do not use x=1 (but only x) Add J22 Tokens #207
- Excludes for double entries add missing excludes for double entries #203
- Add MOM Tokens #222 (comment)
Metadata
Metadata
Assignees
Labels
No labels