Ticket 211 unknown user review (#214)

* fixing the merge conflicts so that you can refresh on reload

* ticket_211

---------

Co-authored-by: Jayden Carvajal <carvajal.ja@northeastern.edu>

Author: jaydencarvajal511

apps/backend/src/applications/applications.service.ts

@@ -409,7 +409,7 @@ export class ApplicationsService {
     const allApplicationsDto = await Promise.all(
       applications.map(async (app) => {
         const ratings = this.calculateAllRatings(app.reviews);
-            const stageProgress = this.determineStageProgress(app, app.reviews);
+        const stageProgress = this.determineStageProgress(app, app.reviews);
         const assignedRecruiters =
           await this.getAssignedRecruitersForApplication(app);
 
@@ -500,7 +500,10 @@ export class ApplicationsService {
    * submitted a review for that stage. If no recruiters are assigned, the
    * stage remains PENDING even if admins or others submit reviews.
    */
-  private determineStageProgress(app: Application, reviews: any[]): StageProgress {
+  private determineStageProgress(
+    app: Application,
+    reviews: any[],
+  ): StageProgress {
     const stage = app.stage;
 
     // Terminal stages are always completed
@@ -530,7 +533,9 @@ export class ApplicationsService {
       reviewerIdsForStage.has(id),
     );
 
-    return allAssignedReviewed ? StageProgress.COMPLETED : StageProgress.PENDING;
+    return allAssignedReviewed
+      ? StageProgress.COMPLETED
+      : StageProgress.PENDING;
   }
 
   /**

apps/backend/src/reviews/review.entity.ts

@@ -18,7 +18,13 @@ export class Review {
   @JoinColumn({ name: 'applicationId' })
   application: Application;
 
-  @ManyToOne(() => User, (user) => user.id)
+  // The relationship to User
+  @ManyToOne(() => User, { nullable: false })
+  @JoinColumn({ name: 'reviewerId' })
+  reviewer: User;
+
+  // The foreign key column
+  @Column({ nullable: false })
   reviewerId: number;
 
   @Column({ type: 'double precision', nullable: false })

apps/backend/src/testing/factories/user.factory.ts

@@ -15,7 +15,7 @@ export const defaultUser: User = {
   team: null,
   role: null,
   applications: [],
-  review: null,
+  reviews: [],
 };
 
 export const userFactory = (user: Partial<User> = {}): User =>

apps/backend/src/users/user.entity.ts

@@ -75,6 +75,6 @@ export class User {
   @OneToMany(() => Application, (application) => application.user)
   applications: Application[];
 
-  @OneToMany(() => Review, (review) => review.reviewerId)
-  review: Review;
+  @OneToMany(() => Review, (review) => review.reviewer)
+  reviews: Review[];
 }

apps/frontend/src/features/applications/components/ApplicationTables/individualApplication.tsx

@@ -47,6 +47,9 @@ const IndividualApplicationDetails = ({
   accessToken,
   onRefreshApplication,
 }: IndividualApplicationDetailsProps) => {
+  console.log('Full selectedApplication:', selectedApplication);
+  console.log('Reviews array:', selectedApplication.reviews);
+
   // Lighter purple accent tuned to match Figma palette
   const ACCENT = '#9B6CFF';
   // Assigned recruiters are managed by the AssignedRecruiters child component
@@ -90,6 +93,12 @@ const IndividualApplicationDetails = ({
     }
 
     try {
+      if (currentUser == null) {
+        throw new Error(
+          'the current user should not be null when trying to submit a review',
+        );
+      }
+
       // Submit review
       if (reviewRating && trimmedComment) {
         await apiClient.submitReview(accessToken, {