diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..e8bf0780 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,12 +1,14 @@ - + - + + My Library + + @@ -14,6 +16,7 @@ rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" /> + @@ -23,29 +26,31 @@

Library

Add books to your virtual library

-
-
- +
+ - + + - + + Library name="pages" required /> -
+ + +
- +
- + - - - - - - - +
Title AuthorNumber of PagesPages Read
diff --git a/debugging/book-library/readme.md b/debugging/book-library/readme.md index 3abe8c13..1a005fee 100644 --- a/debugging/book-library/readme.md +++ b/debugging/book-library/readme.md @@ -12,12 +12,12 @@ My website should be able to: ## Bugs to be fixed -1. Website loads but doesn't show any books -2. Error in console when you try to add a book -3. It uses the title name as the author name -4. Delete button is broken -5. When I add a book that I say I've read - it saves the wrong answer +1. Website loads but doesn't show any books. Done +2. Error in console when you try to add a book. Done +3. It uses the title name as the author name. Done +4. Delete button is broken. Done +5. When I add a book that I say I've read - it saves the wrong answer. Done -I think there are other some other small bugs in my code...but I'm lazy so I can't fix them all. +I think there are some other small bugs in my code...but I'm lazy so I can't fix them all. I wish somebody would help me! diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..edec18b0 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,103 +1,105 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", function () { populateStorage(); render(); + + // changed from form submit to button click + document.getElementById("addBookBtn").addEventListener("click", addBook); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true - ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); + if (myLibrary.length === 0) { + myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true)); + myLibrary.push(new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true)); } } -const title = document.getElementById("title"); +const bookTitle = document.getElementById("book-title"); const author = document.getElementById("author"); const pages = document.getElementById("pages"); const check = document.getElementById("check"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function -function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { +// renamed so we don’t conflict with form.submit() +function addBook() { + // Get and sanitize values once + const titleValue = bookTitle.value.trim(); + const authorValue = author.value.trim(); + const pagesValue = pages.value.trim(); + const isRead = check.checked; + + // Basic empty validation + if (!titleValue || !authorValue || !pagesValue) { alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); + return; } + + // Validate page number properly + const pagesNumber = Number(pagesValue); + if (!Number.isInteger(pagesNumber) || pagesNumber <= 0) { + alert("Please enter a valid positive page count!"); + return; + } + + // Create the book with sanitized values + const book = new Book(titleValue, authorValue, pagesNumber, isRead); + + // Save to library + myLibrary.push(book); + + // Re-render UI + render(); } -function Book(title, author, pages, check) { - this.title = title; - this.author = author; - this.pages = pages; - this.check = check; +function Book(titleValue, authorValue, pagesNumber, isRead) { + this.bookTitle = titleValue; + this.author = authorValue; + this.pages = pagesNumber; + this.check = isRead; } + function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { - table.deleteRow(n); - } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; + const table = document.getElementById("display"); + const tbody = table.querySelector("tbody"); + tbody.innerHTML = ""; // clear previous rows + + myLibrary.forEach((book, i) => { + const row = tbody.insertRow(); + + // Create ALL CELLS first (like original code) + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + + // Fill text cells + titleCell.textContent = book.bookTitle; + authorCell.textContent = book.author; + pagesCell.textContent = book.pages; + + // --- Read/Unread Button --- + const changeBut = document.createElement("button"); changeBut.className = "btn btn-success"; + changeBut.textContent = book.check ? "Yes" : "No"; wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; + + changeBut.addEventListener("click", () => { + book.check = !book.check; render(); }); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); + // --- Delete Button --- + const delBut = document.createElement("button"); delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + delBut.textContent = "Delete"; + deleteCell.appendChild(delBut); + + delBut.addEventListener("click", () => { + alert(`You've deleted: ${book.bookTitle}`); myLibrary.splice(i, 1); render(); }); - } + }); } diff --git a/debugging/book-library/style.css b/debugging/book-library/style.css index 302950cb..7a0b8d86 100644 --- a/debugging/book-library/style.css +++ b/debugging/book-library/style.css @@ -17,3 +17,9 @@ button.btn-info { margin: 20px; } + +@media (min-width: 576px) { + .jumbotron { + padding: 2rem 32px 2rem; + } +}