From 6cf78cb4a8a7c92a66bcd9e242223208df3d7078 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Sun, 7 Dec 2025 14:55:48 +0000 Subject: [PATCH 1/3] made some changes in script.js file to meet the rquirements --- debugging/book-library/script.js | 55 ++++++++++++-------------------- 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..a3487872 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -8,12 +8,7 @@ window.addEventListener("load", function (e) { function populateStorage() { if (myLibrary.length == 0) { let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true - ); + let book2 = new Book("The Old Man and the Sea","Ernest Hemingway","127",true); myLibrary.push(book1); myLibrary.push(book2); render(); @@ -28,19 +23,17 @@ const check = document.getElementById("check"); //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { + if (title.value === "" ||author.value === "" ||pages.value === "") { alert("Please fill all fields!"); return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + } + let book = new Book(title.value, author.value, pages.value, check.checked); + myLibrary.push(book); render(); - } + title.value = ""; + author.value = ""; + pages.value = ""; + check.checked = false; } function Book(title, author, pages, check) { @@ -54,12 +47,11 @@ function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n-- ){ table.deleteRow(n); } //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { + for (let i = 0; i < myLibrary.length; i++) { let row = table.insertRow(1); let titleCell = row.insertCell(0); let authorCell = row.insertCell(1); @@ -72,32 +64,25 @@ function render() { //add and wait for action for read/unread button let changeBut = document.createElement("button"); - changeBut.id = i; changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { + changeBut.innerText = myLibrary[i].check ? "Yes" : "No"; + changeBut.addEventListener ("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); - + wasReadCell.appendChild(changeBut); //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); + let delBut = document.createElement("button"); delBut.className = "btn btn-warning"; delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + + delBut.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); }); + + deleteCell.appendChild(delBut); } } + From 829111c1c2f0dfc27efd329cccfe1b86f37dd03b Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Mon, 8 Dec 2025 13:11:00 +0000 Subject: [PATCH 2/3] edit HTML,JS and CSS files to correct validation errors --- debugging/book-library/index.html | 94 ++++++++--------------- debugging/book-library/script.js | 123 +++++++++++++++--------------- debugging/book-library/style.css | 15 ++-- 3 files changed, 101 insertions(+), 131 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..9c580544 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,15 @@ - + - - - - - + + + My Book Library - + + @@ -23,50 +18,31 @@

Library

Add books to your virtual library

- -
-
+
+
- - - + + + + + - - - + + +
+ + +
+ +
@@ -75,21 +51,15 @@

Library

Title Author - Number of Pages + Pages Read - + Action - - - - - - - - - + + + diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index a3487872..c749d33e 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,88 +1,87 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", () => { populateStorage(); render(); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book("The Old Man and the Sea","Ernest Hemingway","127",true); - myLibrary.push(book1); - myLibrary.push(book2); - render(); + if (myLibrary.length === 0) { + myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true)); + myLibrary.push(new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true)); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readCheckbox = document.getElementById("check"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function function submit() { - if (title.value === "" ||author.value === "" ||pages.value === "") { - alert("Please fill all fields!"); - return false; - } - let book = new Book(title.value, author.value, pages.value, check.checked); - myLibrary.push(book); - render(); - title.value = ""; - author.value = ""; - pages.value = ""; - check.checked = false; + const title = titleInput.value.trim(); + const author = authorInput.value.trim(); + const pages = Number(pagesInput.value); + + if (!title || !author || !pagesInput.value) { + alert("Please fill all fields."); + return; + } + + if (Number.isNaN(pages) || pages <= 0) { + alert("Page count must be a positive number."); + return; + } + + const book = new Book(title, author, pages, readCheckbox.checked); + myLibrary.push(book); + render(); + + titleInput.value = ""; + authorInput.value = ""; + pagesInput.value = ""; + readCheckbox.checked = false; } -function Book(title, author, pages, check) { +function Book(title, author, pages, read) { this.title = title; this.author = author; this.pages = pages; - this.check = check; + this.read = read; } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- ){ - table.deleteRow(n); - } - //insert updated row and cells - for (let i = 0; i < myLibrary.length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + const table = document.getElementById("display"); + const tbody = table.tBodies[0]; - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.className = "btn btn-success"; - changeBut.innerText = myLibrary[i].check ? "Yes" : "No"; - changeBut.addEventListener ("click", function () { - myLibrary[i].check = !myLibrary[i].check; + // Clear table efficiently + tbody.innerHTML = ""; + + myLibrary.forEach((book, index) => { + const row = tbody.insertRow(); + + row.insertCell().textContent = book.title; + row.insertCell().textContent = book.author; + row.insertCell().textContent = book.pages; + + const readCell = row.insertCell(); + const toggleReadBtn = document.createElement("button"); + toggleReadBtn.className = "btn btn-success"; + toggleReadBtn.textContent = book.read ? "Yes" : "No"; + toggleReadBtn.addEventListener("click", () => { + book.read = !book.read; render(); }); - wasReadCell.appendChild(changeBut); - //add delete button to every row and render again - let delBut = document.createElement("button"); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; + readCell.appendChild(toggleReadBtn); - delBut.addEventListener("click", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); + const deleteCell = row.insertCell(); + const deleteBtn = document.createElement("button"); + deleteBtn.className = "btn btn-warning"; + deleteBtn.textContent = "Delete"; + deleteBtn.addEventListener("click", () => { + myLibrary.splice(index, 1); // delete first render(); + alert(`Deleted book: ${book.title}`); // then notify }); - - deleteCell.appendChild(delBut); - } -} - + deleteCell.appendChild(deleteBtn); + }); +} \ No newline at end of file diff --git a/debugging/book-library/style.css b/debugging/book-library/style.css index 302950cb..da9cfcdc 100644 --- a/debugging/book-library/style.css +++ b/debugging/book-library/style.css @@ -1,19 +1,20 @@ .form-group { width: 400px; - height: 300px; - align-self: left; - padding-left: 20px; +} + +button.btn-info { + margin: 20px; } .btn { display: block; + width: fit-content; } .form-check-label { - padding-left: 20px; - margin: 5px 0px 5px 0px; + margin-left: 5px; } -button.btn-info { - margin: 20px; +table { + margin-top: 20px; } From d7df43f0da45be2006df163299a3a24b9a15fd51 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Tue, 9 Dec 2025 14:49:27 +0000 Subject: [PATCH 3/3] changes some lines to validate pages correctly, grouped cell creation and prevent any invalid book to be added --- debugging/book-library/script.js | 80 ++++++++++++++++++-------------- 1 file changed, 44 insertions(+), 36 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index c749d33e..da440fd4 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -7,7 +7,7 @@ window.addEventListener("load", () => { function populateStorage() { if (myLibrary.length === 0) { - myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true)); + myLibrary.push(new Book("Robison Crusoe", "Daniel Defoe", 252, true)); myLibrary.push(new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true)); } } @@ -15,73 +15,81 @@ function populateStorage() { const titleInput = document.getElementById("title"); const authorInput = document.getElementById("author"); const pagesInput = document.getElementById("pages"); -const readCheckbox = document.getElementById("check"); +const checkInput = document.getElementById("check"); function submit() { - const title = titleInput.value.trim(); - const author = authorInput.value.trim(); - const pages = Number(pagesInput.value); + const titleValue = titleInput.value.trim(); + const authorValue = authorInput.value.trim(); + const pagesValue = pagesInput.value.trim(); - if (!title || !author || !pagesInput.value) { - alert("Please fill all fields."); + if (!titleValue || !authorValue || !pagesValue) { + alert("Please fill all fields!"); return; } - if (Number.isNaN(pages) || pages <= 0) { - alert("Page count must be a positive number."); + const pagesNumber = Number(pagesValue); + if (!Number.isInteger(pagesNumber) || pagesNumber <= 0) { + alert("Pages must be a positive whole number!"); return; } - const book = new Book(title, author, pages, readCheckbox.checked); + const book = new Book(titleValue, authorValue, pagesNumber, checkInput.checked); myLibrary.push(book); + render(); + clearForm(); +} +function clearForm() { titleInput.value = ""; authorInput.value = ""; pagesInput.value = ""; - readCheckbox.checked = false; + checkInput.checked = false; } -function Book(title, author, pages, read) { +function Book(title, author, pages, check) { this.title = title; this.author = author; this.pages = pages; - this.read = read; + this.check = check; } function render() { const table = document.getElementById("display"); - const tbody = table.tBodies[0]; - - // Clear table efficiently + const tbody = table.querySelector("tbody"); tbody.innerHTML = ""; - myLibrary.forEach((book, index) => { + myLibrary.forEach((book, i) => { const row = tbody.insertRow(); - row.insertCell().textContent = book.title; - row.insertCell().textContent = book.author; - row.insertCell().textContent = book.pages; - + const titleCell = row.insertCell(); + const authorCell = row.insertCell(); + const pagesCell = row.insertCell(); const readCell = row.insertCell(); - const toggleReadBtn = document.createElement("button"); - toggleReadBtn.className = "btn btn-success"; - toggleReadBtn.textContent = book.read ? "Yes" : "No"; - toggleReadBtn.addEventListener("click", () => { - book.read = !book.read; + const deleteCell = row.insertCell(); + + titleCell.textContent = book.title; + authorCell.textContent = book.author; + pagesCell.textContent = book.pages; + + const toggleBtn = document.createElement("button"); + toggleBtn.className = "btn btn-success"; + toggleBtn.textContent = book.check ? "Yes" : "No"; + toggleBtn.addEventListener("click", () => { + book.check = !book.check; render(); }); - readCell.appendChild(toggleReadBtn); + readCell.appendChild(toggleBtn); - const deleteCell = row.insertCell(); - const deleteBtn = document.createElement("button"); - deleteBtn.className = "btn btn-warning"; - deleteBtn.textContent = "Delete"; - deleteBtn.addEventListener("click", () => { - myLibrary.splice(index, 1); // delete first + const delBtn = document.createElement("button"); + delBtn.className = "btn btn-warning"; + delBtn.textContent = "Delete"; + delBtn.addEventListener("click", () => { + const deletedTitle = book.title; + myLibrary.splice(i, 1); render(); - alert(`Deleted book: ${book.title}`); // then notify + alert(`You've deleted: ${deletedTitle}`); }); - deleteCell.appendChild(deleteBtn); + deleteCell.appendChild(delBtn); }); -} \ No newline at end of file +}