diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..daf791d1 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,13 @@ - + - - + Book Library + - - + + @@ -31,20 +24,20 @@

Library

+ > + > Library id="pages" name="pages" required - /> + > + onclick="addBook();" + >
@@ -93,4 +86,4 @@

Library

- + diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..d728a934 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -7,16 +7,15 @@ window.addEventListener("load", function (e) { function populateStorage() { if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); + let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true); let book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", - "127", + 127, true ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); + myLibrary.push(book1,book2); + } } @@ -27,20 +26,31 @@ const check = document.getElementById("check"); //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function -function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { - alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); +function addBook() { + const sanitizedTitle = title.value.trim(); + const sanitizedAuthor = author.value.trim(); + const sanitizedPages = Number(pages.value); + const isRead = check.checked; + + if (!sanitizedTitle || !sanitizedAuthor) { + alert("Title and author cannot be empty."); + return; + } + + if (!Number.isInteger(sanitizedPages) || sanitizedPages <= 0) { + alert("Pages must be a positive whole number."); + return; } + + const book = new Book( + sanitizedTitle, + sanitizedAuthor, + sanitizedPages, + isRead + ); + + myLibrary.push(book); + render(); } function Book(title, author, pages, check) { @@ -54,47 +64,41 @@ function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { - table.deleteRow(n); - } + const tbody = table.querySelector("tbody"); + tbody.innerHTML = ""; + //insert updated row and cells let length = myLibrary.length; for (let i = 0; i < length; i++) { - let row = table.insertRow(1); + let row = tbody.insertRow(); let titleCell = row.insertCell(0); let authorCell = row.insertCell(1); let pagesCell = row.insertCell(2); let wasReadCell = row.insertCell(3); let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; - render(); - }); + titleCell.textContent = myLibrary[i].title; + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; + + + let toggleReadBtn = document.createElement("button"); + toggleReadBtn.className = "btn btn-success"; + toggleReadBtn.innerText = myLibrary[i].check ? "Yes" : "No"; // ternary operator + wasReadCell.appendChild(toggleReadBtn); + + toggleReadBtn.addEventListener("click", function () { + myLibrary[i].check = !myLibrary[i].check; + render(); +}); + //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + let deleteBtn = document.createElement("button"); + deleteBtn.dataset.index = i; + deleteCell.appendChild(deleteBtn); + deleteBtn.className = "btn btn-warning"; + deleteBtn.textContent = "Delete"; + deleteBtn.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render();