From 1ce7aac2ec228cd788169dada6d7a5e1712aaf77 Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Wed, 23 Jul 2025 15:19:33 +0100 Subject: [PATCH 01/11] Test PR --- Wireframe/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Wireframe/index.html b/Wireframe/index.html index 0e014e535..07774303e 100644 --- a/Wireframe/index.html +++ b/Wireframe/index.html @@ -10,7 +10,7 @@

Wireframe

- This is the default, provided code and no changes have been made yet. + This is the default, provided code and some changes have been made.

From fe76d0dc048c98eeae68f0f0b82b3eab35c7c3ec Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Wed, 23 Jul 2025 16:46:54 +0100 Subject: [PATCH 02/11] WIP action --- .github/workflows/validate-pr-metadata.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 .github/workflows/validate-pr-metadata.yml diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml new file mode 100644 index 000000000..f066fe730 --- /dev/null +++ b/.github/workflows/validate-pr-metadata.yml @@ -0,0 +1,19 @@ +name: Validate PR Metadata +on: + pull_request: + workflow_dispatch: + # TODO: Also on: Title edit, label change, promote from draft. + +jobs: + validate_pr_metadata: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: Get PR Metadata + run: gh pr view --json number,url > /tmp/pr-metadata.json + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Validate PR Metadata + run: curl --fai -o /tmp/validator https://reich.illicitonion.com/dump/20250723/pr-metadata-validator && chmod 0755 /tmp/validator && /tmp/validator /tmp/pr-metadata.json + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 8e0c8e4c36627a12e4e97b8fb512c2c9e882e6f5 Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Wed, 23 Jul 2025 17:11:02 +0100 Subject: [PATCH 03/11] Update bin --- .github/workflows/validate-pr-metadata.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml index f066fe730..c32b24db5 100644 --- a/.github/workflows/validate-pr-metadata.yml +++ b/.github/workflows/validate-pr-metadata.yml @@ -1,19 +1,19 @@ name: Validate PR Metadata on: pull_request: - workflow_dispatch: - # TODO: Also on: Title edit, label change, promote from draft. + types: + - labeled + - unlabeled + - opened + - edited + - reopened jobs: validate_pr_metadata: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Get PR Metadata - run: gh pr view --json number,url > /tmp/pr-metadata.json - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Validate PR Metadata - run: curl --fai -o /tmp/validator https://reich.illicitonion.com/dump/20250723/pr-metadata-validator && chmod 0755 /tmp/validator && /tmp/validator /tmp/pr-metadata.json + run: curl --fai -o /tmp/validator https://reich.illicitonion.com/dump/20250723/pr-metadata-validator && chmod 0755 /tmp/validator && /tmp/validator ${{ github.event.pull_request.url }} env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 066aabd4247dbff54d71517fbdc773691bcea1aa Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Wed, 23 Jul 2025 17:13:30 +0100 Subject: [PATCH 04/11] Fix typo --- .github/workflows/validate-pr-metadata.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml index c32b24db5..63a97ee06 100644 --- a/.github/workflows/validate-pr-metadata.yml +++ b/.github/workflows/validate-pr-metadata.yml @@ -14,6 +14,6 @@ jobs: steps: - uses: actions/checkout@v4 - name: Validate PR Metadata - run: curl --fai -o /tmp/validator https://reich.illicitonion.com/dump/20250723/pr-metadata-validator && chmod 0755 /tmp/validator && /tmp/validator ${{ github.event.pull_request.url }} + run: curl --fail -o /tmp/validator https://reich.illicitonion.com/dump/20250723/pr-metadata-validator && chmod 0755 /tmp/validator && /tmp/validator ${{ github.event.pull_request.url }} env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 5c9ba494a06d7584850e438261f0c64ccc9532e7 Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Wed, 23 Jul 2025 17:15:14 +0100 Subject: [PATCH 05/11] Use HTML URL --- .github/workflows/validate-pr-metadata.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml index 63a97ee06..9368c7da2 100644 --- a/.github/workflows/validate-pr-metadata.yml +++ b/.github/workflows/validate-pr-metadata.yml @@ -14,6 +14,6 @@ jobs: steps: - uses: actions/checkout@v4 - name: Validate PR Metadata - run: curl --fail -o /tmp/validator https://reich.illicitonion.com/dump/20250723/pr-metadata-validator && chmod 0755 /tmp/validator && /tmp/validator ${{ github.event.pull_request.url }} + run: curl --fail -o /tmp/validator https://reich.illicitonion.com/dump/20250723/pr-metadata-validator && chmod 0755 /tmp/validator && /tmp/validator ${{ github.event.pull_request.html_url }} env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 58d8a9a250dacfc6d12736a5ca8510d4a7cdbbb1 Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Wed, 23 Jul 2025 21:48:34 +0100 Subject: [PATCH 06/11] Use released binary --- .github/workflows/validate-pr-metadata.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml index 9368c7da2..f8159b5b8 100644 --- a/.github/workflows/validate-pr-metadata.yml +++ b/.github/workflows/validate-pr-metadata.yml @@ -13,7 +13,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + - name: Download validator + run: curl --fail https://api.github.com/repos/CodeYourFuture/trainee-tracker/releases/latest | jq '.assets[] | select(.name == "pr-metadata-validator-musl").browser_download_url' | xargs curl --fail -L -o /tmp/pr-metadata-validator && chmod 0755 /tmp/pr-metadata-validator - name: Validate PR Metadata - run: curl --fail -o /tmp/validator https://reich.illicitonion.com/dump/20250723/pr-metadata-validator && chmod 0755 /tmp/validator && /tmp/validator ${{ github.event.pull_request.html_url }} + run: /tmp/pr-metadata-validator ${{ github.event.pull_request.html_url }} env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From bedb536c5278783cea7ad9b30d3eb835022c3d25 Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Wed, 23 Jul 2025 23:18:47 +0100 Subject: [PATCH 07/11] Update artifact name --- .github/workflows/validate-pr-metadata.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml index f8159b5b8..b2c78c1f4 100644 --- a/.github/workflows/validate-pr-metadata.yml +++ b/.github/workflows/validate-pr-metadata.yml @@ -14,7 +14,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Download validator - run: curl --fail https://api.github.com/repos/CodeYourFuture/trainee-tracker/releases/latest | jq '.assets[] | select(.name == "pr-metadata-validator-musl").browser_download_url' | xargs curl --fail -L -o /tmp/pr-metadata-validator && chmod 0755 /tmp/pr-metadata-validator + run: curl --fail https://api.github.com/repos/CodeYourFuture/trainee-tracker/releases/latest | jq '.assets[] | select(.name | startswith("pr-metadata-validator-musl-")).browser_download_url' | xargs curl --fail -L -o /tmp/pr-metadata-validator && chmod 0755 /tmp/pr-metadata-validator - name: Validate PR Metadata run: /tmp/pr-metadata-validator ${{ github.event.pull_request.html_url }} env: From 15c8f7727157d3e1e9d78a5d02e6c01f69169687 Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Thu, 24 Jul 2025 18:31:10 +0100 Subject: [PATCH 08/11] Try remote action --- .github/workflows/validate-pr-metadata.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml index b2c78c1f4..682f7c174 100644 --- a/.github/workflows/validate-pr-metadata.yml +++ b/.github/workflows/validate-pr-metadata.yml @@ -13,9 +13,4 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Download validator - run: curl --fail https://api.github.com/repos/CodeYourFuture/trainee-tracker/releases/latest | jq '.assets[] | select(.name | startswith("pr-metadata-validator-musl-")).browser_download_url' | xargs curl --fail -L -o /tmp/pr-metadata-validator && chmod 0755 /tmp/pr-metadata-validator - - name: Validate PR Metadata - run: /tmp/pr-metadata-validator ${{ github.event.pull_request.html_url }} - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - uses: illicitonion/CYF-actions@main From 6d0464dbb6519f18101531d73b4298999dca5a4e Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Thu, 24 Jul 2025 18:39:09 +0100 Subject: [PATCH 09/11] Fix path --- .github/workflows/validate-pr-metadata.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml index 682f7c174..9e2aefbfb 100644 --- a/.github/workflows/validate-pr-metadata.yml +++ b/.github/workflows/validate-pr-metadata.yml @@ -13,4 +13,4 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: illicitonion/CYF-actions@main + - uses: illicitonion/CYF-actions/validate-pr-metadata@main From 277d8355f220df8cd976faae3723180b45d5d6db Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Thu, 24 Jul 2025 18:46:36 +0100 Subject: [PATCH 10/11] Pass token --- .github/workflows/validate-pr-metadata.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml index 9e2aefbfb..ff2ceecac 100644 --- a/.github/workflows/validate-pr-metadata.yml +++ b/.github/workflows/validate-pr-metadata.yml @@ -14,3 +14,5 @@ jobs: steps: - uses: actions/checkout@v4 - uses: illicitonion/CYF-actions/validate-pr-metadata@main + with: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 59cbdc4a6ca7b6fea92a8e3ed68eaae8f8057a9c Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Thu, 24 Jul 2025 18:53:51 +0100 Subject: [PATCH 11/11] Update name --- .github/workflows/validate-pr-metadata.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-pr-metadata.yml b/.github/workflows/validate-pr-metadata.yml index ff2ceecac..b9690ef7c 100644 --- a/.github/workflows/validate-pr-metadata.yml +++ b/.github/workflows/validate-pr-metadata.yml @@ -15,4 +15,4 @@ jobs: - uses: actions/checkout@v4 - uses: illicitonion/CYF-actions/validate-pr-metadata@main with: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}