From 7a94f845006b467676eae2d12b762abfd720c0fd Mon Sep 17 00:00:00 2001
From: plaetor <asanij@gmail.com>
Date: Thu, 29 May 2025 00:25:22 +0100
Subject: [PATCH 1/9] added personal info section to get name and email

---
 Form-Controls/index.html | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 65a866cdb..c314b1f57 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -15,13 +15,31 @@ <h1>Product Pick</h1>
       <form>
         <!-- write your html here-->
         <!-- 
-          try writing out the requirements first as comments
-        this will also help you fill in your PR message later-->
+          - [ ] My form is semantic html.
+          - [ ] All inputs have associated labels.
+          - [ ] My Lighthouse Accessibility score is 100.
+          - [ ] I require a valid name. I have defined a valid name as a text string of two characters or more.
+          - [ ] I require a valid email.
+          - [ ] I require one colour from a defined set of 3 colours.
+          - [ ] I require one size from a defined set of 6 sizes.-->
+          <legend><h3>Personal Information</h3></legend>
+          <p>
+            <label for="firstname">Firstname:</label>
+            <input type="text" id="firstname" name="firstname" required minlength="2" />
+            <Label for="lastname">Lastname:</Label>
+            <input type="text" id="lastname" name="lastname" required minlength="2" />
+          </p>
+          <p>
+            <label for="email">Email:</label>
+            <input type="email" id="email" name="email" required />
+          </p>
+              
+            
       </form>
     </main>
     <footer>
       <!-- change to your name-->
-      <h2>By HOMEWORK SOLUTION</h2>
+      <h2>By Mustaf Asani</h2>
     </footer>
   </body>
 </html>

From c1706b8cd19bad5981b2fb7a4d2d46a633e5a727 Mon Sep 17 00:00:00 2001
From: plaetor <asanij@gmail.com>
Date: Thu, 29 May 2025 00:33:56 +0100
Subject: [PATCH 2/9] added product information drop downs

---
 Form-Controls/index.html | 41 +++++++++++++++++++++++++++++++---------
 1 file changed, 32 insertions(+), 9 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index c314b1f57..650b827f5 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -15,14 +15,15 @@ <h1>Product Pick</h1>
       <form>
         <!-- write your html here-->
         <!-- 
-          - [ ] My form is semantic html.
-          - [ ] All inputs have associated labels.
+          - [x] My form is semantic html.
+          - [x] All inputs have associated labels.
           - [ ] My Lighthouse Accessibility score is 100.
-          - [ ] I require a valid name. I have defined a valid name as a text string of two characters or more.
-          - [ ] I require a valid email.
-          - [ ] I require one colour from a defined set of 3 colours.
-          - [ ] I require one size from a defined set of 6 sizes.-->
-          <legend><h3>Personal Information</h3></legend>
+          - [x] I require a valid name. I have defined a valid name as a text string of two characters or more.
+          - [x] I require a valid email.
+          - [x] I require one colour from a defined set of 3 colours.
+          - [x] I require one size from a defined set of 6 sizes.-->
+          <fieldset>
+            <legend><h3>Personal Information</h3></legend>
           <p>
             <label for="firstname">Firstname:</label>
             <input type="text" id="firstname" name="firstname" required minlength="2" />
@@ -33,8 +34,30 @@ <h1>Product Pick</h1>
             <label for="email">Email:</label>
             <input type="email" id="email" name="email" required />
           </p>
-              
-            
+          </fieldset>   
+          <fieldset>
+            <legend><h3>Product Information</h3></legend>
+            <p>
+              <label for="colour">Colour:</label>
+              <select id="colour" name="colour" required>
+                <option value="" disabled selected>Select a colour</option>
+                <option value="red">Red</option>
+                <option value="green">Green</option>
+                <option value="blue">Blue</option>
+              </select>
+            </p>
+            <p>
+              <label for="size">Size:</label>
+              <select id="size" name="size" required>
+                <option value="" disabled selected>Select a size</option>
+                <option value="small">Small</option>
+                <option value="medium">Medium</option>
+                <option value="large">Large</option>
+                <option value="xlarge">X-Large</option>
+                <option value="xxlarge">XX-Large</option>
+              </select>
+            </p>
+          </fieldset> 
       </form>
     </main>
     <footer>

From 530ed3eb8d8293c5c4cc144d3f0e1049f7aa529f Mon Sep 17 00:00:00 2001
From: plaetor <asanij@gmail.com>
Date: Fri, 30 May 2025 21:42:40 +0100
Subject: [PATCH 3/9] changed h3 to h2 as per lighthouse recommendation

---
 Form-Controls/README.md  | 16 ++++++++--------
 Form-Controls/index.html |  4 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/Form-Controls/README.md b/Form-Controls/README.md
index bfcdf6c0b..54d27d2c5 100644
--- a/Form-Controls/README.md
+++ b/Form-Controls/README.md
@@ -30,18 +30,18 @@ Do not write a form action for this project.
 
 Let's write out our testable criteria. Check each one off as you complete it.
 
-- [ ] I have used HTML only.
+- [x] I have used HTML only.
 - [x] I have not used any CSS or JavaScript.
 
 ### HTML
 
-- [ ] My form is semantic html.
-- [ ] All inputs have associated labels.
-- [ ] My Lighthouse Accessibility score is 100.
-- [ ] I require a valid name. I have defined a valid name as a text string of two characters or more.
-- [ ] I require a valid email.
-- [ ] I require one colour from a defined set of 3 colours.
-- [ ] I require one size from a defined set of 6 sizes.
+- [x] My form is semantic html.
+- [x] All inputs have associated labels.
+- [x] My Lighthouse Accessibility score is 100.
+- [x] I require a valid name. I have defined a valid name as a text string of two characters or more.
+- [x] I require a valid email.
+- [x] I require one colour from a defined set of 3 colours.
+- [x] I require one size from a defined set of 6 sizes.
 
 ## Resources
 
diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 650b827f5..49f624915 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -23,7 +23,7 @@ <h1>Product Pick</h1>
           - [x] I require one colour from a defined set of 3 colours.
           - [x] I require one size from a defined set of 6 sizes.-->
           <fieldset>
-            <legend><h3>Personal Information</h3></legend>
+            <legend><h2>Personal Information</h2></legend>
           <p>
             <label for="firstname">Firstname:</label>
             <input type="text" id="firstname" name="firstname" required minlength="2" />
@@ -36,7 +36,7 @@ <h1>Product Pick</h1>
           </p>
           </fieldset>   
           <fieldset>
-            <legend><h3>Product Information</h3></legend>
+            <legend><h2>Product Information</h2></legend>
             <p>
               <label for="colour">Colour:</label>
               <select id="colour" name="colour" required>

From fea07a8376e2f5a211f91ef38c509ae4aa94a34a Mon Sep 17 00:00:00 2001
From: plaetor <asanij@gmail.com>
Date: Tue, 3 Jun 2025 01:02:53 +0100
Subject: [PATCH 4/9] removed requirements comments

---
 Form-Controls/index.html | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 49f624915..bfea46754 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -13,15 +13,6 @@ <h1>Product Pick</h1>
     </header>
     <main>
       <form>
-        <!-- write your html here-->
-        <!-- 
-          - [x] My form is semantic html.
-          - [x] All inputs have associated labels.
-          - [ ] My Lighthouse Accessibility score is 100.
-          - [x] I require a valid name. I have defined a valid name as a text string of two characters or more.
-          - [x] I require a valid email.
-          - [x] I require one colour from a defined set of 3 colours.
-          - [x] I require one size from a defined set of 6 sizes.-->
           <fieldset>
             <legend><h2>Personal Information</h2></legend>
           <p>

From 42f964612df93057bb65f8936e46c4288d526cca Mon Sep 17 00:00:00 2001
From: plaetor <asanij@gmail.com>
Date: Tue, 3 Jun 2025 01:05:35 +0100
Subject: [PATCH 5/9] added extra small option

---
 Form-Controls/index.html | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index bfea46754..e3101faab 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -41,6 +41,7 @@ <h1>Product Pick</h1>
               <label for="size">Size:</label>
               <select id="size" name="size" required>
                 <option value="" disabled selected>Select a size</option>
+                <option value="xsmall">X-Small</option>
                 <option value="small">Small</option>
                 <option value="medium">Medium</option>
                 <option value="large">Large</option>

From c0068d53c385db1154626401177d9a0476d2c36e Mon Sep 17 00:00:00 2001
From: plaetor <asanij@gmail.com>
Date: Tue, 3 Jun 2025 01:21:07 +0100
Subject: [PATCH 6/9] added validation to firstname and lastname to stop only
 spaces being submitted

---
 Form-Controls/index.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index e3101faab..24d474077 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -17,9 +17,9 @@ <h1>Product Pick</h1>
             <legend><h2>Personal Information</h2></legend>
           <p>
             <label for="firstname">Firstname:</label>
-            <input type="text" id="firstname" name="firstname" required minlength="2" />
+            <input type="text" id="firstname" pattern=".*\S.*" title="firstname must not be only spaces" name="firstname" required minlength="2" />
             <Label for="lastname">Lastname:</Label>
-            <input type="text" id="lastname" name="lastname" required minlength="2" />
+            <input type="text" id="lastname" pattern=".*\S.*" title="lastname must not be only spaces" name="lastname" required minlength="2" />
           </p>
           <p>
             <label for="email">Email:</label>

From a56975a22cf475fc55a5f7e45db2b1123c232109 Mon Sep 17 00:00:00 2001
From: plaetor <asanij@gmail.com>
Date: Mon, 6 Oct 2025 14:40:40 +0100
Subject: [PATCH 7/9] removed h2 tag from legend

---
 Form-Controls/index.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 24d474077..79b3aa3ac 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -14,7 +14,7 @@ <h1>Product Pick</h1>
     <main>
       <form>
           <fieldset>
-            <legend><h2>Personal Information</h2></legend>
+            <legend>Personal Information</legend>
           <p>
             <label for="firstname">Firstname:</label>
             <input type="text" id="firstname" pattern=".*\S.*" title="firstname must not be only spaces" name="firstname" required minlength="2" />
@@ -27,7 +27,7 @@ <h1>Product Pick</h1>
           </p>
           </fieldset>   
           <fieldset>
-            <legend><h2>Product Information</h2></legend>
+            <legend>Product Information</legend>
             <p>
               <label for="colour">Colour:</label>
               <select id="colour" name="colour" required>

From c306966699bc7d8a568127274a6b815818ce0249 Mon Sep 17 00:00:00 2001
From: plaetor <asanij@gmail.com>
Date: Mon, 6 Oct 2025 14:47:08 +0100
Subject: [PATCH 8/9] added sudmit button to help test validation

---
 Form-Controls/index.html | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 79b3aa3ac..a968f3e64 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -49,7 +49,8 @@ <h1>Product Pick</h1>
                 <option value="xxlarge">XX-Large</option>
               </select>
             </p>
-          </fieldset> 
+          </fieldset>
+          <button type="submit">Submit</button> 
       </form>
     </main>
     <footer>

From 4b89c847ad717e1a99e9164db48b320abf077546 Mon Sep 17 00:00:00 2001
From: plaetor <asanij@gmail.com>
Date: Mon, 6 Oct 2025 15:00:48 +0100
Subject: [PATCH 9/9] added a div tag to the input elements for layout

---
 Form-Controls/index.html | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index a968f3e64..14753305a 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -17,13 +17,14 @@ <h1>Product Pick</h1>
             <legend>Personal Information</legend>
           <p>
             <label for="firstname">Firstname:</label>
-            <input type="text" id="firstname" pattern=".*\S.*" title="firstname must not be only spaces" name="firstname" required minlength="2" />
-            <Label for="lastname">Lastname:</Label>
-            <input type="text" id="lastname" pattern=".*\S.*" title="lastname must not be only spaces" name="lastname" required minlength="2" />
+            <div><input type="text" id="firstname" pattern=".*\S.*" title="firstname must not be only spaces" name="firstname" required minlength="2" />
+                <Label for="lastname">Lastname:</Label>
+                <input type="text" id="lastname" pattern=".*\S.*" title="lastname must not be only spaces" name="lastname" required minlength="2" />
+            </div>
           </p>
           <p>
             <label for="email">Email:</label>
-            <input type="email" id="email" name="email" required />
+            <div><input type="email" id="email" name="email" required /></div>
           </p>
           </fieldset>   
           <fieldset>