Symbol display suggested changes.

[wiredmax]

Is there's a reason to the fact that the display code for Australian Dollar uses the ISO standard country code ISO 3166-1 alpha-2 instead of ISO 4217 for display of currency. ISO 4217 integrate in the two-first letters the of the ISO 3166-1 alpha-2. It think it would be more accurate to what is more used worldwide and supported.

   "symbol": {
            "default": {
                "display": "AU$",
                "code": "AU$"
            },
            "native": {
                "display": "$",
                "code": "$"
            }
        }

would be:

   "symbol": {
            "default": {
                "display": "AUD",
                "code": "AUD"
            },
            "native": {
                "display": "$",
                "code": "$"
            }
        }

Also why USD default with the US$ or USD$ and the native with only the dollar sign?

Example:

        "symbol": {
            "default": {
                "display": "USD",
                "code": "USD"
            },
            "native": {
                "display": "$",
                "code": "$"
            },
        }

I would like to push a pull request with theses changes also, do you agree on theses changes?

[benhodgson87]

Hey, thanks for contributing to this!

The symbol is only for display purposes, so it's open to following common (widely recognisable) conventions, rather than rigidly following absolute currency codes, which are separately available in each object.

The AUD decision came from a few other places where this has been seen used. I think AU$ is generally a fairly widely accepted and used symbol; http://simple.wikipedia.org/wiki/Australian_dollar

We'll always consider any PRs with suggestions of doing this better though.