Skip to content

Proposal - Track how many users are starting to write message and #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gkapkowski wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proposal - Track how many users are starting to write message and #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/Analytics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,42 @@ export const metamaskStatusChanged = (providerName, accounts) => {
);
}
};

export const messageInput = (account, value) => {
if (NODE_ENV === 'production' && REACT_APP_GOOGLE_ANALYTICS_ID) {
import('react-ga').then(({ default: ReactGA }) =>
ReactGA.event({
category: 'interactions',
action: 'message-input',
label: account,
value: value,
}),
);
}
};

export const messageSign = (account, value) => {
if (NODE_ENV === 'production' && REACT_APP_GOOGLE_ANALYTICS_ID) {
import('react-ga').then(({ default: ReactGA }) =>
ReactGA.event({
category: 'interactions',
action: 'message-sign',
label: account,
value: value,
}),
);
}
};

export const messageSent = (account, value) => {
if (NODE_ENV === 'production' && REACT_APP_GOOGLE_ANALYTICS_ID) {
import('react-ga').then(({ default: ReactGA }) =>
ReactGA.event({
category: 'interactions',
action: 'message-sent',
label: account,
value: value,
}),
);
}
};
35 changes: 27 additions & 8 deletions src/CommentForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import styled, { css } from 'styled-components';
import Context from './Context';
import Paw from './img/paw.svg';
import TranslationsContext from './Translations';
import { messageInput, messageSign, messageSent } from './Analytics';

export const CommentForm = styled.form`
position: relative;
Expand Down Expand Up @@ -135,7 +136,11 @@ export class TextAreaForm extends React.Component {

submitForm = async () => {
this.setState({ submitting: true });
messageSign(this.props.entity.id, this.state.comment);
await this.props.sendMessage(this.state.comment);
// This is not working properly, messageSent would be invoked even if user rejects the message
// TODO: refactor, low priority
// messageSent(this.props.entity.id, this.state.comment);
this.setState({ comment: '', submitting: false });
this.props.onSubmit && this.props.onSubmit();
};
Expand All @@ -155,7 +160,10 @@ export class TextAreaForm extends React.Component {
inputRef={inputRef}
placeholder={placeholder}
value={this.state.comment}
onChange={(e) => this.setState({ comment: e.target.value })}
onChange={(e) => {
this.setState({ comment: e.target.value });
messageInput(this.props.entity.id, e.target.value);
}}
onKeyPress={(e) => e.key === 'Enter' && e.ctrlKey && this.submitForm()}
/>
<MetamaskButton disabled={!this.state.submitting && !this.validate()} type="submit" />
Expand All @@ -178,10 +186,10 @@ export const ConnectedClubForm = ({ token, ...props }) => (

export const ConnectedCommentForm = ({ ...props }) => (
<Context.Consumer>
{({ feedStore: { sendMessage } }) => (
{({ feedStore: { sendMessage }, entityStore: { activeEntity } }) => (
<TranslationsContext.Consumer>
{({ commentPlaceholder }) => (
<TextAreaForm sendMessage={sendMessage} placeholder={commentPlaceholder} {...props} />
<TextAreaForm sendMessage={sendMessage} placeholder={commentPlaceholder} entity={activeEntity} {...props} />
)}
</TranslationsContext.Consumer>
)}
Expand All @@ -190,10 +198,15 @@ export const ConnectedCommentForm = ({ ...props }) => (

export const ConnectedReplyForm = ({ about, ...props }) => (
<Context.Consumer>
{({ feedStore: { reply } }) => (
{({ feedStore: { reply }, entityStore: { activeEntity } }) => (
<TranslationsContext.Consumer>
{({ replyPlaceholder }) => (
<TextAreaForm sendMessage={(message) => reply(message, about)} placeholder={replyPlaceholder} {...props} />
<TextAreaForm
sendMessage={(message) => reply(message, about)}
placeholder={replyPlaceholder}
entity={activeEntity}
{...props}
/>
)}
</TranslationsContext.Consumer>
)}
Expand All @@ -202,10 +215,11 @@ export const ConnectedReplyForm = ({ about, ...props }) => (

export const ConnectedLabelForm = ({ labelType, ...props }) => (
<Context.Consumer>
{({ feedStore: { label } }) => (
{({ feedStore: { label }, entityStore: { activeEntity } }) => (
<TextAreaForm
sendMessage={(message) => label(message, labelType)}
placeholder={`Set your ${labelType}`}
entity={activeEntity}
{...props}
/>
)}
Expand All @@ -214,8 +228,13 @@ export const ConnectedLabelForm = ({ labelType, ...props }) => (

export const ConnectedWriteToForm = ({ to, ...props }) => (
<Context.Consumer>
{({ feedStore: { writeTo } }) => (
<TextAreaForm placeholder={`Write to ${to.name}`} sendMessage={(message) => writeTo(message, to)} {...props} />
{({ feedStore: { writeTo }, entityStore: { activeEntity } }) => (
<TextAreaForm
placeholder={`Write to ${to.name}`}
sendMessage={(message) => writeTo(message, to)}
entity={activeEntity}
{...props}
/>
)}
</Context.Consumer>
);