DGL/Pugl crashes when showing X11 reparented window

[jmeekr]

Using the latest submodules in the imgui-template

https://github.com/DISTRHO/imgui-template-plugin

https://github.com/DISTRHO/DPF/tree/79e5339bef455583a4b5762addfd6578d4230f05
https://github.com/DISTRHO/pugl/tree/93c3d70fe15eba1ece029ca8b86eb0c953a40a6d

My plugins for clap and vst crash both in Bitwig and carla-single under X11 because of, I assume, reparenting the window.
The jack standalone seems to work.

I went to an older repository I had and checked the hashes:

https://github.com/DISTRHO/DPF/tree/4e63344dad5f1c81d6cb8a1323e258b733bb1c04
DISTRHO/pugl@e33b2f6

Changing to those commits, recompiling dpf, and recompiling the imgui template project, seems to work. I tried
to chase down which commit breaks it but it's kind of difficult to bisect.

[falkTX]

the update to pugl was mostly made in a single commit, I can guess it is the culprit.
best would be to build in debug mode and run the host through a debugger.

I dont have the crash myself, so have not noticed this. under which desktop and distro does this happen?

[jmeekr]

I am using Fedora 41, and i3wm. I'll try to a look a bit more into it today

[jmeekr]

Although this seems to be about pugl, the pugl demos do work, but I could crosspost there too if you think it's appropriate.

https://github.com/DISTRHO/pugl/blob/main/src/x11_gl.c#L73

This seems to be the line (in pugl) that keeps breaking on the DPF develop branch.

Running cmake . && make then running

carla-single native clap bin/d_info.clap

Will give

[dpf] createNextWindow 405 256 1.000000
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  12 (X_ConfigureWindow)
  Resource id in failed request:  0x0
  Serial number of failed request:  39
  Current serial number in output stream:  40
[carla] Carla assertion failure: "engine == nullptr" in file ../backend/CarlaHostImpl.hpp, line 87
[carla] Carla assertion failure: "! lib.canDelete" in file ../utils/CarlaLibCounter.hpp, line 46

I tried comparing the attributes that pugl sends for the glXFbchooseconf but I don't think those have
really changed. I have a hunch that it's the order of creating window/window properties before this
gets called (bad window invalid window parameter). So I've been running gdb with a breakpoint
on puglRealize

If I run Carla (the latest git version) and load the plugin(s) from there, it will load the UI for
the plugins.

For Reaper if I run as a seperate process it will give the same error. However if I run it as a native process
the plugins will work and load.

[dpf] createNextWindow 405 256 1.000000
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  12 (X_ConfigureWindow)
  Resource id in failed request:  0x0
  Serial number of failed request:  39
  Current serial number in output stream:  40
Jack: JackClient::kXRunCallback
[dpf] createNextWindow 405 256 1.000000

I've also tried to run in Gnome, and Gnome classic with the same experience.

The opengl defines seem to have updated at some point in dpf?

If you have recommendations I can try I would appreciate it. I'm not experienced with any of this workflow.

The most recent dpf commit that works is4900b15 which is pugl-upstream d4d964.

[jmeekr]

I have been trying to run the examples in a vm on the develop branch using Xubuntu 24, and all the available graphics drivers via kvm/qemu.

I still am unable to run examples I built.

I yanked the artifacts from the cmake build action ran last week, they also give the same response.

I have a feeling it could be an issue with mesa and my graphics card/drivers (Intel i915), which is why
I tried running with qxl and the other options, and specifying my cpu as a generic kvm cpu.

However all the tests, both in pugl, and in dpf/dgl pass, and I've tried using multiple options no cairo, no opengl,
etc.

The build on the main branch doesn't seem to require me to install libx11-dev in the vm, but develop does.

[falkTX]

This might be related 61b1dad
On some setups the initial size created was 0x0 which can cause crashes

Please update and check, thanks!

[TheOnlyJoey]

Have the same issue, in Reaper it crashes when i open and close the plugin a couple of times (free(): invalid pointer in puglX11GlDestroy), in Bitwig it either crashes or hangs during first opening the UI.

Debian with GNOME here (tested on Wayland and X11).

Also sidenote, the recent patches related to clap resizing now makes clap always crash for me upon loading.

0x00007fffc7c21480 in DISTRHO::UIExporter::getGeometryConstraints (this=0x0,
minimumWidth=@0x7ffffffeed2c: 32767, minimumHeight=@0x7ffffffeed28: 3351401832,
keepAspectRatio=@0x7ffffffeed27: false)
at /home/joey/Code/PDS-Client-New/Build/_deps/dpf-src/distrho/src/DistrhoUIInternal.hpp:113
113 const DGL_NAMESPACE::Size size(uiData->window->getGeometryConstraints(keepAspectRatio));
(gdb) bt
#0 0x00007fffc7c21480 in DISTRHO::UIExporter::getGeometryConstraints
(this=0x0, minimumWidth=@0x7ffffffeed2c: 32767, minimumHeight=@0x7ffffffeed28: 3351401832, keepAspectRatio=@0x7ffffffeed27: false)
at /home/foo/Code/foo-Client-New/Build/_deps/dpf-src/distrho/src/DistrhoUIInternal.hpp:113
#1 0x00007fffc7c2219f in DISTRHO::ClapUI::adjustSize
(this=0x11d04ff0, width=0x7ffffffeee10, height=0x7ffffffef010)
at /home/foo/Code/foo-Client-New/Build/_deps/dpf-src/distrho/src/DistrhoPluginCLAP.cpp:353
#2 0x00007fffc7c1bf09 in DISTRHO::clap_gui_adjust_size
(plugin=0x2eb3a80, width=0x7ffffffeee10, height=0x7ffffffef010)
at /home/foo/Code/foo-Client-New/Build/_deps/dpf-src/distrho/src/DistrhoPluginCLAP.cpp:2196

[falkTX]

does it happen with the example plugins or just your own?

[TheOnlyJoey]

Official examples as well, tested with d_states (clap)

Attached screenshot of the CLAP resize issue

[jmeekr]

On some setups the initial size created was 0x0 which can cause crashes

Still seems to be producing the same error with the latest commit.

Regarding commit: 61b1dad

I did spend some time trying to force width and height around there.

[TheOnlyJoey]

Double checked with tag 2ba9bea and no issue there with opening VST3, still has the puglX11GlDestroy invalid pointer on closing the plugin second time, investigating that now.

Edit: Clap still crashes on start on that tag

[TheOnlyJoey]

Ok ignore the re-open issue I mentioned (unrelated), but can confirm that CLAP and VST3 both refuse to open on bitwig with current develop. Same plugin's do open in reaper for me. (both d_states example and my own plugins).
This is happening for me both with a set resolution and with 0x0.

[falkTX]

I was able to reproduce this bug and investigated, was a regression in pugl.
Fixed in bbdcbf1

PR submitted to upstream pugl for the fix.

[jmeekr]

@falkTX

Thanks that seems to help. The example vst3s now seem to load in Reaper (native, dedicated, seperate), and the clap plugins seem to work with carla-single, and bitwig but maybe not Reaper. It's late so I'll try again later.

[TheOnlyJoey]

Seems to have fixed it for me! both CLAP and VST3 now work in Bitwig and Reaper under Linux! Thanks <3