From 80fbdf83ca0de41e3d062ba4d0eb72a89f21d071 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 10 Dec 2025 19:41:46 +0100 Subject: [PATCH 1/2] FIXED not staked nodes write log entries about service transactions. https://github.com/DMDcoin/diamond-node/issues/323 --- crates/ethcore/src/engines/hbbft/hbbft_engine.rs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/crates/ethcore/src/engines/hbbft/hbbft_engine.rs b/crates/ethcore/src/engines/hbbft/hbbft_engine.rs index b0fc2e614..60bb942fc 100644 --- a/crates/ethcore/src/engines/hbbft/hbbft_engine.rs +++ b/crates/ethcore/src/engines/hbbft/hbbft_engine.rs @@ -1211,12 +1211,10 @@ impl HoneyBadgerBFT { return Ok(()); } - self.hbbft_peers_service - .channel() - .send(HbbftConnectToPeersMessage::AnnounceAvailability)?; - - self.hbbft_peers_service - .send_message(HbbftConnectToPeersMessage::AnnounceOwnInternetAddress)?; + if self.is_staked() { + self.hbbft_peers_service.send_message(HbbftConnectToPeersMessage::AnnounceAvailability)?; + self.hbbft_peers_service.send_message(HbbftConnectToPeersMessage::AnnounceOwnInternetAddress)?; + } if self.should_connect_to_validator_set() { // we just keep those variables here, because we need them in the early_epoch_end_manager. From a3cc2b9670320b3a6c3354da3b958c07c278404c Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 10 Dec 2025 19:43:41 +0100 Subject: [PATCH 2/2] version update and changelog --- CHANGELOG.md | 3 ++- Cargo.lock | 4 ++-- Cargo.toml | 2 +- crates/util/version/Cargo.toml | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 623cba754..4676d01ff 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,11 +9,12 @@ ### RPC - [Gas price from contracts](https://github.com/DMDcoin/diamond-node/issues/159) -### Further stability improvements +### Further improvements - [FIXED: received transactions are getting pooled, if announced by another peer](https://github.com/DMDcoin/diamond-node/issues/304) - [FIXED: dropped transactions are getting pooled](https://github.com/DMDcoin/diamond-node/issues/303) - [FIXED: key generation can panic if faulty validators write malicious parts](https://github.com/DMDcoin/diamond-node/issues/100) - [FIXED: already included transactions are refretched from peers](https://github.com/DMDcoin/diamond-node/issues/196) +- [FIXED:not staked nodes write log entries about service transactions](https://github.com/DMDcoin/diamond-node/issues/323) - [Gracefull Node Shutdown: increase to 15 seconds](https://github.com/DMDcoin/diamond-node/issues/321) diff --git a/Cargo.lock b/Cargo.lock index d6d86f352..3fa0b15ac 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -850,7 +850,7 @@ dependencies = [ [[package]] name = "diamond-node" -version = "4.0.2-rc1" +version = "4.0.2-rc3" dependencies = [ "ansi_term 0.10.2", "atty", @@ -3579,7 +3579,7 @@ dependencies = [ [[package]] name = "parity-version" -version = "4.0.2-rc1" +version = "4.0.2-rc3" dependencies = [ "parity-bytes", "rlp", diff --git a/Cargo.toml b/Cargo.toml index 963b350a2..c283c8c90 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -2,7 +2,7 @@ description = "Diamond Node" name = "diamond-node" # NOTE Make sure to update util/version/Cargo.toml as well -version = "4.0.2-rc1" +version = "4.0.2-rc3" license = "GPL-3.0" authors = [ "bit.diamonds developers", diff --git a/crates/util/version/Cargo.toml b/crates/util/version/Cargo.toml index 45eee360f..12b6250c6 100644 --- a/crates/util/version/Cargo.toml +++ b/crates/util/version/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "parity-version" # NOTE: this value is used for OpenEthereum version string (via env CARGO_PKG_VERSION) -version = "4.0.2-rc1" +version = "4.0.2-rc3" authors = [ "bit.diamonds developers", "OpenEthereum developers",