Skip to content

Commit 211d394

Browse files
committed
More deduplication of effects
1 parent 78bc589 commit 211d394

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

src/hooks/useMergedPresets.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
} from "react-use";
88
import { normalizePresetMeta } from "@/lib/meta/meta";
99
import { isPlainObject } from "@/utils/object";
10-
import { coerceAnyTuning, usePresetBuilder } from "./usePresetBuilder";
10+
import { coerceAnyTuning, usePresetBuilder } from "@/hooks/usePresetBuilder";
1111

1212
export function useMergedPresets({
1313
presetMap,
@@ -188,20 +188,13 @@ export function useMergedPresets({
188188

189189
useEffect(() => {
190190
if (!selectedPreset) return;
191+
if (queuedPresetRef.current === selectedPreset) return;
191192
const resolved = resolveTuningByName(selectedPreset);
192193
if (resolved?.length) {
193194
setPreset(selectedPreset);
194195
}
195196
}, [mergedPresetMap, resolveTuningByName, selectedPreset, setPreset]);
196197

197-
useUpdateEffect(() => {
198-
if (!selectedPreset) return;
199-
const resolved = resolveTuningByName(selectedPreset);
200-
if (resolved?.length) {
201-
setPreset(selectedPreset);
202-
}
203-
}, [mergedPresetMap, selectedPreset, resolveTuningByName, setPreset]);
204-
205198
useUpdateEffect(() => {
206199
if (!selectedPreset) return;
207200
if (mergedPresetNames.includes(selectedPreset)) return;

0 commit comments

Comments
 (0)