Code revised with reactor

Applied rules:
 * TernaryConditionVariableAssignmentRector
 * SwitchNegatedTernaryRector

Author: DanProgs

lib/api/rest/v1/tlRestApi.class.php

@@ -362,7 +362,7 @@ public function getProjectTestPlans($idCard)
 
         if (! is_null($tproject)) {
             $items = $this->tprojectMgr->get_all_testplans($tproject[0]['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Project identified by '" . $idCard . "'!";
             $op['status'] = 'error';

lib/api/rest/v2/tlRestApi.class.php

@@ -479,7 +479,7 @@ public function getProjectTestPlans($idCard)
 
         if (! is_null($tproject)) {
             $items = $this->tprojectMgr->get_all_testplans($tproject['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Project identified by '" . $idCard . "'!";
             $op['status'] = 'error';
@@ -1513,7 +1513,7 @@ public function getPlanBuilds($idCard)
 
         if (! is_null($tplan)) {
             $items = $this->tplanMgr->get_builds($tplan['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Plan identified by '" . $idCard . "'!";
             $op['status'] = 'error';

lib/api/rest/v3/RestApi.class.php

@@ -440,7 +440,7 @@ public function getProjectTestPlans(Response $response, $idCard)
 
         if (! is_null($tproj)) {
             $items = $this->tprojectMgr->get_all_testplans($tproj['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Project identified by '" . $idCard . "'!";
             $op['status'] = 'error';
@@ -466,7 +466,7 @@ public function getPlanBuilds(Response $response, $idCard)
 
         if (! is_null($tplan)) {
             $items = $this->tplanMgr->get_builds($tplan['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Plan identified by API KEY:" .
                 $idCard['tplanApiKey'] . "";

lib/api/xmlrpc/v1/xmlrpc.class.php

@@ -587,7 +587,7 @@ protected function userHasRight($rightToCheck,
         }
 
         $tprojectid = intval($tprojectid);
-        $tplanid = ! is_null($tplanid) ? intval($tplanid) : - 1;
+        $tplanid = is_null($tplanid) ? - 1 : intval($tplanid);
 
         if ($tprojectid <= 0 && $tplanid > 0) {
             // get test project from test plan
@@ -1571,7 +1571,7 @@ protected function _checkTCIDAndTPIDValid($platformInfo = null,
     {
         $tplan_id = $this->args[self::$testPlanIDParamName];
         $tcase_id = $this->args[self::$testCaseIDParamName];
-        $platform_id = ! is_null($platformInfo) ? key($platformInfo) : null;
+        $platform_id = is_null($platformInfo) ? null : key($platformInfo);
 
         $filters = array(
             'exec_status' => "ALL",

lib/cfields/cfieldsExport.php

@@ -24,7 +24,7 @@
 $gui->page_title = lang_get('export_cfields');
 $gui->do_it = 1;
 $gui->nothing_todo_msg = '';
-$gui->goback_url = ! is_null($args->goback_url) ? $args->goback_url : '';
+$gui->goback_url = is_null($args->goback_url) ? '' : $args->goback_url;
 $gui->export_filename = is_null($args->export_filename) ? 'customFields.xml' : $args->export_filename;
 $gui->exportTypes = array(
     'XML' => 'XML'

lib/cfields/cfieldsImport.php

@@ -24,7 +24,7 @@
 
 $gui = new stdClass();
 $gui->page_title = lang_get('import_cfields');
-$gui->goback_url = ! is_null($args->goback_url) ? $args->goback_url : '';
+$gui->goback_url = is_null($args->goback_url) ? '' : $args->goback_url;
 $gui->file_check = array(
     'show_results' => 0,
     'status_ok' => 1,

lib/execute/execDashboard.php

@@ -216,7 +216,7 @@ function initializeGui(&$dbHandler, &$argsObj, &$cfgObj, &$tplanMgr)
         ));
 
     $dummy = $platformMgr->getLinkedToTestplan($argsObj->tplan_id);
-    $gui->has_platforms = ! is_null($dummy) ? 1 : 0;
+    $gui->has_platforms = is_null($dummy) ? 0 : 1;
 
     $gui->platform_info['id'] = 0;
     $gui->platform_info['name'] = '';

lib/execute/execExport.php

@@ -83,7 +83,7 @@ function initializeGui(&$argsObj, &$tplanMgr)
     );
     $guiObj->page_title = lang_get('export_execution_set');
     $guiObj->object_name = '';
-    $guiObj->goback_url = ! is_null($argsObj->goback_url) ? $argsObj->goback_url : '';
+    $guiObj->goback_url = is_null($argsObj->goback_url) ? '' : $argsObj->goback_url;
 
     $key2loop = array(
         'tproject',

lib/execute/execHistory.php

@@ -52,8 +52,8 @@
 }
 $gui->execSet = $tcaseMgr->getExecutionSet($args->tcase_id, null, $filters);
 
-$gui->warning_msg = (! is_null($gui->execSet)) ? '' : lang_get(
-    'tcase_never_executed');
+$gui->warning_msg = (is_null($gui->execSet)) ? lang_get(
+    'tcase_never_executed') : '';
 $gui->user_is_admin = ($args->user->globalRole->name == 'admin') ? true : false;
 
 $gui->execPlatformSet = null;
@@ -75,7 +75,7 @@
     $gui->attachments = getAttachments($db, $gui->execSet);
 }
 
-$gui->displayPlatformCol = ! is_null($gui->execPlatformSet) ? 1 : 0;
+$gui->displayPlatformCol = is_null($gui->execPlatformSet) ? 0 : 1;
 $gui->main_descr = lang_get('execution_history');
 $gui->detailed_descr = lang_get('test_case') . ' ' . $idCard;
 $gui->tcase_id = intval($args->tcase_id);

lib/execute/execPrint.php

@@ -24,7 +24,7 @@
 $args = initArgs();
 
 $gui = new stdClass();
-$gui->goback_url = ! is_null($args->goback_url) ? $args->goback_url : '';
+$gui->goback_url = is_null($args->goback_url) ? '' : $args->goback_url;
 $gui->page_title = '';
 
 if ($args->deleteAttachmentID > 0) {