Skip to content

Commit 8c46d96

Browse files
DanProgsDanProgs
committed
Code revised with reactor
Applied rules: * RemoveNullPropertyInitializationRector * RemoveAlwaysElseRector
1 parent 60f84f6 commit 8c46d96

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+463
-528
lines changed

‎firstLogin.php‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,8 @@
5757
$url2go = "login.php?note=first";
5858
redirect(TL_BASE_HREF . $url2go);
5959
exit();
60-
} else {
61-
$message = getUserErrorMessage($result);
62-
}
60+
}
61+
$message = getUserErrorMessage($result);
6362
} else {
6463
$message = $rx['msg'];
6564
}

‎install/installStart.php‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,16 @@
22
/* TestLink Open Source Project - http://testlink.sourceforge.net/ */
33
/* $Id: installStart.php,v 1.2 2005/08/16 17:59:48 franciscom Exp $ */
44
$installationType = $_GET['installationType'];
5+
if ($installationType=='new') {
6+
header("Location: newInstallStart_TL.php");
7+
exit;
8+
}
59

6-
if($installationType=='new') {
7-
header("Location: newInstallStart_TL.php");
8-
exit;
9-
} elseif($installationType=='upgrade') {
10-
header("Location: upgradeStart.php");
11-
exit;
12-
} else {
10+
if ($installationType=='upgrade') {
11+
header("Location: upgradeStart.php");
12+
exit;
13+
}
14+
else {
1315
echo "No installationType found in \$_GET.";
1416
}
1517

‎lib/api/rest/v1/tlRestApi.class.php‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -48,40 +48,40 @@ class tlRestApi
4848
*
4949
* @access protected
5050
*/
51-
protected $db = null;
51+
protected $db;
5252

53-
protected $tables = null;
53+
protected $tables;
5454

55-
protected $tcaseMgr = null;
55+
protected $tcaseMgr;
5656

57-
protected $tprojectMgr = null;
57+
protected $tprojectMgr;
5858

59-
protected $tsuiteMgr = null;
59+
protected $tsuiteMgr;
6060

61-
protected $tplanMgr = null;
61+
protected $tplanMgr;
6262

63-
protected $tplanMetricsMgr = null;
63+
protected $tplanMetricsMgr;
6464

65-
protected $reqSpecMgr = null;
65+
protected $reqSpecMgr;
6666

67-
protected $reqMgr = null;
67+
protected $reqMgr;
6868

69-
protected $platformMgr = null;
69+
protected $platformMgr;
7070

7171
/**
7272
* userID associated with the apiKey provided
7373
*/
74-
protected $userID = null;
74+
protected $userID;
7575

7676
/**
7777
* UserObject associated with the userID
7878
*/
79-
protected $user = null;
79+
protected $user;
8080

8181
/**
8282
* array where all the args are stored for requests
8383
*/
84-
protected $args = null;
84+
protected $args;
8585

8686
/**
8787
* array where error codes and messages are stored
@@ -91,7 +91,7 @@ class tlRestApi
9191
/**
9292
* The api key being used to make a request
9393
*/
94-
protected $apiKey = null;
94+
protected $apiKey;
9595

9696
/**
9797
* boolean to allow a method to invoke another method and avoid double auth
@@ -107,9 +107,9 @@ class tlRestApi
107107
/**
108108
* _checkTCIDAndTPIDValid()
109109
*/
110-
protected $tcVersionID = null;
110+
protected $tcVersionID;
111111

112-
protected $versionNumber = null;
112+
protected $versionNumber;
113113

114114
public $statusCode;
115115

‎lib/api/rest/v2/tlRestApi.class.php‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -47,44 +47,44 @@ class tlRestApi
4747
*
4848
* @access protected
4949
*/
50-
protected $db = null;
50+
protected $db;
5151

52-
protected $tables = null;
52+
protected $tables;
5353

54-
protected $tcaseMgr = null;
54+
protected $tcaseMgr;
5555

56-
protected $tprojectMgr = null;
56+
protected $tprojectMgr;
5757

58-
protected $tsuiteMgr = null;
58+
protected $tsuiteMgr;
5959

60-
protected $tplanMgr = null;
60+
protected $tplanMgr;
6161

62-
protected $tplanMetricsMgr = null;
62+
protected $tplanMetricsMgr;
6363

64-
protected $reqSpecMgr = null;
64+
protected $reqSpecMgr;
6565

66-
protected $reqMgr = null;
66+
protected $reqMgr;
6767

68-
protected $platformMgr = null;
68+
protected $platformMgr;
6969

70-
protected $buildMgr = null;
70+
protected $buildMgr;
7171

72-
protected $cfieldMgr = null;
72+
protected $cfieldMgr;
7373

7474
/**
7575
* userID associated with the apiKey provided
7676
*/
77-
protected $userID = null;
77+
protected $userID;
7878

7979
/**
8080
* UserObject associated with the userID
8181
*/
82-
protected $user = null;
82+
protected $user;
8383

8484
/**
8585
* array where all the args are stored for requests
8686
*/
87-
protected $args = null;
87+
protected $args;
8888

8989
/**
9090
* array where error codes and messages are stored
@@ -94,7 +94,7 @@ class tlRestApi
9494
/**
9595
* The api key being used to make a request
9696
*/
97-
protected $apiKey = null;
97+
protected $apiKey;
9898

9999
/**
100100
* boolean to allow a method to invoke another method and avoid double auth
@@ -107,9 +107,9 @@ class tlRestApi
107107
/**
108108
* This value is setted in following method:
109109
*/
110-
protected $tcVersionID = null;
110+
protected $tcVersionID;
111111

112-
protected $versionNumber = null;
112+
protected $versionNumber;
113113

114114
protected $debugMsg;
115115

‎lib/api/rest/v3/RestApi.class.php‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -49,44 +49,44 @@ class RestApi
4949
*
5050
* @access protected
5151
*/
52-
protected $db = null;
52+
protected $db;
5353

54-
protected $tables = null;
54+
protected $tables;
5555

56-
protected $tcaseMgr = null;
56+
protected $tcaseMgr;
5757

58-
protected $tprojectMgr = null;
58+
protected $tprojectMgr;
5959

60-
protected $tsuiteMgr = null;
60+
protected $tsuiteMgr;
6161

62-
protected $tplanMgr = null;
62+
protected $tplanMgr;
6363

64-
protected $tplanMetricsMgr = null;
64+
protected $tplanMetricsMgr;
6565

66-
protected $reqSpecMgr = null;
66+
protected $reqSpecMgr;
6767

68-
protected $reqMgr = null;
68+
protected $reqMgr;
6969

70-
protected $platformMgr = null;
70+
protected $platformMgr;
7171

72-
protected $buildMgr = null;
72+
protected $buildMgr;
7373

74-
protected $cfieldMgr = null;
74+
protected $cfieldMgr;
7575

7676
/**
7777
* userID associated with the apiKey provided
7878
*/
79-
protected $userID = null;
79+
protected $userID;
8080

8181
/**
8282
* UserObject associated with the userID
8383
*/
84-
protected $user = null;
84+
protected $user;
8585

8686
/**
8787
* The api key being used to make a request
8888
*/
89-
protected $apiKey = null;
89+
protected $apiKey;
9090

9191
/**
9292
* boolean to allow a method to invoke another method and avoid double auth
@@ -99,9 +99,9 @@ class RestApi
9999
/**
100100
* This value is setted in following method:
101101
*/
102-
protected $tcVersionID = null;
102+
protected $tcVersionID;
103103

104-
protected $versionNumber = null;
104+
protected $versionNumber;
105105

106106
protected $debugMsg;
107107

0 commit comments

Comments
 (0)