From 18276658531f4a29d767878e9256634bd77b11dd Mon Sep 17 00:00:00 2001 From: CarlesDD Date: Tue, 6 May 2025 18:26:16 +0200 Subject: [PATCH 1/4] Dropping support for Node.js 16 --- .github/workflows/build.yml | 2 +- .github/workflows/release.yml | 2 +- package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d7f8ce93..8dfd9d54 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -32,7 +32,7 @@ jobs: postbuild: 'node scripts/postbuild' skip: 'linux-arm,linux-ia32' target-name: 'appsec' - min-node-version: 16 + min-node-version: 18 static-checks: strategy: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8ed91063..4c7890d0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -30,7 +30,7 @@ jobs: postbuild: 'node scripts/postbuild' skip: 'linux-arm,linux-ia32' target-name: 'appsec' - min-node-version: 16 + min-node-version: 18 pack: needs: build diff --git a/package.json b/package.json index 218ac838..d4326bd6 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ "node-gyp-build": "^3.9.0" }, "engines": { - "node": ">=16" + "node": ">=18" }, "files": [ "index.js", From b690d3334c794a176a3a1d796df656214fb667a0 Mon Sep 17 00:00:00 2001 From: CarlesDD Date: Tue, 6 May 2025 18:28:39 +0200 Subject: [PATCH 2/4] Amend README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a54655a8..0680011b 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,7 @@ Node.js bindings for [libddwaf](https://github.com/datadog/libddwaf). This package supports the following platforms: -* **Node.js version:** 16 and higher +* **Node.js version:** 18 and higher * **Operating Systems:** * MacOS * x64 From cb5f9dd32cabaddfa75e302bf268838df8ecac08 Mon Sep 17 00:00:00 2001 From: CarlesDD Date: Tue, 6 May 2025 18:28:54 +0200 Subject: [PATCH 3/4] Ammend comment --- src/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main.cpp b/src/main.cpp index 2a9696e8..2f5cd87a 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -2,7 +2,7 @@ * Unless explicitly stated otherwise all files in this repository are licensed under the Apache-2.0 License. * This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2021 Datadog, Inc. **/ -// min support Node.js 16.0.0 - https://nodejs.org/api/n-api.html#node-api-version-matrix +// min support Node.js 18.0.0 - https://nodejs.org/api/n-api.html#node-api-version-matrix #define NAPI_VERSION 8 #include #include From 6e504898af87bec2f099762e771b5db3ba145746 Mon Sep 17 00:00:00 2001 From: CarlesDD Date: Tue, 6 May 2025 18:31:01 +0200 Subject: [PATCH 4/4] Ammend package lock --- package-lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index c4c432af..91e23c5b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -24,7 +24,7 @@ "tar": "^6.1.11" }, "engines": { - "node": ">=16" + "node": ">=18" } }, "node_modules/@babel/code-frame": {