From 1f08c8eacf950b1984bef6639091a85772aa566c Mon Sep 17 00:00:00 2001 From: david <89749147+davight@users.noreply.github.com> Date: Tue, 13 Jan 2026 19:16:41 +0100 Subject: [PATCH 1/2] fix --- .../denizen/nms/v1_21/helpers/PacketHelperImpl.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/PacketHelperImpl.java b/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/PacketHelperImpl.java index 91c60ce77e..97651f391c 100644 --- a/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/PacketHelperImpl.java +++ b/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/PacketHelperImpl.java @@ -159,13 +159,11 @@ public void showTabListHeaderFooter(Player player, String header, String footer) @Override public void showTitle(Player player, String title, String subtitle, int fadeInTicks, int stayTicks, int fadeOutTicks) { - send(player, new ClientboundSetTitlesAnimationPacket(fadeInTicks, stayTicks, fadeOutTicks)); - if (title != null) { - send(player, new ClientboundSetTitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(title, ChatColor.WHITE)))); - } - if (subtitle != null) { - send(player, new ClientboundSetSubtitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(subtitle, ChatColor.WHITE)))); - } + send(player, new ClientboundBundlePacket(List.of( + new ClientboundSetTitlesAnimationPacket(fadeInTicks, stayTicks, fadeOutTicks), + new ClientboundSetTitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(title == null ? "" : title , ChatColor.WHITE))), + new ClientboundSetSubtitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(subtitle == null ? "" : subtitle, ChatColor.WHITE))) + ))); } @Override From acc677a5e5de54f1a36ec4f1217aac4fc4819ac8 Mon Sep 17 00:00:00 2001 From: david <89749147+davight@users.noreply.github.com> Date: Tue, 13 Jan 2026 22:22:34 +0100 Subject: [PATCH 2/2] fix v2 --- .../denizen/scripts/commands/player/TitleCommand.java | 2 +- .../denizen/nms/v1_21/helpers/PacketHelperImpl.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugin/src/main/java/com/denizenscript/denizen/scripts/commands/player/TitleCommand.java b/plugin/src/main/java/com/denizenscript/denizen/scripts/commands/player/TitleCommand.java index 21ddb49a67..0e85ea309f 100644 --- a/plugin/src/main/java/com/denizenscript/denizen/scripts/commands/player/TitleCommand.java +++ b/plugin/src/main/java/com/denizenscript/denizen/scripts/commands/player/TitleCommand.java @@ -95,6 +95,6 @@ public static void autoExecute(ScriptEntry scriptEntry, } public static String parse(ParseableTag tag, BukkitTagContext context) { - return tag == null ? null : tag.parse(context).toString(); + return tag == null ? "" : tag.parse(context).toString(); } } diff --git a/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/PacketHelperImpl.java b/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/PacketHelperImpl.java index 97651f391c..de8b320707 100644 --- a/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/PacketHelperImpl.java +++ b/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/PacketHelperImpl.java @@ -161,8 +161,8 @@ public void showTabListHeaderFooter(Player player, String header, String footer) public void showTitle(Player player, String title, String subtitle, int fadeInTicks, int stayTicks, int fadeOutTicks) { send(player, new ClientboundBundlePacket(List.of( new ClientboundSetTitlesAnimationPacket(fadeInTicks, stayTicks, fadeOutTicks), - new ClientboundSetTitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(title == null ? "" : title , ChatColor.WHITE))), - new ClientboundSetSubtitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(subtitle == null ? "" : subtitle, ChatColor.WHITE))) + new ClientboundSetTitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(title, ChatColor.WHITE))), + new ClientboundSetSubtitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(subtitle, ChatColor.WHITE))) ))); }