From 4646de893e7906dbbfe5bf4f4d759068cb6bc7c5 Mon Sep 17 00:00:00 2001 From: Domingo Perez Date: Wed, 10 Aug 2022 16:47:50 +0100 Subject: [PATCH 1/4] Add yml file with garments sizes --- src/main/java/com/github/javafaker/Faker.java | 4 ++++ src/main/resources/en/garments_sizes.yml | 4 ++++ 2 files changed, 8 insertions(+) create mode 100644 src/main/resources/en/garments_sizes.yml diff --git a/src/main/java/com/github/javafaker/Faker.java b/src/main/java/com/github/javafaker/Faker.java index 751fb779..185e7979 100644 --- a/src/main/java/com/github/javafaker/Faker.java +++ b/src/main/java/com/github/javafaker/Faker.java @@ -46,6 +46,7 @@ public class Faker { private final Finance finance; private final Food food; private final GameOfThrones gameOfThrones; + private final GarmentSize garmentSize; private final Gender gender; private final DateAndTime dateAndTime; private final Demographic demographic; @@ -162,6 +163,7 @@ public Faker(FakeValuesService fakeValuesService, RandomService random) { this.finance = new Finance(this); this.food = new Food(this); this.gameOfThrones = new GameOfThrones(this); + this.garmentSize = new GarmentSize(this); this.gender = new Gender(this); this.dateAndTime = new DateAndTime(this); this.demographic = new Demographic(this); @@ -471,6 +473,8 @@ public GameOfThrones gameOfThrones() { return gameOfThrones; } + public GarmentSize garmentSize() { return garmentSize; } + public Gender gender() { return gender; } diff --git a/src/main/resources/en/garments_sizes.yml b/src/main/resources/en/garments_sizes.yml new file mode 100644 index 00000000..058417b3 --- /dev/null +++ b/src/main/resources/en/garments_sizes.yml @@ -0,0 +1,4 @@ +en: + faker: + garments: + sizes: ["XS", "S", "M", "L", "XL", "XXL", "XXXL"] \ No newline at end of file From 26049f8033aef59f3a9f898fcf9e692dfef33ef2 Mon Sep 17 00:00:00 2001 From: Domingo Perez Date: Wed, 10 Aug 2022 16:48:09 +0100 Subject: [PATCH 2/4] Register yml file in EnFile --- src/main/java/com/github/javafaker/service/files/EnFile.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/github/javafaker/service/files/EnFile.java b/src/main/java/com/github/javafaker/service/files/EnFile.java index 4a77ac01..7e8b2635 100644 --- a/src/main/java/com/github/javafaker/service/files/EnFile.java +++ b/src/main/java/com/github/javafaker/service/files/EnFile.java @@ -86,6 +86,7 @@ public String getPath() { "friends.yml", "funny_name.yml", "game_of_thrones.yml", + "garments_sizes.yml", "gender.yml", "ghostbusters.yml", "grateful_dead.yml", From a1784484e34b177488f4d89bb4bcc71e66dcbbf3 Mon Sep 17 00:00:00 2001 From: Domingo Perez Date: Wed, 10 Aug 2022 16:50:37 +0100 Subject: [PATCH 3/4] Add GarmentSize, unit test and integration test --- .../com/github/javafaker/GarmentSize.java | 26 +++++++++++++++++++ .../com/github/javafaker/GarmentSizeTest.java | 14 ++++++++++ .../github/javafaker/integration/FakerIT.java | 1 + 3 files changed, 41 insertions(+) create mode 100644 src/main/java/com/github/javafaker/GarmentSize.java create mode 100644 src/test/java/com/github/javafaker/GarmentSizeTest.java diff --git a/src/main/java/com/github/javafaker/GarmentSize.java b/src/main/java/com/github/javafaker/GarmentSize.java new file mode 100644 index 00000000..170847f1 --- /dev/null +++ b/src/main/java/com/github/javafaker/GarmentSize.java @@ -0,0 +1,26 @@ +package com.github.javafaker; + + +/** + * This class is used to generate garments sizes randomly. + * + */ + +public class GarmentSize { + private final Faker faker; + + protected GarmentSize(Faker faker) { + this.faker = faker; + } + + /** + * This method returns a garment size + * + * @return a string of garment size + */ + public String size() { + return faker.fakeValuesService().fetchString("garments.sizes"); + } + + +} diff --git a/src/test/java/com/github/javafaker/GarmentSizeTest.java b/src/test/java/com/github/javafaker/GarmentSizeTest.java new file mode 100644 index 00000000..36c75ddc --- /dev/null +++ b/src/test/java/com/github/javafaker/GarmentSizeTest.java @@ -0,0 +1,14 @@ +package com.github.javafaker; + + +import org.junit.Test; +import static com.github.javafaker.matchers.MatchesRegularExpression.matchesRegularExpression; +import static org.junit.Assert.assertThat; + +public class GarmentSizeTest extends AbstractFakerTest { + + @Test + public void sizes() { + assertThat(faker.garmentSize().size(), matchesRegularExpression("([A-Z]+)")); + } +} \ No newline at end of file diff --git a/src/test/java/com/github/javafaker/integration/FakerIT.java b/src/test/java/com/github/javafaker/integration/FakerIT.java index 07ddc89c..ae75d892 100644 --- a/src/test/java/com/github/javafaker/integration/FakerIT.java +++ b/src/test/java/com/github/javafaker/integration/FakerIT.java @@ -131,6 +131,7 @@ public void testAllFakerMethodsThatReturnStrings() throws Exception { testAllMethodsThatReturnStringsActuallyReturnStrings(faker.finance()); testAllMethodsThatReturnStringsActuallyReturnStrings(faker.food()); testAllMethodsThatReturnStringsActuallyReturnStrings(faker.gameOfThrones()); + testAllMethodsThatReturnStringsActuallyReturnStrings(faker.garmentSize()); testAllMethodsThatReturnStringsActuallyReturnStrings(faker.gender()); testAllMethodsThatReturnStringsActuallyReturnStrings(faker.hacker()); testAllMethodsThatReturnStringsActuallyReturnStrings(faker.idNumber()); From bfeea916cb69097e8c069deb89f9d19c11951a8d Mon Sep 17 00:00:00 2001 From: Domingo Perez Date: Wed, 10 Aug 2022 16:50:50 +0100 Subject: [PATCH 4/4] Add GarmentSize to README --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index d1385324..cb68b9fc 100644 --- a/README.md +++ b/README.md @@ -94,6 +94,7 @@ Fakers * Friends * FunnyName * GameOfThrones +* GarmentSize * Gender * Hacker * HarryPotter