some coderabbit suggestions, update pnpm to 10.15.1, remove some unneeded changes, comments

maparent · maparent · commit 7023fbf9ae6d · 2025-09-11T13:29:57.000-04:00
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -15,7 +15,7 @@ jobs:
       - uses: pnpm/action-setup@v4
         name: Install pnpm
         with:
-          version: 10.15.0
+          version: 10.15.1
           run_install: false
 
       - name: Setup Node.js environment
@@ -25,7 +25,7 @@ jobs:
           cache: "pnpm"
 
       - name: Install Dependencies
-        run: pnpm install --prefer-frozen-lockfile
+        run: pnpm install --frozen-lockfile
 
       - name: Check TypeScript Types
         run: npx turbo check-types
diff --git a/.github/workflows/database-deploy.yaml b/.github/workflows/database-deploy.yaml
@@ -18,7 +18,7 @@ jobs:
       - name: Install pnpm
         uses: pnpm/action-setup@v4
         with:
-          version: 10.15.0
+          version: 10.15.1
           run_install: false
 
       - uses: actions/setup-node@v4
@@ -27,7 +27,7 @@ jobs:
           cache: "pnpm"
 
       - name: Install Dependencies
-        run: pnpm install --prefer-frozen-lockfile
+        run: pnpm install --frozen-lockfile
 
       - uses: supabase/setup-cli@v1
         with:
diff --git a/.github/workflows/roam-main.yaml b/.github/workflows/roam-main.yaml
@@ -22,7 +22,7 @@ jobs:
       - name: Install pnpm
         uses: pnpm/action-setup@v4
         with:
-          version: 10.15.0
+          version: 10.15.1
           run_install: false
 
       - name: Setup Node.js environment
@@ -32,7 +32,7 @@ jobs:
           cache: "pnpm"
 
       - name: Install Dependencies
-        run: pnpm install --prefer-frozen-lockfile
+        run: pnpm install --frozen-lockfile
 
       - name: Deploy
         run: npx turbo run deploy --filter=roam
diff --git a/.github/workflows/roam-pr.yaml b/.github/workflows/roam-pr.yaml
@@ -25,7 +25,7 @@ jobs:
       - name: Install pnpm
         uses: pnpm/action-setup@v4
         with:
-          version: 10.15.0
+          version: 10.15.1
           run_install: false
 
       - name: Setup Node.js environment
@@ -35,7 +35,7 @@ jobs:
           cache: "pnpm"
 
       - name: Install Dependencies
-        run: pnpm install --prefer-frozen-lockfile
+        run: pnpm install --frozen-lockfile
 
       - name: Deploy
         run: npx turbo run deploy --filter=roam
diff --git a/.github/workflows/roam-release.yaml b/.github/workflows/roam-release.yaml
@@ -20,7 +20,7 @@ jobs:
       - name: Install pnpm
         uses: pnpm/action-setup@v4
         with:
-          version: 10.15.0
+          version: 10.15.1
           run_install: false
 
       - name: Setup Node.js environment
@@ -30,7 +30,7 @@ jobs:
           cache: "pnpm"
 
       - name: Install Dependencies
-        run: pnpm install --prefer-frozen-lockfile
+        run: pnpm install --frozen-lockfile
 
       - name: Update Roam Depot Extension
         run: npx turbo run publish --filter=roam
diff --git a/apps/obsidian/tsconfig.json b/apps/obsidian/tsconfig.json
@@ -14,7 +14,6 @@
     "strictNullChecks": true,
     "paths": {
       "~/*": ["./src/*"]
-    },
-    "types": ["react", "react-dom"]
+    }
   }
 }
diff --git a/apps/roam/package.json b/apps/roam/package.json
@@ -25,7 +25,6 @@
     "axios": "^0.27.2",
     "dotenv": "^16.0.3",
     "esbuild": "0.17.14",
-    "file-saver": "^2.0.2",
     "tailwindcss": "^3.4.17",
     "tsx": "^4.19.2"
   },
diff --git a/apps/roam/scripts/compile.ts b/apps/roam/scripts/compile.ts
@@ -124,7 +124,7 @@ export const args = {
     "marked-react=window.RoamLazy.MarkedReact",
     "nanoid=window.Nanoid;module.exports.nanoid=window.Nanoid",
     'react=window.React;module.exports.useSyncExternalStore=require("use-sync-external-store/shim").useSyncExternalStore',
-    "react/jsx-runtime=node_modules/react/jsx-runtime.js",
+    "react/jsx-runtime=./node_modules/react/jsx-runtime.js",
     "react-dom=window.ReactDOM",
     "react-youtube=window.ReactYoutube",
     "tslib=window.TSLib",
diff --git a/apps/roam/tsconfig.json b/apps/roam/tsconfig.json
@@ -13,7 +13,6 @@
     "allowJs": false,
     "jsx": "react",
     "noUncheckedIndexedAccess": false,
-    "types": ["react", "react-dom"],
     "paths": {
       "~/*": ["./src/*"],
       "react": ["./node_modules/@types/react"],
diff --git a/apps/website/tsconfig.json b/apps/website/tsconfig.json
@@ -5,8 +5,7 @@
     "rootDir": ".",
     "paths": {
       "~/*": ["./app/*"]
-    },
-    "types": ["react", "react-dom", "node"]
+    }
   },
   "include": [
     "next-env.d.ts",
diff --git a/package.json b/package.json
@@ -18,7 +18,7 @@
   "engines": {
     "node": ">=20"
   },
-  "packageManager": "pnpm@10.15.0",
+  "packageManager": "pnpm@10.15.1",
   "workspaces": [
     "apps/*",
     "packages/*"
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -2,12 +2,14 @@ packages:
   - packages/*
   - apps/*
 
+# The global versions, in practice apply to website
 catalog:
   react: ^19.1.0
   react-dom: ^19.1.0
   "@types/react": ^19.1.12
   "@types/react-dom": ^19.1.9
 
+# app-specific versions. Use catalog:roam etc. as versions in package.json
 catalogs:
   obsidian:
     react: 19.0.0
@@ -20,6 +22,7 @@ catalogs:
     "@types/react": 18.2.21
     "@types/react-dom": 18.2.17
 
+# pnpm asks for those if absent.
 onlyBuiltDependencies:
   - core-js
   - core-js-pure
@@ -30,6 +33,7 @@ onlyBuiltDependencies:
   - supabase
   - unrs-resolver
 
+# Use `pnpm why react` etc. to identify which packages request other versions.
 overrides:
   "roam>react": 18.2.0
   "roam>react-dom": 18.2.0
@@ -40,6 +44,7 @@ overrides:
   "react-charts@3.0.0-beta.57>@types/react": "18.2.21"
   "react-charts@3.0.0-beta.57>@types/react-dom": "18.2.17"
 
+# pnpm complained about these, may need review or updates
 allowedDeprecatedVersions:
   "@humanwhocodes/config-array": ^0.13
   "@humanwhocodes/object-schema": ^2.0
@@ -58,6 +63,7 @@ allowedDeprecatedVersions:
   rimraf: "<4"
 
 peerDependencyRules:
+  # This tells pnpm not to complain that our overrides don't match the requested values
   allowedVersions:
     "react-popper@1.3.11>react": 18.2.0
     "react-day-picker@7.4.9>react": 18.2.0

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@`
`14`	`14`	`"strictNullChecks": true,`
`15`	`15`	`"paths": {`
`16`	`16`	`"~/": ["./src/"]`
`17`		`- },`
`18`		`- "types": ["react", "react-dom"]`
	`17`	`+ }`
`19`	`18`	`}`
`20`	`19`	`}`