address review

Author: sid597

apps/roam/src/components/CreateNodeDialog.tsx

@@ -35,21 +35,11 @@ const CreateNodeDialog = ({
     discourseNodes[0];
 
   const [title, setTitle] = useState(initialTitle);
-  const [debouncedTitle, setDebouncedTitle] = useState(initialTitle);
   const [selectedType, setSelectedType] =
     useState<DiscourseNode>(defaultNodeType);
   const [loading, setLoading] = useState(false);
   const inputRef = useRef<HTMLInputElement>(null);
 
-  useEffect(() => {
-    const handler = setTimeout(() => {
-      setDebouncedTitle(title);
-    }, 500);
-    return () => {
-      clearTimeout(handler);
-    };
-  }, [title]);
-
   useEffect(() => {
     if (inputRef.current) {
       inputRef.current.focus();
@@ -147,11 +137,7 @@ const CreateNodeDialog = ({
               onChange={(e) => setTitle(e.currentTarget.value)}
               inputRef={inputRef}
             />
-            <VectorDuplicateMatches
-              pageTitle={debouncedTitle}
-              text={debouncedTitle}
-              limit={5}
-            />
+            <VectorDuplicateMatches text={title} limit={5} />
           </div>
 
           <Label>

apps/roam/src/components/VectorDuplicateMatches.tsx

@@ -1,7 +1,7 @@
 import React, { useEffect, useState, useMemo } from "react";
 import { Collapse, Spinner, Icon } from "@blueprintjs/core";
-import { findSimilarNodesVectorOnly, type VectorMatch } from "../utils/hyde";
-import { useNodeContext, type NodeContext } from "../utils/useNodeContext";
+import { findSimilarNodesVectorOnly, type VectorMatch } from "~/utils/hyde";
+import { useNodeContext, type NodeContext } from "~/utils/useNodeContext";
 import ReactDOM from "react-dom";
 
 type VectorSearchParams = {
@@ -18,19 +18,32 @@ export const VectorDuplicateMatches = ({
   text,
   limit = 15,
 }: {
-  pageTitle: string;
+  pageTitle?: string;
   text?: string;
   limit?: number;
 }) => {
+  const [debouncedText, setDebouncedText] = useState(text);
+  useEffect(() => {
+    const handler = setTimeout(() => {
+      setDebouncedText(text);
+    }, 500);
+    return () => {
+      clearTimeout(handler);
+    };
+  }, [text]);
+
   const [isOpen, setIsOpen] = useState(false);
   const [suggestionsLoading, setSuggestionsLoading] = useState(false);
   const [hasSearched, setHasSearched] = useState(false);
   const [suggestions, setSuggestions] = useState<VectorMatch[]>([]);
 
-  const nodeContext: NodeContext | null = useNodeContext(pageTitle);
+  const nodeContext: NodeContext | null = useNodeContext(pageTitle || "");
   const activeContext = useMemo(
-    () => (text ? { searchText: text, pageUid: null } : nodeContext),
-    [text, nodeContext],
+    () =>
+      text !== undefined
+        ? { searchText: debouncedText || "", pageUid: null }
+        : nodeContext,
+    [text, debouncedText, nodeContext],
   );
 
   useEffect(() => {
@@ -101,7 +114,7 @@ export const VectorDuplicateMatches = ({
       >
         <div className="flex items-center gap-2">
           <Icon icon={isOpen ? "chevron-down" : "chevron-right"} />
-          <h5 className="m-0 font-semibold">Plain Vector Search Matches</h5>
+          <h5 className="m-0 font-semibold">Possible Duplicates</h5>
         </div>
         {hasSearched && !suggestionsLoading && hasSuggestions && (
           <span className="rounded-full bg-orange-500 px-2 py-0.5 text-xs text-white">
@@ -137,9 +150,6 @@ export const VectorDuplicateMatches = ({
                   >
                     {match.node.text}
                   </a>
-                  <span className="ml-2 shrink-0 text-xs tabular-nums text-gray-500">
-                    {match.score.toFixed(3)}
-                  </span>
                 </li>
               ))}
             </ul>

apps/roam/src/utils/hyde.ts

@@ -1,6 +1,7 @@
 import { getLoggedInClient, getSupabaseContext } from "./supabaseContext";
 import { Result } from "./types";
 import normalizePageTitle from "roamjs-components/queries/normalizePageTitle";
+import { render as renderToast } from "roamjs-components/components/Toast";
 import findDiscourseNode from "./findDiscourseNode";
 import { nextApiRoot } from "@repo/utils/execContext";
 import { DiscourseNode } from "./getDiscourseNodes";
@@ -58,7 +59,7 @@ type EmbeddingFunc = (text: string) => Promise<EmbeddingVectorType>;
 
 type SearchFunc = (params: {
   queryEmbedding: EmbeddingVectorType;
-  indexData: { uid: string; text: string }[];
+  indexData: Result[];
 }) => Promise<NodeSearchResult[]>;
 
 const API_CONFIG = {
@@ -173,7 +174,7 @@ const createEmbedding: EmbeddingFunc = async (
   }
 };
 
-export const searchEmbeddings: SearchFunc = async ({
+const searchEmbeddings: SearchFunc = async ({
   queryEmbedding,
   indexData,
 }): Promise<NodeSearchResult[]> => {
@@ -568,23 +569,24 @@ export const findSimilarNodesVectorOnly = async ({
 
     if (!data || !Array.isArray(data)) return [];
 
-    const results: VectorMatch[] = data.map(
-      (item: {
-        roam_uid: string;
-        text_content: string;
-        similarity: number;
-      }) => ({
-        node: {
-          uid: item.roam_uid,
-          text: item.text_content,
-        },
-        score: item.similarity,
-      }),
-    );
+    const results: VectorMatch[] = data.map((item) => ({
+      node: {
+        uid: item.roam_uid,
+        text: item.text_content,
+      },
+      score: item.similarity,
+    }));
 
     return results;
   } catch (error) {
     console.error("Error in vector-only similar nodes search:", error);
+    renderToast({
+      content: `Error in vector-only similar nodes search: ${
+        error instanceof Error ? error.message : String(error)
+      }`,
+      intent: "danger",
+      id: "vector-search-error",
+    });
     return [];
   }
 };