coderabbit comments

Author: maparent

apps/roam/src/components/CreateRelationDialog.tsx

@@ -94,8 +94,7 @@ const CreateRelationDialog = ({
       // should not happen at this point, since the pattern was vetted at input.
       internalError({
         type: "create-relation-error",
-        error:
-          "Create Relation dialog: Could not find identify node downstream",
+        error: "Create Relation dialog: Could not identify node downstream",
       });
       return null;
     }
@@ -275,7 +274,7 @@ const prepareRelData = (
   if (!nodeSchema) {
     // should not happen at this point, since the pattern was vetted at input.
     internalError({
-      error: "Create Relation dialog: Could not find identify node downstream",
+      error: "Create Relation dialog: Could not identify node downstream",
       type: "create-relation-error",
     });
     return [];

apps/roam/src/components/canvas/useRoamStore.ts

@@ -136,10 +136,10 @@ export const useRoamStore = ({
 
     const handleStoreError = ({
       error,
-      errorMessage,
+      type,
     }: {
       error: Error;
-      errorMessage: string;
+      type: string;
     }): void => {
       setError(error);
       setLoading(false);
@@ -148,7 +148,7 @@ export const useRoamStore = ({
         : 0;
       internalError({
         error,
-        type: "roam-store-error",
+        type,
         context: {
           pageUid,
           snapshotSize,
@@ -169,7 +169,7 @@ export const useRoamStore = ({
     } catch (e) {
       handleStoreError({
         error: e as Error,
-        errorMessage: "Failed to create TLStore",
+        type: "tlstore-creation-failure",
       });
       return null;
     }
@@ -180,7 +180,7 @@ export const useRoamStore = ({
       } catch (e) {
         handleStoreError({
           error: e as Error,
-          errorMessage: "Failed to migrate snapshot",
+          type: "snapshot-migration-failure",
         });
         return null;
       }

apps/roam/src/utils/internalError.ts

@@ -14,7 +14,7 @@ const internalError = ({
   type?: string;
   userMessage?: string;
   context?: Properties;
-}) => {
+}): void => {
   if (process.env.NODE_ENV === "development") {
     console.error(error, context);
   } else {