Skip to content

Character counts for design title and summary #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jklewa wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Character counts for design title and summary #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/app/components/design/design-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ const DesignForm = () => {
const router = useRouter();
const [description, setDescription] = useState<string>("");
const [errorMessage, setErrorMessage] = useState<string | null>(null);
const [titleCount, setTitleCount] = useState(0);
const [summaryCount, setSummaryCount] = useState(0);

const form = useForm<DesignCreateSchema>({
resolver: zodResolver(designCreateSchema),
Expand All @@ -57,6 +59,11 @@ const DesignForm = () => {
};
}, []);

useEffect(() => {
setTitleCount(form.getValues('main_name')?.length || 0);
setSummaryCount(form.getValues('summary')?.length || 0);
}, [form]);

const onSubmit = async (data: DesignCreateSchema) => {
setErrorMessage(null); // Clear previous errors
try {
Expand Down Expand Up @@ -99,8 +106,13 @@ const DesignForm = () => {
{...field}
required
className="border border-gray-300 rounded-md p-2"
onChange={e => {
field.onChange(e);
setTitleCount(e.target.value.length);
}}
/>
</FormControl>
<div className="text-xs text-gray-500 text-right">{titleCount}</div>
</FormItem>
)}
/>
Expand All @@ -120,8 +132,13 @@ const DesignForm = () => {
{...field}
required
className="border border-gray-300 rounded-md p-2"
onChange={e => {
field.onChange(e);
setSummaryCount(e.target.value.length);
}}
/>
</FormControl>
<div className="text-xs text-gray-500 text-right">{summaryCount}</div>
</FormItem>
)}
/>
Expand Down
19 changes: 19 additions & 0 deletions src/app/design/[designID]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ const DesignDetailsPage = () => {
const [errorMessage, setErrorMessage] = useState<string | null>(null);
const [successMessage, setSuccessMessage] = useState<string | null>(null);
const [editMode, setEditMode] = useState(false);
const [titleCount, setTitleCount] = useState(0);
const [summaryCount, setSummaryCount] = useState(0);
const { register, handleSubmit, reset, formState: { errors } } = useForm();
const router = useRouter();
const resetForm = (design: DesignSchema) => {
Expand Down Expand Up @@ -181,6 +183,13 @@ const DesignDetailsPage = () => {
}
};

useEffect(() => {
if (editMode) {
setTitleCount(design?.main_name?.length || 0);
setSummaryCount(design?.summary?.length || 0);
}
}, [editMode, design]);

if (!design) return <div>Loading...</div>;

return (
Expand Down Expand Up @@ -221,7 +230,12 @@ const DesignDetailsPage = () => {
{...register('main_name', { required: true })}
defaultValue={design.main_name}
className="w-full"
onChange={e => {
register('main_name').onChange(e);
setTitleCount(e.target.value.length);
}}
/>
<div className="text-xs text-gray-500 text-right">{titleCount} Characters</div>
{errors.main_name && <p className="text-red-500 text-sm">Name is required</p>}
</div>

Expand All @@ -232,7 +246,12 @@ const DesignDetailsPage = () => {
defaultValue={design.summary}
className="w-full border rounded-md p-2"
rows={2}
onChange={e => {
register('summary').onChange(e);
setSummaryCount(e.target.value.length);
}}
/>
<div className="text-xs text-gray-500 text-right">{summaryCount} Characters</div>
{errors.summary && <p className="text-red-500 text-sm">Summary is required</p>}
</div>

Expand Down