Modifying queries that use information from date and datetime columns

[Kadri0]

Since different CDM versions have different requirements regarding condition_occurrence.condition_start_datetime and condition_occurrence.condition_start_date, the SQL queries should be modified to use the column that has data.

[SulevR]

This does not affect only condition_occurrence, but also other tables (such as drugs, procedures). One option is to make COALESCE(what is filled in), but this works only in case all columns exist. This is a problem for death data, for instance, because in 5.1 there is a separate table for DEATHs, but since v6 death fact is written to PERSON table instead...

So, we may need to make separate SQL scripts for v5 and v6.

Currently, I think we may declare support for v5.3 only in our package as I think that very few have moved to v6. What do you think, @solis9753 @Kadri0 ?

[Kadri0]

@SulevR I think it might be a better idea to declare support vor v5.3 right now and make sure all columns used in the SQL scripts suit that version. Separate SQL scripts for v6 could be implemented later after more pressing issues have been resolved first, in my opinion.

[ioannousolon]

I think Kadri's suggestion above makes sense: support for v5 may suffice for now. I see other packages e.g FeatureExtraction maintain only a v5 support.

I saw somewhere that OHDSI CDM Builders/Developers still suggest implementing v5.3 but cannot find a reference. Will ask ask few people here and there too.

[SulevR]

Yes, makes sense. So lets stick to v5.3 then!

[smusali]

@SulevR @Kadri0 @solis9753 @raivokolde has this issue been resolved? If so, can we close this issue?