Open
Conversation
| <url-pattern>/add</url-pattern> | ||
| </servlet-mapping> | ||
|
|
||
| <servlet> |
There was a problem hiding this comment.
Possible simplification: All these descriptions could be replaced by @WebServlet("/YOUR_PATH") annotation above the Servlet class (import javax.servlet.annotation.WebServlet.
|
|
||
| <div class="container signin"> | ||
| <p>Already have an account? <a href="#">Sign in</a>.</p> | ||
| <p>Already have an account? <a href="/singin">Sign in</a>.</p> |
There was a problem hiding this comment.
Please implement the POST method for Sign-in servlet or put a mock-up (fake until you make it).
| <label for="email"><b>Email</b></label> | ||
| <input type="text" placeholder="Enter Email" name="email" required> | ||
| <label for="username"><b>Username</b></label> | ||
| <input type="text" placeholder="Enter uername" name="username" required> |
There was a problem hiding this comment.
Please fix typo in the placeholder
| <%@ page contentType="text/html;charset=UTF-8" language="java" %> | ||
| <html> | ||
| <head> | ||
| <title>Регистрация</title> |
There was a problem hiding this comment.
Please be consistent with the used language (don't mix Russian and English).
All the fields that are language-sensitive can be set up using different locales. Since the project doesn't provide the "language change" option, it would be better to stick with only one language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.