-
Notifications
You must be signed in to change notification settings - Fork 8
Description
Imported from GitHub by @guitarrabyte
Migrated from GitHub #47
Add Support for Docker Compose V2 in Makefile
Feature Request
Hey everyone! This is my first contribution here. I wasn't sure if I should reach out to anyone before contributing, but the docs said to contribute just open a pull request. If you're okay with me tackling this, I'd like to open a PR.
I'd like to enhance the Makefile to support Docker Compose V2, where the command has changed to docker compose instead of docker-compose.
Current Situation
The current Makefile assumes the presence of docker-compose, which is the command used by Docker Compose V1. Users who have Docker Compose V2 installed (which uses docker compose) will experience a failure during the make install process, as the command docker-compose is not found.
While the documentation currently instructs users to install Docker Compose V1, this feature will add support for Docker Compose V2, ensuring compatibility for future installations.
Proposed Solution
- Implement a conditional check in the Makefile to detect whether
docker-composeordocker composeis available. - Set a variable to the detected Docker Compose command.
- Update the Makefile to use this variable for Docker Compose commands.
- Add error handling to stop the make process if neither command is found, prompting the user to install Docker Compose.
Benefits
This feature will ensure compatibility with both Docker Compose V1 and V2, providing a smoother installation experience for users regardless of the version they have installed.