Skip to content

github pass / fail badge not accurate anymore #54

@rhaas80

Description

@rhaas80

GitHub's pass / fail badge is based on the state of the workflow. Right now however this no longer correctly set and leads to a failing test not showing up:

image

There's code in the workflow:

      # If a test failed the workflow exit with a failing status
      - name: Clean up
        if: ${{env.TESTS_FAILED == 'True'}}
        run: exit 1

but apparently it never triggers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions