-
Notifications
You must be signed in to change notification settings - Fork 205
Open
Description
Apple releases new devices each year(sometimes some season), and it force this library to release new version whenever new size of device came out.
When it comes to device size, most of people expect this lib to do its best effort, I think.
So I'd like to propose Device.size to return the nearest size as long as they know in the released version.
Once my proposal accepted, Device.size would be implemented like below.
static public func size() -> Size {
/ * bra bra bra * /
switch screenHeight {
case 0...480:
return .screen3_5Inch
case 481...568:
return .screen4Inch
case 569...667:
return UIScreen.main.scale == 3.0 ? .screen5_5Inch : .screen4_7Inch
case 668...736:
return .screen5_5Inch
/* and so on... */
What do you people think about this?
jonahollman, bogdanicc, Tooflex and ozgur-useinsider
Metadata
Metadata
Assignees
Labels
No labels