Users cannot see administrator comments

[ewinslow]

We have been leaving comments explaining why a site cannot be accepted, but never seem to get a response. I was suspicious that people might not be able to see them at all and logging in as someone today to check. Sure enough, they cannot see our comments so they are totally in the dark about what they need to do to get their site approved.

[beck24]

I think this is a core issue actually. We're commenting on an entity that is ACCESS_PRIVATE, so the comment inherits the access, but since we own our own comments the comment is private to us...
I believe there is a longstanding ticket open for this issue (it was originally logged as not being able to see some comments with ACCESS_FRIENDS)

[beck24]

That is sad that our comments haven't been seen though...

[juho-jaakkola]

I was thinking that a quick and dirty fix could be to ignore access in page/elements/comments in case user is the owner of the commented entity.

But this still wouldn't e.g. allow the user to receive notifications about the new comments.

[ewinslow]

I think they need to receive notifications for this to be useful at all.

On Thu, Jul 31, 2014, 10:59 PM Juho Jaakkola notifications@github.com
wrote:

I was thinking that a quick and dirty fix could be to ignore access in
page/elements/comments in case user is the owner of the commented entity.

But this still wouldn't e.g. allow the user to receive notifications about
the new comments.

—
Reply to this email directly or view it on GitHub
#38 (comment).

[juho-jaakkola]

I was mistaken. The user does receive a notification despite the comment being private.

So all we need for a quick & dirty fix is to ignore access. See: Elgg/Elgg#3391 (comment)

[brettp]

So a user receives a notification to visit a page they can't access?
Yikes.....

On Fri, Aug 1, 2014 at 6:06 AM, Juho Jaakkola notifications@github.com
wrote:

I was mistaken. The user does receive a notification despite the
comment being private.

So all we need for a quick & dirty fix is to ignore access. See: Elgg/Elgg#3391
(comment) Elgg/Elgg#3391 (comment)

—
Reply to this email directly or view it on GitHub
#38 (comment).

Brett Profitt
Elgg Lead Developer

Elgg: http://elgg.org/
Skype: brett.profitt
Twitter: http://twitter.com/brettprofitt

[beck24]

They can access the page, just not the comments

[brettp]

I'm not sure if that's better or worse.

On Fri, Aug 1, 2014 at 11:24 AM, Matt Beckett notifications@github.com
wrote:

They can access the page, just not the comments

—
Reply to this email directly or view it on GitHub
#38 (comment).

Brett Profitt
Elgg Lead Developer

Elgg: http://elgg.org/
Skype: brett.profitt
Twitter: http://twitter.com/brettprofitt